From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
Thomas Gleixner <tglx@linutronix.de>,
Leonard Crestez <leonard.crestez@nxp.com>,
cphealy@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] irqchip/irq-imx-gpcv2: Make error messages more consistent
Date: Thu, 06 Dec 2018 12:32:05 +0100 [thread overview]
Message-ID: <1544095925.3709.61.camel@pengutronix.de> (raw)
In-Reply-To: <20181206073125.7255-5-andrew.smirnov@gmail.com>
Am Mittwoch, den 05.12.2018, 23:31 -0800 schrieb Andrey Smirnov:
> Make error messages more consistent by making sure each starts with
> "%pOF:".
>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Jason Cooper <jason@lakedaemon.net>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: cphealy@gmail.com
> Cc: l.stach@pengutronix.de
> > Cc: Leonard Crestez <leonard.crestez@nxp.com>
> > Cc: "A.s. Dong" <aisheng.dong@nxp.com>
> > Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: linux-imx@nxp.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/irqchip/irq-imx-gpcv2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 077d56b3183a..c2b2b3128ddd 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -212,7 +212,7 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>
> > cd = kzalloc(sizeof(struct gpcv2_irqchip_data), GFP_KERNEL);
> > if (!cd) {
> > - pr_err("kzalloc failed!\n");
> > + pr_err("%pOF: kzalloc failed!\n", node);
> > return -ENOMEM;
> > }
>
> @@ -220,7 +220,7 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
>
> > cd->gpc_base = of_iomap(node, 0);
> > if (!cd->gpc_base) {
> > - pr_err("fsl-gpcv2: unable to map gpc registers\n");
> > + pr_err("%pOF: unable to map gpc registers\n", node);
> > kfree(cd);
> > return -ENOMEM;
> > }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-06 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 7:31 [PATCH 0/5] i.MX8MQ support for GPCv2 irqchip driver Andrey Smirnov
2018-12-06 7:31 ` [PATCH 1/5] irqchip/irq-imx-gpcv2: Remove unused code Andrey Smirnov
2018-12-06 11:10 ` Lucas Stach
2018-12-06 7:31 ` [PATCH 2/5] irqchip/irq-imx-gpcv2: Share reg offset calculation code Andrey Smirnov
2018-12-06 11:11 ` Lucas Stach
2018-12-06 7:31 ` [PATCH 3/5] irqchip/irq-imx-gpcv2: Make use of BIT() macro Andrey Smirnov
2018-12-06 11:12 ` Lucas Stach
2018-12-06 7:31 ` [PATCH 4/5] irqchip/irq-imx-gpcv2: Make error messages more consistent Andrey Smirnov
2018-12-06 11:32 ` Lucas Stach [this message]
2018-12-06 7:31 ` [PATCH 5/5] irqchip/irq-imx-gpcv2: Add support for i.MX8MQ Andrey Smirnov
2018-12-06 11:36 ` Lucas Stach
2018-12-07 17:30 ` [PATCH 0/5] i.MX8MQ support for GPCv2 irqchip driver Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544095925.3709.61.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=jason@lakedaemon.net \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox