public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN
@ 2016-02-16 14:54 Arnd Bergmann
  2016-02-21 13:07 ` Markus Pargmann
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-16 14:54 UTC (permalink / raw)
  To: linux-arm-kernel

The newly added tsadc code use irq domains, but it can be enabled
when they are disabled in Kconfig:

drivers/mfd/fsl-imx25-tsadc.c:41:22: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
   generic_handle_irq(irq_find_mapping(tsadc->domain, 1));
drivers/mfd/fsl-imx25-tsadc.c: In function 'mx25_tsadc_setup_irq':
drivers/mfd/fsl-imx25-tsadc.c:80:18: error: implicit declaration of function 'irq_domain_add_simple' [-Werror=implicit-function-declaration]

This adds a 'select IRQ_DOMAIN' code, like we have it in all other
drivers with this requirement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e2fccf5c1515 ("mfd: fsl-imx25-tsadc: Register touchscreen ADC driver")
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index aa21dc55eb15..8cab3ecca8fc 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -300,6 +300,7 @@ config MFD_MC13XXX_I2C
 config MFD_MX25_TSADC
 	tristate "Freescale i.MX25 integrated Touchscreen and ADC unit"
 	select REGMAP_MMIO
+	select IRQ_DOMAIN
 	depends on (SOC_IMX25 && OF) || COMPILE_TEST
 	help
 	  Enable support for the integrated Touchscreen and ADC unit of the
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN
  2016-02-16 14:54 [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN Arnd Bergmann
@ 2016-02-21 13:07 ` Markus Pargmann
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Pargmann @ 2016-02-21 13:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Tuesday 16 February 2016 15:54:24 Arnd Bergmann wrote:
> The newly added tsadc code use irq domains, but it can be enabled
> when they are disabled in Kconfig:
> 
> drivers/mfd/fsl-imx25-tsadc.c:41:22: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
>    generic_handle_irq(irq_find_mapping(tsadc->domain, 1));
> drivers/mfd/fsl-imx25-tsadc.c: In function 'mx25_tsadc_setup_irq':
> drivers/mfd/fsl-imx25-tsadc.c:80:18: error: implicit declaration of function 'irq_domain_add_simple' [-Werror=implicit-function-declaration]
> 
> This adds a 'select IRQ_DOMAIN' code, like we have it in all other
> drivers with this requirement.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: e2fccf5c1515 ("mfd: fsl-imx25-tsadc: Register touchscreen ADC driver")

Thanks,

Reviewed-by: Markus Pargmann <mpa@pengutronix.de>

Best Regards,

Markus

> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index aa21dc55eb15..8cab3ecca8fc 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -300,6 +300,7 @@ config MFD_MC13XXX_I2C
>  config MFD_MX25_TSADC
>  	tristate "Freescale i.MX25 integrated Touchscreen and ADC unit"
>  	select REGMAP_MMIO
> +	select IRQ_DOMAIN
>  	depends on (SOC_IMX25 && OF) || COMPILE_TEST
>  	help
>  	  Enable support for the integrated Touchscreen and ADC unit of the
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160221/ef514e0f/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-21 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 14:54 [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN Arnd Bergmann
2016-02-21 13:07 ` Markus Pargmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox