From: Stephen Boyd <swboyd@chromium.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: mark.rutland@arm.com, Julien Thierry <julien.thierry@arm.com>,
maz@kernel.org, Will Deacon <will.deacon@arm.com>,
catalin.marinas@arm.com, will@kernel.org,
Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH v5 6/7] arm_pmu: Introduce pmu_irq_ops
Date: Wed, 17 Jun 2020 13:23:12 -0700 [thread overview]
Message-ID: <159242539231.62212.11549121838391298623@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200617113851.607706-7-alexandru.elisei@arm.com>
Quoting Alexandru Elisei (2020-06-17 04:38:50)
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index df352b334ea7..17e5952d21e4 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -26,8 +26,46 @@
>
> #include <asm/irq_regs.h>
>
> +static int armpmu_count_irq_users(const int irq);
> +
> +struct pmu_irq_ops {
> + void (*enable_pmuirq)(unsigned int irq);
> + void (*disable_pmuirq)(unsigned int irq);
> + void (*free_pmuirq)(unsigned int irq, int cpu, void __percpu *devid);
Does 'cpu' need to be signed?
> +};
> +
> +static void armpmu_free_pmuirq(unsigned int irq, int cpu, void __percpu *devid)
> +{
> + free_irq(irq, per_cpu_ptr(devid, cpu));
> +}
> +
> +static const struct pmu_irq_ops pmuirq_ops = {
> + .enable_pmuirq = enable_irq,
> + .disable_pmuirq = disable_irq_nosync,
> + .free_pmuirq = armpmu_free_pmuirq
> +};
> +
> +static void armpmu_enable_percpu_pmuirq(unsigned int irq)
> +{
> + enable_percpu_irq(irq, IRQ_TYPE_NONE);
> +}
> +
> +static void armpmu_free_percpu_pmuirq(unsigned int irq, int cpu,
> + void __percpu *devid)
> +{
> + if (armpmu_count_irq_users(irq) == 1)
> + free_percpu_irq(irq, devid);
> +}
> +
> +static const struct pmu_irq_ops percpu_pmuirq_ops = {
> + .enable_pmuirq = armpmu_enable_percpu_pmuirq,
> + .disable_pmuirq = disable_percpu_irq,
> + .free_pmuirq = armpmu_free_percpu_pmuirq
> +};
> +
> static DEFINE_PER_CPU(struct arm_pmu *, cpu_armpmu);
> static DEFINE_PER_CPU(int, cpu_irq);
Same question as above.
> +static DEFINE_PER_CPU(const struct pmu_irq_ops *, cpu_irq_ops);
>
> static inline u64 arm_pmu_event_max_period(struct perf_event *event)
> {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-17 20:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 11:38 [PATCH v5 0/7] arm_pmu: Use NMI for perf interrupt Alexandru Elisei
2020-06-17 11:38 ` [PATCH v5 1/7] arm64: perf: Add missing ISB in armv8pmu_enable_event() Alexandru Elisei
2020-06-17 20:01 ` Stephen Boyd
2020-06-18 10:50 ` Alexandru Elisei
2020-06-17 11:38 ` [PATCH v5 2/7] arm64: perf: Avoid PMXEV* indirection Alexandru Elisei
2020-06-17 20:11 ` Stephen Boyd
2020-06-18 10:51 ` Alexandru Elisei
2020-06-19 8:26 ` Stephen Boyd
2020-06-17 11:38 ` [PATCH v5 3/7] arm64: perf: Remove PMU locking Alexandru Elisei
2020-06-17 20:17 ` Stephen Boyd
2020-06-18 10:51 ` Alexandru Elisei
2020-06-19 8:29 ` Stephen Boyd
2020-07-03 13:45 ` Will Deacon
2020-06-17 11:38 ` [PATCH v5 4/7] arm64: perf: Defer irq_work to IPI_IRQ_WORK Alexandru Elisei
2020-06-17 11:38 ` [PATCH v5 5/7] arm64: kvm: pmu: Make overflow handler NMI safe Alexandru Elisei
2020-06-17 11:38 ` [PATCH v5 6/7] arm_pmu: Introduce pmu_irq_ops Alexandru Elisei
2020-06-17 20:23 ` Stephen Boyd [this message]
2020-06-18 10:51 ` Alexandru Elisei
2020-06-19 8:33 ` Stephen Boyd
2020-06-17 11:38 ` [PATCH v5 7/7] arm_pmu: arm64: Use NMIs for PMU Alexandru Elisei
2020-06-25 15:11 ` [PATCH v5 0/7] arm_pmu: Use NMI for perf interrupt Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159242539231.62212.11549121838391298623@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox