Re: [PATCH 1/2] clk: Export clk_register_composite

Re: [PATCH 1/2] clk: Export clk_register_composite

[Stephen Boyd]

Quoting Wendell Lin (2020-07-01 00:26:21)
> clk_register_composite() will be used in mediatek's
> clock kernel module, so export it to GPL modules.
> 
> Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> ---
>  drivers/clk/clk-composite.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> index 7376f57..fb5cb4a 100644
> --- a/drivers/clk/clk-composite.c
> +++ b/drivers/clk/clk-composite.c
> @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
>                 return ERR_CAST(hw);
>         return hw->clk;
>  }
> +EXPORT_SYMBOL(clk_register_composite);

Should be EXPORT_SYMBOL_GPL()

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] clk: Export clk_register_composite

[Wendell Lin]

On Fri, 2020-07-10 at 17:26 -0700, Stephen Boyd wrote:
> Quoting Wendell Lin (2020-07-01 00:26:21)
> > clk_register_composite() will be used in mediatek's
> > clock kernel module, so export it to GPL modules.
> > 
> > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> > ---
> >  drivers/clk/clk-composite.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
> > index 7376f57..fb5cb4a 100644
> > --- a/drivers/clk/clk-composite.c
> > +++ b/drivers/clk/clk-composite.c
> > @@ -360,6 +360,7 @@ struct clk *clk_register_composite(struct device *dev, const char *name,
> >                 return ERR_CAST(hw);
> >         return hw->clk;
> >  }
> > +EXPORT_SYMBOL(clk_register_composite);
> 
> Should be EXPORT_SYMBOL_GPL()

Got it, I'll fix it.

Regards,
Wendell

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support

[Stephen Boyd]

Quoting Wendell Lin (2020-07-01 00:26:22)
> Export common APIs from Mediatek clock driver.
> 
> Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>

Is this needed for something? I'd prefer to see some sort of mediatek
modular patches that included this patch in it before this is applied.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support

[Wendell Lin]

On Sat, 2020-07-11 at 09:26 -0700, Stephen Boyd wrote:
> Quoting Wendell Lin (2020-07-01 00:26:22)
> > Export common APIs from Mediatek clock driver.
> > 
> > Signed-off-by: Wendell Lin <wendell.lin@mediatek.com>
> 
> Is this needed for something? I'd prefer to see some sort of mediatek
> modular patches that included this patch in it before this is applied.

Got it. 
I'll prepare a new series of mediatek modular patches that included this
patch in it later.

Regards,
Wendell

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel