* acpi: fix 'return' with no value build warning @ 2020-07-31 3:39 Neal Liu 2020-07-31 3:39 ` [PATCH] " Neal Liu 0 siblings, 1 reply; 4+ messages in thread From: Neal Liu @ 2020-07-31 3:39 UTC (permalink / raw) To: Rafael J. Wysocki, Len Brown, Daniel Lezcano, Thierry Reding, Jonathan Hunter, Jacob Pan, Matthias Brugger, Sami Tolvanen Cc: wsd_upstream, linux-pm, lkml, linux-acpi, linux-mediatek, linux-tegra, Neal Liu, linux-arm-kernel *** BLURB HERE *** Neal Liu (1): acpi: fix 'return' with no value build warning drivers/acpi/processor_idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] acpi: fix 'return' with no value build warning 2020-07-31 3:39 acpi: fix 'return' with no value build warning Neal Liu @ 2020-07-31 3:39 ` Neal Liu 2020-07-31 11:33 ` Rafael J. Wysocki 0 siblings, 1 reply; 4+ messages in thread From: Neal Liu @ 2020-07-31 3:39 UTC (permalink / raw) To: Rafael J. Wysocki, Len Brown, Daniel Lezcano, Thierry Reding, Jonathan Hunter, Jacob Pan, Matthias Brugger, Sami Tolvanen Cc: wsd_upstream, linux-pm, lkml, linux-acpi, linux-mediatek, linux-tegra, Neal Liu, linux-arm-kernel Fixing CFI issue which introduced by commit efe9711214e6 is incomplete. Add return value to fix return-type build warning. Signed-off-by: Neal Liu <neal.liu@mediatek.com> --- drivers/acpi/processor_idle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 6ffb6c9..6870020 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, struct acpi_processor *pr = __this_cpu_read(processors); if (unlikely(!pr)) - return; + return -EFAULT; if (pr->flags.bm_check) { acpi_idle_enter_bm(pr, cx, false); - return; + return 0; } else { ACPI_FLUSH_CPU_CACHE(); } -- 1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: fix 'return' with no value build warning 2020-07-31 3:39 ` [PATCH] " Neal Liu @ 2020-07-31 11:33 ` Rafael J. Wysocki 2020-08-03 2:40 ` Neal Liu 0 siblings, 1 reply; 4+ messages in thread From: Rafael J. Wysocki @ 2020-07-31 11:33 UTC (permalink / raw) To: Neal Liu Cc: Jacob Pan, linux-tegra, wsd_upstream, Linux PM, Daniel Lezcano, Rafael J. Wysocki, lkml, Jonathan Hunter, ACPI Devel Maling List, Thierry Reding, moderated list:ARM/Mediatek SoC..., Sami Tolvanen, Matthias Brugger, Linux ARM, Len Brown On Fri, Jul 31, 2020 at 5:39 AM Neal Liu <neal.liu@mediatek.com> wrote: > > Fixing CFI issue which introduced by commit efe9711214e6 is > incomplete. > Add return value to fix return-type build warning. > > Signed-off-by: Neal Liu <neal.liu@mediatek.com> Applied with edited subject and changelog, but -> > --- > drivers/acpi/processor_idle.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index 6ffb6c9..6870020 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > struct acpi_processor *pr = __this_cpu_read(processors); > > if (unlikely(!pr)) > - return; > + return -EFAULT; -> there is no point returning an error code here, so I've made it just return 0. > > if (pr->flags.bm_check) { > acpi_idle_enter_bm(pr, cx, false); > - return; > + return 0; > } else { > ACPI_FLUSH_CPU_CACHE(); > } > -- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: fix 'return' with no value build warning 2020-07-31 11:33 ` Rafael J. Wysocki @ 2020-08-03 2:40 ` Neal Liu 0 siblings, 0 replies; 4+ messages in thread From: Neal Liu @ 2020-08-03 2:40 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Jacob Pan, linux-tegra, wsd_upstream, Linux PM, Daniel Lezcano, Rafael J. Wysocki, lkml, Jonathan Hunter, ACPI Devel Maling List, Thierry Reding, Neal Liu, Sami Tolvanen, Matthias Brugger, moderated list:ARM/Mediatek SoC..., Linux ARM, Len Brown On Fri, 2020-07-31 at 13:33 +0200, Rafael J. Wysocki wrote: > On Fri, Jul 31, 2020 at 5:39 AM Neal Liu <neal.liu@mediatek.com> wrote: > > > > Fixing CFI issue which introduced by commit efe9711214e6 is > > incomplete. > > Add return value to fix return-type build warning. > > > > Signed-off-by: Neal Liu <neal.liu@mediatek.com> > > Applied with edited subject and changelog, but -> > > > --- > > drivers/acpi/processor_idle.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > > index 6ffb6c9..6870020 100644 > > --- a/drivers/acpi/processor_idle.c > > +++ b/drivers/acpi/processor_idle.c > > @@ -664,11 +664,11 @@ static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > > struct acpi_processor *pr = __this_cpu_read(processors); > > > > if (unlikely(!pr)) > > - return; > > + return -EFAULT; > > -> there is no point returning an error code here, so I've made it > just return 0. return 0 is not matched with the meaning of contexts, but it's fine for this patch. Thanks ! > > > > > if (pr->flags.bm_check) { > > acpi_idle_enter_bm(pr, cx, false); > > - return; > > + return 0; > > } else { > > ACPI_FLUSH_CPU_CACHE(); > > } > > -- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-03 2:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-07-31 3:39 acpi: fix 'return' with no value build warning Neal Liu 2020-07-31 3:39 ` [PATCH] " Neal Liu 2020-07-31 11:33 ` Rafael J. Wysocki 2020-08-03 2:40 ` Neal Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox