* [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
@ 2013-06-26 10:02 Bartlomiej Zolnierkiewicz
2013-06-26 14:52 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-06-26 10:02 UTC (permalink / raw)
To: linux-arm-kernel
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
Building marzen_defconfig for next-20130626 results in the following
build error:
drivers/built-in.o: In function `sh_mobile_sdhi_probe':
/home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'
Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This
will result in CONFIG_SH_DMAE_BASE being enabled by default and the
needed code being build.
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
arch/arm/configs/marzen_defconfig | 1 +
1 file changed, 1 insertion(+)
Index: b/arch/arm/configs/marzen_defconfig
===================================================================
--- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200
+++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200
@@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_GPIO=y
+CONFIG_DMADEVICES=y
CONFIG_UIO=y
CONFIG_UIO_PDRV_GENIRQ=y
# CONFIG_IOMMU_SUPPORT is not set
^ permalink raw reply [flat|nested] 5+ messages in thread
* [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
2013-06-26 10:02 [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support Bartlomiej Zolnierkiewicz
@ 2013-06-26 14:52 ` Simon Horman
2013-06-26 15:01 ` Guennadi Liakhovetski
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2013-06-26 14:52 UTC (permalink / raw)
To: linux-arm-kernel
[ Cc linux-sh and Guennadi ]
I have not looked into this closely but it seems to me that
it would be more robust to resolve this problem using Kconfig.
On Wed, Jun 26, 2013 at 12:02:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
>
> Building marzen_defconfig for next-20130626 results in the following
> build error:
>
> drivers/built-in.o: In function `sh_mobile_sdhi_probe':
> /home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'
>
> Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This
> will result in CONFIG_SH_DMAE_BASE being enabled by default and the
> needed code being build.
>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> arch/arm/configs/marzen_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: b/arch/arm/configs/marzen_defconfig
> ===================================================================
> --- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200
> +++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200
> @@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
> +CONFIG_DMADEVICES=y
> CONFIG_UIO=y
> CONFIG_UIO_PDRV_GENIRQ=y
> # CONFIG_IOMMU_SUPPORT is not set
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
2013-06-26 14:52 ` Simon Horman
@ 2013-06-26 15:01 ` Guennadi Liakhovetski
2013-06-27 5:00 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Guennadi Liakhovetski @ 2013-06-26 15:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi
On Wed, 26 Jun 2013, Simon Horman wrote:
> [ Cc linux-sh and Guennadi ]
>
> I have not looked into this closely but it seems to me that
> it would be more robust to resolve this problem using Kconfig.
I still think this
https://patchwork.kernel.org/patch/2640051/
is a proper fix. We cannot and do not want to force building shdma on all
platforms, where SDHI or any other potential shdma client is built. It is
perfectly valid to build SDHI with no DMA support, which is exactly what
that patch makes possible.
Thanks
Guennadi
>
> On Wed, Jun 26, 2013 at 12:02:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
> >
> > Building marzen_defconfig for next-20130626 results in the following
> > build error:
> >
> > drivers/built-in.o: In function `sh_mobile_sdhi_probe':
> > /home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'
> >
> > Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This
> > will result in CONFIG_SH_DMAE_BASE being enabled by default and the
> > needed code being build.
> >
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > arch/arm/configs/marzen_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: b/arch/arm/configs/marzen_defconfig
> > ===================================================================
> > --- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200
> > +++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200
> > @@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
> > CONFIG_NEW_LEDS=y
> > CONFIG_LEDS_CLASS=y
> > CONFIG_LEDS_GPIO=y
> > +CONFIG_DMADEVICES=y
> > CONFIG_UIO=y
> > CONFIG_UIO_PDRV_GENIRQ=y
> > # CONFIG_IOMMU_SUPPORT is not set
> >
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
2013-06-26 15:01 ` Guennadi Liakhovetski
@ 2013-06-27 5:00 ` Simon Horman
2013-06-27 9:05 ` Guennadi Liakhovetski
0 siblings, 1 reply; 5+ messages in thread
From: Simon Horman @ 2013-06-27 5:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 26, 2013 at 05:01:36PM +0200, Guennadi Liakhovetski wrote:
> Hi
>
> On Wed, 26 Jun 2013, Simon Horman wrote:
>
> > [ Cc linux-sh and Guennadi ]
> >
> > I have not looked into this closely but it seems to me that
> > it would be more robust to resolve this problem using Kconfig.
>
> I still think this
>
> https://patchwork.kernel.org/patch/2640051/
>
> is a proper fix. We cannot and do not want to force building shdma on all
> platforms, where SDHI or any other potential shdma client is built. It is
> perfectly valid to build SDHI with no DMA support, which is exactly what
> that patch makes possible.
That is fine by me. Is there anything I can do to help move it forward?
> Thanks
> Guennadi
>
> >
> > On Wed, Jun 26, 2013 at 12:02:55PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
> > >
> > > Building marzen_defconfig for next-20130626 results in the following
> > > build error:
> > >
> > > drivers/built-in.o: In function `sh_mobile_sdhi_probe':
> > > /home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter'
> > >
> > > Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This
> > > will result in CONFIG_SH_DMAE_BASE being enabled by default and the
> > > needed code being build.
> > >
> > > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Cc: Simon Horman <horms@verge.net.au>
> > > Cc: Magnus Damm <magnus.damm@gmail.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > ---
> > > arch/arm/configs/marzen_defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > Index: b/arch/arm/configs/marzen_defconfig
> > > ===================================================================
> > > --- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200
> > > +++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200
> > > @@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y
> > > CONFIG_NEW_LEDS=y
> > > CONFIG_LEDS_CLASS=y
> > > CONFIG_LEDS_GPIO=y
> > > +CONFIG_DMADEVICES=y
> > > CONFIG_UIO=y
> > > CONFIG_UIO_PDRV_GENIRQ=y
> > > # CONFIG_IOMMU_SUPPORT is not set
> > >
> >
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support
2013-06-27 5:00 ` Simon Horman
@ 2013-06-27 9:05 ` Guennadi Liakhovetski
0 siblings, 0 replies; 5+ messages in thread
From: Guennadi Liakhovetski @ 2013-06-27 9:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 27 Jun 2013, Simon Horman wrote:
> On Wed, Jun 26, 2013 at 05:01:36PM +0200, Guennadi Liakhovetski wrote:
> > Hi
> >
> > On Wed, 26 Jun 2013, Simon Horman wrote:
> >
> > > [ Cc linux-sh and Guennadi ]
> > >
> > > I have not looked into this closely but it seems to me that
> > > it would be more robust to resolve this problem using Kconfig.
> >
> > I still think this
> >
> > https://patchwork.kernel.org/patch/2640051/
> >
> > is a proper fix. We cannot and do not want to force building shdma on all
> > platforms, where SDHI or any other potential shdma client is built. It is
> > perfectly valid to build SDHI with no DMA support, which is exactly what
> > that patch makes possible.
>
> That is fine by me. Is there anything I can do to help move it forward?
Well, you could reply to that thread with your ack or something...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-27 9:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 10:02 [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support Bartlomiej Zolnierkiewicz
2013-06-26 14:52 ` Simon Horman
2013-06-26 15:01 ` Guennadi Liakhovetski
2013-06-27 5:00 ` Simon Horman
2013-06-27 9:05 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox