Re: [RFC PATCH 0/4] Drop custom logging

From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
	Umang Jain <umang.jain@ideasonboard.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Adrien Thierry <athierry@redhat.com>,
	Dan Carpenter <error27@gmail.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-kernel@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-media@vger.kernel.org,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [RFC PATCH 0/4] Drop custom logging
Date: Sun, 22 Jan 2023 16:26:50 +0000	[thread overview]
Message-ID: <167440481093.3533645.5465896340839457121@Monstersaurus> (raw)
In-Reply-To: <d5363f85-44e1-eee1-f7a5-61102637ef53@i2se.com>

Hi Stefan,

Quoting Stefan Wahren (2023-01-22 14:21:05)
> Hi Umang,
> 
> Am 18.01.23 um 12:58 schrieb Umang Jain:
> > Drop custom logging from the vchiq interface.
> > Mostly of them are replaced with dev_dbg and friends
> > and/or pr_info and friends.
> >
> > The debugfs log levels (in 4/4) are mapped to kernel
> > logs levels (coming from include/linux/kern_levels.h)
> > Would like some thoughts on it as I am not sure (hence
> > marking this is RFC)
> >
> >  From drivers/staging/vc04_services/interface/TODO:
> >
> > """
> > * Cleanup logging mechanism
> >
> > The driver should probably be using the standard kernel logging mechanisms
> > such as dev_info, dev_dbg, and friends.
> > """
> 
> at first i want to thank you for the work on vchiq so far.
> 
> There is something which is not directly related to this series, but it 
> is also about debugging. The driver has a buffer which is accessed by 
> it's own DEBUG_* macros. The content of this debug buffer can be dumped 
> via the /dev/vchiq which is also used by ioctl. I would appreciate to 
> move this dump feature into a new debugfs entry.

Do you have a full list of the tasks you'd like to see completed ?
(including/or above drivers/staging/vc04_services/interface/TODO)

It would help to have a clear picture of tasks needed to get this driver
destaged, so that we can support the ISP upstream.

Regards
--
Kieran

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel