From: Oliver Upton <oliver.upton@linux.dev>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Christoffer Dall <christoffer.dall@arm.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
kernel-janitors@vger.kernel.org, kvmarm@lists.linux.dev,
Catalin Marinas <catalin.marinas@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init()
Date: Tue, 13 Jun 2023 12:16:01 +0000 [thread overview]
Message-ID: <168665854177.2681974.14382421414038699730.b4-ty@linux.dev> (raw)
In-Reply-To: <72fffc35-7669-40b1-9d14-113c43269cf3@kili.mountain>
On Tue, 13 Jun 2023 09:43:39 +0300, Dan Carpenter wrote:
> Smatch detected this bug:
> arch/arm64/kvm/arch_timer.c:1425 kvm_timer_hyp_init()
> warn: missing unwind goto?
>
> There are two resources to be freed the vtimer and ptimer. The
> line that Smatch complains about should free the vtimer first
> before returning and then after that cleanup code should free
> the ptimer.
>
> [...]
Applied to kvmarm/next, thanks!
[1/1] KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init()
https://git.kernel.org/kvmarm/kvmarm/c/21e87daece5a
--
Best,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-06-13 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 6:43 [PATCH v2] KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init() Dan Carpenter
2023-06-13 12:16 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168665854177.2681974.14382421414038699730.b4-ty@linux.dev \
--to=oliver.upton@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=dan.carpenter@linaro.org \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox