From: "Rob Herring (Arm)" <robh@kernel.org>
To: Spencer Hill <shill@d3engineering.com>
Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>,
imx@lists.linux.dev, Sakari Ailus <sakari.ailus@linux.intel.com>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2 1/2] media: dt-bindings: Add Sony IMX728
Date: Mon, 01 Jul 2024 13:28:27 -0600 [thread overview]
Message-ID: <171986210711.640699.6919165749438870008.robh@kernel.org> (raw)
In-Reply-To: <20240628-imx728-driver-v2-1-80efa6774286@d3engineering.com>
On Fri, 28 Jun 2024 17:17:00 -0400, Spencer Hill wrote:
> Add bindings for Sony IMX728.
>
> Signed-off-by: Spencer Hill <shill@d3engineering.com>
> ---
> .../devicetree/bindings/media/i2c/sony,imx728.yaml | 119 +++++++++++++++++++++
> MAINTAINERS | 7 ++
> 2 files changed, 126 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml:62:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
./Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml:65:17: [warning] wrong indentation: expected 18 but found 16 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/sony,imx728.example.dtb: camera@1a: port:endpoint: Unevaluated properties are not allowed ('data-lanes', 'link-frequencies' were unexpected)
from schema $id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240628-imx728-driver-v2-1-80efa6774286@d3engineering.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-07-01 19:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:16 [PATCH v2 0/2] media: i2c: Add driver for Sony IMX728 Spencer Hill
2024-06-28 21:17 ` [PATCH v2 1/2] media: dt-bindings: Add " Spencer Hill
2024-07-01 9:36 ` Krzysztof Kozlowski
2024-07-02 6:56 ` Krzysztof Kozlowski
2024-07-01 19:28 ` Rob Herring (Arm) [this message]
[not found] ` <20240628-imx728-driver-v2-2-80efa6774286@d3engineering.com>
2024-06-30 6:15 ` [PATCH v2 2/2] media: i2c: Add driver for " Markus Elfring
2024-07-01 9:25 ` Alexander Stein
2024-07-01 14:00 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171986210711.640699.6919165749438870008.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=shill@d3engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox