From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Spencer Hill <shill@d3engineering.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] media: dt-bindings: Add Sony IMX728
Date: Tue, 2 Jul 2024 08:56:02 +0200 [thread overview]
Message-ID: <c2eb413d-5b6f-4a50-8168-7e7252ffadaa@linaro.org> (raw)
In-Reply-To: <a6530511-8195-48da-9796-df207a15ae2d@linaro.org>
On 01/07/2024 11:36, Krzysztof Kozlowski wrote:
> On 28/06/2024 23:17, Spencer Hill wrote:
>> Add bindings for Sony IMX728.
>>
>> Signed-off-by: Spencer Hill <shill@d3engineering.com>
>
>
>> +
>> + clocks:
>> + description: Clock frequency from 18 to 30MHz
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: inck
>
> clock-names do not seem that useful - name is pretty obvious. Drop.
... and the binding was not tested. You must test them before asking
maintainers to review. Otherwise we will just ignore the patches. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-02 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 21:16 [PATCH v2 0/2] media: i2c: Add driver for Sony IMX728 Spencer Hill
2024-06-28 21:17 ` [PATCH v2 1/2] media: dt-bindings: Add " Spencer Hill
2024-07-01 9:36 ` Krzysztof Kozlowski
2024-07-02 6:56 ` Krzysztof Kozlowski [this message]
2024-07-01 19:28 ` Rob Herring (Arm)
[not found] ` <20240628-imx728-driver-v2-2-80efa6774286@d3engineering.com>
2024-06-30 6:15 ` [PATCH v2 2/2] media: i2c: Add driver for " Markus Elfring
2024-07-01 9:25 ` Alexander Stein
2024-07-01 14:00 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2eb413d-5b6f-4a50-8168-7e7252ffadaa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=shill@d3engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox