* [PATCH] media: pisp_be: Use clamp() and define max sizes
@ 2025-07-01 8:55 Jacopo Mondi
2025-07-01 9:09 ` Dan Scally
2025-07-01 9:32 ` Stefan Klug
0 siblings, 2 replies; 3+ messages in thread
From: Jacopo Mondi @ 2025-07-01 8:55 UTC (permalink / raw)
To: Raspberry Pi Kernel Maintenance, Mauro Carvalho Chehab,
Florian Fainelli, Broadcom internal kernel review list,
Laurent Pinchart
Cc: linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Jacopo Mondi
Use the clamp() from minmax.h and provide a define for the max size as
they will be used in sequent patches.
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 11 +++++++----
include/uapi/linux/media/raspberrypi/pisp_be_config.h | 9 +++++----
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
index 7596ae1f7de6671484d4d351015b234829f642d4..ac5840b4be478ccdd7da9d6d0745649e0c1b2b6f 100644
--- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
+++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
@@ -9,6 +9,7 @@
#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/lockdep.h>
+#include <linux/minmax.h>
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
@@ -1114,10 +1115,12 @@ static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node)
f->fmt.pix_mp.pixelformat = fmt->fourcc;
f->fmt.pix_mp.num_planes = fmt->num_planes;
f->fmt.pix_mp.field = V4L2_FIELD_NONE;
- f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u),
- PISP_BACK_END_MIN_TILE_WIDTH);
- f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u),
- PISP_BACK_END_MIN_TILE_HEIGHT);
+ f->fmt.pix_mp.width = clamp(f->fmt.pix_mp.width,
+ PISP_BACK_END_MIN_TILE_WIDTH,
+ PISP_BACK_END_MAX_TILE_WIDTH);
+ f->fmt.pix_mp.height = clamp(f->fmt.pix_mp.height,
+ PISP_BACK_END_MIN_TILE_HEIGHT,
+ PISP_BACK_END_MAX_TILE_HEIGHT);
/*
* Fill in the actual colour space when the requested one was
diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
index cbeb714f4d61ad53162c0450f2303431a5958040..2ad3b90684d7be80776af75b5c5009f7b677f466 100644
--- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h
+++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
@@ -21,10 +21,11 @@
/* preferred byte alignment for outputs */
#define PISP_BACK_END_OUTPUT_MAX_ALIGN 64u
-/* minimum allowed tile width anywhere in the pipeline */
-#define PISP_BACK_END_MIN_TILE_WIDTH 16u
-/* minimum allowed tile width anywhere in the pipeline */
-#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
+/* minimum allowed tile sizes anywhere in the pipeline */
+#define PISP_BACK_END_MIN_TILE_WIDTH 16u
+#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
+#define PISP_BACK_END_MAX_TILE_WIDTH 65536u
+#define PISP_BACK_END_MAX_TILE_HEIGHT 65536u
#define PISP_BACK_END_NUM_OUTPUTS 2
#define PISP_BACK_END_HOG_OUTPUT 1
---
base-commit: 35392e855abf7d02ad3b061cbc75c7c7c37f0577
change-id: 20250623-pispbe-clamp-4b33011d0e85
Best regards,
--
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: pisp_be: Use clamp() and define max sizes
2025-07-01 8:55 [PATCH] media: pisp_be: Use clamp() and define max sizes Jacopo Mondi
@ 2025-07-01 9:09 ` Dan Scally
2025-07-01 9:32 ` Stefan Klug
1 sibling, 0 replies; 3+ messages in thread
From: Dan Scally @ 2025-07-01 9:09 UTC (permalink / raw)
To: Jacopo Mondi, Raspberry Pi Kernel Maintenance,
Mauro Carvalho Chehab, Florian Fainelli,
Broadcom internal kernel review list, Laurent Pinchart
Cc: linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hi Jacopo, thanks for the patch
On 01/07/2025 09:55, Jacopo Mondi wrote:
> Use the clamp() from minmax.h and provide a define for the max size as
> they will be used in sequent patches.
s/sequent/subsequent
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 11 +++++++----
> include/uapi/linux/media/raspberrypi/pisp_be_config.h | 9 +++++----
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
>
> ---
> base-commit: 35392e855abf7d02ad3b061cbc75c7c7c37f0577
> change-id: 20250623-pispbe-clamp-4b33011d0e85
>
> Best regards,
>
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> index 7596ae1f7de6671484d4d351015b234829f642d4..ac5840b4be478ccdd7da9d6d0745649e0c1b2b6f 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> @@ -9,6 +9,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/lockdep.h>
> +#include <linux/minmax.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -1114,10 +1115,12 @@ static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node)
> f->fmt.pix_mp.pixelformat = fmt->fourcc;
> f->fmt.pix_mp.num_planes = fmt->num_planes;
> f->fmt.pix_mp.field = V4L2_FIELD_NONE;
> - f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u),
> - PISP_BACK_END_MIN_TILE_WIDTH);
> - f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u),
> - PISP_BACK_END_MIN_TILE_HEIGHT);
> + f->fmt.pix_mp.width = clamp(f->fmt.pix_mp.width,
> + PISP_BACK_END_MIN_TILE_WIDTH,
> + PISP_BACK_END_MAX_TILE_WIDTH);
> + f->fmt.pix_mp.height = clamp(f->fmt.pix_mp.height,
> + PISP_BACK_END_MIN_TILE_HEIGHT,
> + PISP_BACK_END_MAX_TILE_HEIGHT);
>
> /*
> * Fill in the actual colour space when the requested one was
> diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> index cbeb714f4d61ad53162c0450f2303431a5958040..2ad3b90684d7be80776af75b5c5009f7b677f466 100644
> --- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> +++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> @@ -21,10 +21,11 @@
> /* preferred byte alignment for outputs */
> #define PISP_BACK_END_OUTPUT_MAX_ALIGN 64u
>
> -/* minimum allowed tile width anywhere in the pipeline */
> -#define PISP_BACK_END_MIN_TILE_WIDTH 16u
> -/* minimum allowed tile width anywhere in the pipeline */
> -#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
> +/* minimum allowed tile sizes anywhere in the pipeline */
> +#define PISP_BACK_END_MIN_TILE_WIDTH 16u
> +#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
> +#define PISP_BACK_END_MAX_TILE_WIDTH 65536u
> +#define PISP_BACK_END_MAX_TILE_HEIGHT 65536u
>
> #define PISP_BACK_END_NUM_OUTPUTS 2
> #define PISP_BACK_END_HOG_OUTPUT 1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: pisp_be: Use clamp() and define max sizes
2025-07-01 8:55 [PATCH] media: pisp_be: Use clamp() and define max sizes Jacopo Mondi
2025-07-01 9:09 ` Dan Scally
@ 2025-07-01 9:32 ` Stefan Klug
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Klug @ 2025-07-01 9:32 UTC (permalink / raw)
To: Broadcom internal kernel review list, Florian Fainelli,
Jacopo Mondi, Laurent Pinchart, Mauro Carvalho Chehab,
Raspberry Pi Kernel Maintenance
Cc: linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Jacopo Mondi
Hi Jacopo,
Thank you for the patch.
Quoting Jacopo Mondi (2025-07-01 10:55:05)
> Use the clamp() from minmax.h and provide a define for the max size as
> they will be used in sequent patches.
nit-picking: I believe either "Use clamp() from" or "Use the clamp() function
from"
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>
> ---
> drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 11 +++++++----
> include/uapi/linux/media/raspberrypi/pisp_be_config.h | 9 +++++----
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> index 7596ae1f7de6671484d4d351015b234829f642d4..ac5840b4be478ccdd7da9d6d0745649e0c1b2b6f 100644
> --- a/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> +++ b/drivers/media/platform/raspberrypi/pisp_be/pisp_be.c
> @@ -9,6 +9,7 @@
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/lockdep.h>
> +#include <linux/minmax.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> @@ -1114,10 +1115,12 @@ static void pispbe_try_format(struct v4l2_format *f, struct pispbe_node *node)
> f->fmt.pix_mp.pixelformat = fmt->fourcc;
> f->fmt.pix_mp.num_planes = fmt->num_planes;
> f->fmt.pix_mp.field = V4L2_FIELD_NONE;
> - f->fmt.pix_mp.width = max(min(f->fmt.pix_mp.width, 65536u),
> - PISP_BACK_END_MIN_TILE_WIDTH);
> - f->fmt.pix_mp.height = max(min(f->fmt.pix_mp.height, 65536u),
> - PISP_BACK_END_MIN_TILE_HEIGHT);
> + f->fmt.pix_mp.width = clamp(f->fmt.pix_mp.width,
> + PISP_BACK_END_MIN_TILE_WIDTH,
> + PISP_BACK_END_MAX_TILE_WIDTH);
> + f->fmt.pix_mp.height = clamp(f->fmt.pix_mp.height,
> + PISP_BACK_END_MIN_TILE_HEIGHT,
> + PISP_BACK_END_MAX_TILE_HEIGHT);
>
> /*
> * Fill in the actual colour space when the requested one was
> diff --git a/include/uapi/linux/media/raspberrypi/pisp_be_config.h b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> index cbeb714f4d61ad53162c0450f2303431a5958040..2ad3b90684d7be80776af75b5c5009f7b677f466 100644
> --- a/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> +++ b/include/uapi/linux/media/raspberrypi/pisp_be_config.h
> @@ -21,10 +21,11 @@
> /* preferred byte alignment for outputs */
> #define PISP_BACK_END_OUTPUT_MAX_ALIGN 64u
>
> -/* minimum allowed tile width anywhere in the pipeline */
> -#define PISP_BACK_END_MIN_TILE_WIDTH 16u
> -/* minimum allowed tile width anywhere in the pipeline */
> -#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
> +/* minimum allowed tile sizes anywhere in the pipeline */
> +#define PISP_BACK_END_MIN_TILE_WIDTH 16u
> +#define PISP_BACK_END_MIN_TILE_HEIGHT 16u
> +#define PISP_BACK_END_MAX_TILE_WIDTH 65536u
> +#define PISP_BACK_END_MAX_TILE_HEIGHT 65536u
>
> #define PISP_BACK_END_NUM_OUTPUTS 2
> #define PISP_BACK_END_HOG_OUTPUT 1
>
> ---
> base-commit: 35392e855abf7d02ad3b061cbc75c7c7c37f0577
> change-id: 20250623-pispbe-clamp-4b33011d0e85
>
> Best regards,
> --
> Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-01 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-01 8:55 [PATCH] media: pisp_be: Use clamp() and define max sizes Jacopo Mondi
2025-07-01 9:09 ` Dan Scally
2025-07-01 9:32 ` Stefan Klug
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox