* [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
@ 2025-08-01 20:07 Rob Herring (Arm)
2025-08-01 21:33 ` Bjorn Helgaas
2025-08-11 10:46 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-08-01 20:07 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Bjorn Helgaas, Krzysztof Kozlowski,
Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Thomas Petazzoni,
Pali Rohár, Kunihiko Hayashi, Masami Hiramatsu,
Kishon Vijay Abraham I
Cc: Ray Jui, Scott Branden, linux-pci, devicetree, linux-arm-kernel,
linux-kernel
An interrupt-controller node which is the parent provider for
"interrupt-map" needs an "#address-cells" property. This fixes
"interrupt_map" warnings in new dtc.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
PCI maintainers, Please ack, I'll take this with the dtc update for
6.18.
Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 1 +
.../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml | 4 ++++
.../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml | 3 +++
.../devicetree/bindings/pci/socionext,uniphier-pcie.yaml | 4 ++++
Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 3 +++
5 files changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
index 5434c144d2ec..18e7981241b5 100644
--- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
@@ -108,6 +108,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
gic: interrupt-controller {
+ #address-cells = <0>;
interrupt-controller;
#interrupt-cells = <3>;
};
diff --git a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
index 68090b3ca419..8403c79634ed 100644
--- a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
@@ -42,6 +42,9 @@ properties:
additionalProperties: false
properties:
+ '#address-cells':
+ const: 0
+
interrupt-controller: true
'#interrupt-cells':
@@ -92,6 +95,7 @@ examples:
reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
pcie_intc: interrupt-controller {
+ #address-cells = <0>;
interrupt-controller;
#interrupt-cells = <1>;
};
diff --git a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
index 7be695320ddf..3d68bfbe6feb 100644
--- a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
@@ -101,6 +101,9 @@ patternProperties:
additionalProperties: false
properties:
+ '#address-cells':
+ const: 0
+
interrupt-controller: true
'#interrupt-cells':
diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
index 638b99db0433..c07b0ed51613 100644
--- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
@@ -56,6 +56,9 @@ properties:
additionalProperties: false
properties:
+ '#address-cells':
+ const: 0
+
interrupt-controller: true
'#interrupt-cells':
@@ -109,6 +112,7 @@ examples:
<0 0 0 4 &pcie_intc 3>;
pcie_intc: interrupt-controller {
+ #address-cells = <0>;
interrupt-controller;
#interrupt-cells = <1>;
interrupt-parent = <&gic>;
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 69b499c96c71..c704099f134b 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -99,6 +99,9 @@ properties:
additionalProperties: false
properties:
+ '#address-cells':
+ const: 0
+
interrupt-controller: true
'#interrupt-cells':
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
2025-08-01 20:07 [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers Rob Herring (Arm)
@ 2025-08-01 21:33 ` Bjorn Helgaas
2025-08-11 10:46 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2025-08-01 21:33 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Bjorn Helgaas, Krzysztof Kozlowski,
Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Thomas Petazzoni,
Pali Rohár, Kunihiko Hayashi, Masami Hiramatsu,
Kishon Vijay Abraham I, Ray Jui, Scott Branden, linux-pci,
devicetree, linux-arm-kernel, linux-kernel
On Fri, Aug 01, 2025 at 03:07:27PM -0500, Rob Herring (Arm) wrote:
> An interrupt-controller node which is the parent provider for
> "interrupt-map" needs an "#address-cells" property. This fixes
> "interrupt_map" warnings in new dtc.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> PCI maintainers, Please ack, I'll take this with the dtc update for
> 6.18.
>
> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 1 +
> .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml | 4 ++++
> .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml | 3 +++
> .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml | 4 ++++
> Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml | 3 +++
> 5 files changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> index 5434c144d2ec..18e7981241b5 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> @@ -108,6 +108,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> gic: interrupt-controller {
> + #address-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <3>;
> };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> index 68090b3ca419..8403c79634ed 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> @@ -42,6 +42,9 @@ properties:
> additionalProperties: false
>
> properties:
> + '#address-cells':
> + const: 0
> +
> interrupt-controller: true
>
> '#interrupt-cells':
> @@ -92,6 +95,7 @@ examples:
> reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
>
> pcie_intc: interrupt-controller {
> + #address-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <1>;
> };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> index 7be695320ddf..3d68bfbe6feb 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> @@ -101,6 +101,9 @@ patternProperties:
> additionalProperties: false
>
> properties:
> + '#address-cells':
> + const: 0
> +
> interrupt-controller: true
>
> '#interrupt-cells':
> diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> index 638b99db0433..c07b0ed51613 100644
> --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> @@ -56,6 +56,9 @@ properties:
> additionalProperties: false
>
> properties:
> + '#address-cells':
> + const: 0
> +
> interrupt-controller: true
>
> '#interrupt-cells':
> @@ -109,6 +112,7 @@ examples:
> <0 0 0 4 &pcie_intc 3>;
>
> pcie_intc: interrupt-controller {
> + #address-cells = <0>;
> interrupt-controller;
> #interrupt-cells = <1>;
> interrupt-parent = <&gic>;
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 69b499c96c71..c704099f134b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -99,6 +99,9 @@ properties:
> additionalProperties: false
>
> properties:
> + '#address-cells':
> + const: 0
> +
> interrupt-controller: true
>
> '#interrupt-cells':
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
2025-08-01 20:07 [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers Rob Herring (Arm)
2025-08-01 21:33 ` Bjorn Helgaas
@ 2025-08-11 10:46 ` Manivannan Sadhasivam
2025-08-11 13:07 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Manivannan Sadhasivam @ 2025-08-11 10:46 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński, Bjorn Helgaas,
Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Thomas Petazzoni,
Pali Rohár, Kunihiko Hayashi, Masami Hiramatsu,
Kishon Vijay Abraham I, Rob Herring (Arm)
Cc: Ray Jui, Scott Branden, linux-pci, devicetree, linux-arm-kernel,
linux-kernel
On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> An interrupt-controller node which is the parent provider for
> "interrupt-map" needs an "#address-cells" property. This fixes
> "interrupt_map" warnings in new dtc.
>
>
Applied, thanks!
[1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
2025-08-11 10:46 ` Manivannan Sadhasivam
@ 2025-08-11 13:07 ` Rob Herring
2025-08-11 14:16 ` Manivannan Sadhasivam
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2025-08-11 13:07 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Lorenzo Pieralisi, Krzysztof Wilczyński, Bjorn Helgaas,
Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Thomas Petazzoni,
Pali Rohár, Kunihiko Hayashi, Masami Hiramatsu,
Kishon Vijay Abraham I, Ray Jui, Scott Branden, linux-pci,
devicetree, linux-arm-kernel, linux-kernel
On Mon, Aug 11, 2025 at 5:46 AM Manivannan Sadhasivam
<manivannan.sadhasivam@oss.qualcomm.com> wrote:
>
>
> On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> > An interrupt-controller node which is the parent provider for
> > "interrupt-map" needs an "#address-cells" property. This fixes
> > "interrupt_map" warnings in new dtc.
> >
> >
>
> Applied, thanks!
>
> [1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
> commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56
Please read the commit message.
I've already applied this to my tree.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
2025-08-11 13:07 ` Rob Herring
@ 2025-08-11 14:16 ` Manivannan Sadhasivam
0 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2025-08-11 14:16 UTC (permalink / raw)
To: Rob Herring
Cc: Manivannan Sadhasivam, Lorenzo Pieralisi,
Krzysztof Wilczyński, Bjorn Helgaas, Krzysztof Kozlowski,
Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Thomas Petazzoni,
Pali Rohár, Kunihiko Hayashi, Masami Hiramatsu,
Kishon Vijay Abraham I, Ray Jui, Scott Branden, linux-pci,
devicetree, linux-arm-kernel, linux-kernel
On Mon, Aug 11, 2025 at 08:07:31AM GMT, Rob Herring wrote:
> On Mon, Aug 11, 2025 at 5:46 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@oss.qualcomm.com> wrote:
> >
> >
> > On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> > > An interrupt-controller node which is the parent provider for
> > > "interrupt-map" needs an "#address-cells" property. This fixes
> > > "interrupt_map" warnings in new dtc.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
> > commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56
>
> Please read the commit message.
>
> I've already applied this to my tree.
>
Sorry, didn't notice it. Dropped the patch from PCI tree now.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-11 16:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-01 20:07 [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers Rob Herring (Arm)
2025-08-01 21:33 ` Bjorn Helgaas
2025-08-11 10:46 ` Manivannan Sadhasivam
2025-08-11 13:07 ` Rob Herring
2025-08-11 14:16 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox