* [PATCH net] net: ti: icssm-prueth: fix eth_ports_node leak in probe
@ 2026-05-06 19:58 Shitalkumar Gandhi
2026-05-09 1:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Shitalkumar Gandhi @ 2026-05-06 19:58 UTC (permalink / raw)
To: MD Danish Anwar, Parvathi Pudi
Cc: Roger Quadros, Mohan Reddy Putluru, Jakub Kicinski,
David S . Miller, Eric Dumazet, Paolo Abeni, Andrew Lunn,
Simon Horman, Dan Carpenter, netdev, linux-arm-kernel,
linux-kernel, Shitalkumar Gandhi
The error path on of_property_read_u32() failure inside
icssm_prueth_probe() returns without putting eth_ports_node,
which was acquired before the for_each_child_of_node() loop.
Drop it before returning.
Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com>
---
drivers/net/ethernet/ti/icssm/icssm_prueth.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/icssm/icssm_prueth.c b/drivers/net/ethernet/ti/icssm/icssm_prueth.c
index 53bbd9290904..b7e94244355a 100644
--- a/drivers/net/ethernet/ti/icssm/icssm_prueth.c
+++ b/drivers/net/ethernet/ti/icssm/icssm_prueth.c
@@ -1825,6 +1825,7 @@ static int icssm_prueth_probe(struct platform_device *pdev)
dev_err(dev, "%pOF error reading port_id %d\n",
eth_node, ret);
of_node_put(eth_node);
+ of_node_put(eth_ports_node);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: ti: icssm-prueth: fix eth_ports_node leak in probe
2026-05-06 19:58 [PATCH net] net: ti: icssm-prueth: fix eth_ports_node leak in probe Shitalkumar Gandhi
@ 2026-05-09 1:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-05-09 1:30 UTC (permalink / raw)
To: Shitalkumar Gandhi
Cc: danishanwar, parvathi, rogerq, pmohan, kuba, davem, edumazet,
pabeni, andrew, horms, dan.carpenter, netdev, linux-arm-kernel,
linux-kernel, shitalkumar.gandhi
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 7 May 2026 01:28:13 +0530 you wrote:
> The error path on of_property_read_u32() failure inside
> icssm_prueth_probe() returns without putting eth_ports_node,
> which was acquired before the for_each_child_of_node() loop.
>
> Drop it before returning.
>
> Fixes: 511f6c1ae093 ("net: ti: icssm-prueth: Adds ICSSM Ethernet driver")
> Signed-off-by: Shitalkumar Gandhi <shitalkumar.gandhi@cambiumnetworks.com>
>
> [...]
Here is the summary with links:
- [net] net: ti: icssm-prueth: fix eth_ports_node leak in probe
https://git.kernel.org/netdev/net/c/6635fa84403c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-09 2:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 19:58 [PATCH net] net: ti: icssm-prueth: fix eth_ports_node leak in probe Shitalkumar Gandhi
2026-05-09 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox