* [PATCH] arm64: static_call: include asm/insns.h
@ 2026-06-11 13:21 Arnd Bergmann
2026-06-19 16:36 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-06-11 13:21 UTC (permalink / raw)
To: Peter Zijlstra, Josh Poimboeuf, Jason Baron, Alice Ryhl,
Catalin Marinas, Will Deacon, Ard Biesheuvel
Cc: Arnd Bergmann, Steven Rostedt, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
I came a cross a missing declaration in a randconfig build:
arch/arm64/kernel/static_call.c:16:5: error: call to undeclared function 'aarch64_insn_adrp_get_offset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
16 | aarch64_insn_adrp_get_offset(le32_to_cpup(tramp + 4)) +
| ^
Include the header that contains this definition explicitly,
rather than relying on it to come indirectly through another
header.
Fixes: 54ac9ff8f119 ("arm64: Use static call trampolines when kCFI is enabled")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm64/kernel/static_call.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/static_call.c b/arch/arm64/kernel/static_call.c
index 8b3a19e10871..c126edced022 100644
--- a/arch/arm64/kernel/static_call.c
+++ b/arch/arm64/kernel/static_call.c
@@ -2,6 +2,7 @@
#include <linux/static_call.h>
#include <linux/memory.h>
#include <asm/text-patching.h>
+#include <asm/insn.h>
void arch_static_call_transform(void *site, void *tramp, void *func, bool tail)
{
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: static_call: include asm/insns.h
2026-06-11 13:21 [PATCH] arm64: static_call: include asm/insns.h Arnd Bergmann
@ 2026-06-19 16:36 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2026-06-19 16:36 UTC (permalink / raw)
To: Peter Zijlstra, Josh Poimboeuf, Jason Baron, Alice Ryhl,
Catalin Marinas, Ard Biesheuvel, Arnd Bergmann
Cc: kernel-team, Will Deacon, Arnd Bergmann, Steven Rostedt,
linux-arm-kernel, linux-kernel
On Thu, 11 Jun 2026 15:21:44 +0200, Arnd Bergmann wrote:
> I came a cross a missing declaration in a randconfig build:
>
> arch/arm64/kernel/static_call.c:16:5: error: call to undeclared function 'aarch64_insn_adrp_get_offset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 16 | aarch64_insn_adrp_get_offset(le32_to_cpup(tramp + 4)) +
> | ^
>
> Include the header that contains this definition explicitly,
> rather than relying on it to come indirectly through another
> header.
>
> [...]
Applied to arm64 (for-next/core), thanks!
[1/1] arm64: static_call: include asm/insns.h
https://git.kernel.org/arm64/c/998d4d789d2d
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-19 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-11 13:21 [PATCH] arm64: static_call: include asm/insns.h Arnd Bergmann
2026-06-19 16:36 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox