Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	linux-tegra@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
	devicetree@vger.kernel.org,
	"Karthikeyan Mitran" <m.karthikeyan@mobiveil.co.in>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	"Thierry Reding" <treding@nvidia.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Aksh Garg" <a-garg7@ti.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Kevin Xie" <kevin.xie@starfivetech.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Hou Zhiqiang" <Zhiqiang.Hou@nxp.com>
Subject: Re: [PATCH v7 1/4] dt-bindings: pci: Strictly distinguish C0 from C1-C5
Date: Tue, 30 Jun 2026 08:54:10 -0500	[thread overview]
Message-ID: <178282764964.2982344.701815323079264876.robh@kernel.org> (raw)
In-Reply-To: <20260617-tegra264-pcie-v7-1-eae7ae964629@nvidia.com>


On Wed, 17 Jun 2026 18:01:28 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Instead of using the ECAM registers as the first entry, strictly make a
> distinction between C0 and C1-C5. This is needed because otherwise the
> unit address doesn't match the first "reg" entry. We also cannot change
> the ordering of these nodes to follow the ECAM addresses because that
> would put them outside of their "control bus" hierarchy since the ECAM
> address space is a global one outside of any of the control busses.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v7:
> - undo changes suggested by Sashiko, should've trust the dedicated tool
>   rather than the AI
> 
> Changes in v6:
> - add maxItems as suggested by Sashiko
> 
> Changes in v5:
> - rebase on top of v7.1-rc1, make it into a fix
> 
> Changes in v4:
> - ECAM is outside of the controller's region, so it cannot be the first
>   reg entry, otherwise we get warnings because it doesn't match the
>   unit-address, so revert back to oneOf construct
> 
> Changes in v2:
> - move ECAM region first and unify C0 vs. C1-C5
> - move unevaluatedProperties to right before the examples
> - add description to clarify the two types of controllers
> - add examples for C0 and C1-C5
> ---
>  .../bindings/pci/nvidia,tegra264-pcie.yaml         | 75 ++++++++++++++--------
>  1 file changed, 50 insertions(+), 25 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>



  reply	other threads:[~2026-06-30 13:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 16:01 [PATCH v7 0/4] PCI: tegra: Add Tegra264 support Thierry Reding
2026-06-17 16:01 ` [PATCH v7 1/4] dt-bindings: pci: Strictly distinguish C0 from C1-C5 Thierry Reding
2026-06-30 13:54   ` Rob Herring (Arm) [this message]
2026-06-30 20:13   ` Bjorn Helgaas
2026-06-17 16:01 ` [PATCH v7 2/4] PCI: Use standard wait times for PCIe link monitoring Thierry Reding
2026-06-18  5:19   ` Aksh Garg
2026-06-17 16:01 ` [PATCH v7 3/4] PCI: tegra: Add Tegra264 support Thierry Reding
2026-06-18  7:26   ` Manivannan Sadhasivam
2026-06-24 12:35     ` Thierry Reding
2026-06-30  8:03       ` Manivannan Sadhasivam
2026-06-30  8:21         ` Manikanta Maddireddy
2026-06-30  6:24   ` Manikanta Maddireddy
2026-06-17 16:01 ` [PATCH v7 4/4] arm64: tegra: Reorder reg and reg-names to match bindings Thierry Reding
2026-06-18  7:27   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178282764964.2982344.701815323079264876.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=a-garg7@ti.com \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=kevin.xie@starfivetech.com \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=m.karthikeyan@mobiveil.co.in \
    --cc=mani@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=pali@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thierry.reding@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox