* [PATCH] ARM: psci: fix building without HOTPLUG_CPU
@ 2013-06-03 22:09 Arnd Bergmann
2013-06-04 11:19 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2013-06-03 22:09 UTC (permalink / raw)
To: linux-arm-kernel
The cpu_die field in smp_operations is not valid with CONFIG_HOTPLUG_CPU,
so we must enclose it in #ifdef, but at least that lets us remove
two other lines.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Russell King <linux@arm.linux.org.uk>
---
KernelVersion: devel-stable
diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c
index 23a1142..219f1d7 100644
--- a/arch/arm/kernel/psci_smp.c
+++ b/arch/arm/kernel/psci_smp.c
@@ -68,8 +68,6 @@ void __ref psci_cpu_die(unsigned int cpu)
/* We should never return */
panic("psci: cpu %d failed to shutdown\n", cpu);
}
-#else
-#define psci_cpu_die NULL
#endif
bool __init psci_smp_available(void)
@@ -80,5 +78,7 @@ bool __init psci_smp_available(void)
struct smp_operations __initdata psci_smp_ops = {
.smp_boot_secondary = psci_boot_secondary,
+#ifdef CONFIG_HOTPLUG_CPU
.cpu_die = psci_cpu_die,
+#endif
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: psci: fix building without HOTPLUG_CPU
2013-06-03 22:09 [PATCH] ARM: psci: fix building without HOTPLUG_CPU Arnd Bergmann
@ 2013-06-04 11:19 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2013-06-04 11:19 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> The cpu_die field in smp_operations is not valid with CONFIG_HOTPLUG_CPU,
> so we must enclose it in #ifdef, but at least that lets us remove
> two other lines.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King <linux@arm.linux.org.uk>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> KernelVersion: devel-stable
>
> diff --git a/arch/arm/kernel/psci_smp.c b/arch/arm/kernel/psci_smp.c
> index 23a1142..219f1d7 100644
> --- a/arch/arm/kernel/psci_smp.c
> +++ b/arch/arm/kernel/psci_smp.c
> @@ -68,8 +68,6 @@ void __ref psci_cpu_die(unsigned int cpu)
> /* We should never return */
> panic("psci: cpu %d failed to shutdown\n", cpu);
> }
> -#else
> -#define psci_cpu_die NULL
> #endif
>
> bool __init psci_smp_available(void)
> @@ -80,5 +78,7 @@ bool __init psci_smp_available(void)
>
> struct smp_operations __initdata psci_smp_ops = {
> .smp_boot_secondary = psci_boot_secondary,
> +#ifdef CONFIG_HOTPLUG_CPU
> .cpu_die = psci_cpu_die,
> +#endif
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-04 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 22:09 [PATCH] ARM: psci: fix building without HOTPLUG_CPU Arnd Bergmann
2013-06-04 11:19 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox