* [PATCH] PM / AVS: rockchip-io: make the log more consistent
@ 2016-10-10 12:44 Shawn Lin
2016-10-10 20:15 ` Heiko Stuebner
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Lin @ 2016-10-10 12:44 UTC (permalink / raw)
To: linux-arm-kernel
When testing SD hotplug automatically, I got bunch of
useless log like this:
[ 588.357838] mmc0: card 0007 removed
[ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to 3300000 done
[ 589.500698] vccio_sd: ramp_delay not set
[ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to 3300000 done
[ 589.669705] rockchip-iodomain ff770000.syscon:io-domains: Setting to 3300000 done
[ 589.677593] vccio_sd: ramp_delay not set
[ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to 1800000 done
[ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully tuned phase to 140
[ 590.039725] mmc0: new ultra high speed SDR50 SDHC card at address 0007
[ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
[ 590.052163] mmcblk0: p1
Moreover the code is intent to print the 'uV' for debug but
later print it using dev_info. It looks more like to me that
it should be the real intention of the code. Anyway, let's
mark this verbose log as debug message.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/power/avs/rockchip-io-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/rockchip-io-domain.c b/drivers/power/avs/rockchip-io-domain.c
index 01b6d3f..56bce19 100644
--- a/drivers/power/avs/rockchip-io-domain.c
+++ b/drivers/power/avs/rockchip-io-domain.c
@@ -143,7 +143,7 @@ static int rockchip_iodomain_notify(struct notifier_block *nb,
if (ret && event == REGULATOR_EVENT_PRE_VOLTAGE_CHANGE)
return NOTIFY_BAD;
- dev_info(supply->iod->dev, "Setting to %d done\n", uV);
+ dev_dbg(supply->iod->dev, "Setting to %d done\n", uV);
return NOTIFY_OK;
}
--
2.3.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] PM / AVS: rockchip-io: make the log more consistent
2016-10-10 12:44 [PATCH] PM / AVS: rockchip-io: make the log more consistent Shawn Lin
@ 2016-10-10 20:15 ` Heiko Stuebner
2016-10-18 21:14 ` Kevin Hilman
2016-11-14 0:19 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Heiko Stuebner @ 2016-10-10 20:15 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 10. Oktober 2016, 20:44:22 CEST schrieb Shawn Lin:
> When testing SD hotplug automatically, I got bunch of
> useless log like this:
>
> [ 588.357838] mmc0: card 0007 removed
> [ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> 3300000 done [ 589.500698] vccio_sd: ramp_delay not set
> [ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> 3300000 done [ 589.669705] rockchip-iodomain ff770000.syscon:io-domains:
> Setting to 3300000 done [ 589.677593] vccio_sd: ramp_delay not set
> [ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> 1800000 done [ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully
> tuned phase to 140 [ 590.039725] mmc0: new ultra high speed SDR50 SDHC
> card at address 0007 [ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
> [ 590.052163] mmcblk0: p1
>
> Moreover the code is intent to print the 'uV' for debug but
> later print it using dev_info. It looks more like to me that
> it should be the real intention of the code. Anyway, let's
> mark this verbose log as debug message.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
reducing the amount of logs, especially for information not generally needed
looks sane
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
>
> drivers/power/avs/rockchip-io-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/rockchip-io-domain.c
> b/drivers/power/avs/rockchip-io-domain.c index 01b6d3f..56bce19 100644
> --- a/drivers/power/avs/rockchip-io-domain.c
> +++ b/drivers/power/avs/rockchip-io-domain.c
> @@ -143,7 +143,7 @@ static int rockchip_iodomain_notify(struct
> notifier_block *nb, if (ret && event == REGULATOR_EVENT_PRE_VOLTAGE_CHANGE)
> return NOTIFY_BAD;
>
> - dev_info(supply->iod->dev, "Setting to %d done\n", uV);
> + dev_dbg(supply->iod->dev, "Setting to %d done\n", uV);
> return NOTIFY_OK;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PM / AVS: rockchip-io: make the log more consistent
2016-10-10 20:15 ` Heiko Stuebner
@ 2016-10-18 21:14 ` Kevin Hilman
2016-11-14 0:19 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2016-10-18 21:14 UTC (permalink / raw)
To: linux-arm-kernel
Heiko Stuebner <heiko@sntech.de> writes:
> Am Montag, 10. Oktober 2016, 20:44:22 CEST schrieb Shawn Lin:
>> When testing SD hotplug automatically, I got bunch of
>> useless log like this:
>>
>> [ 588.357838] mmc0: card 0007 removed
>> [ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.500698] vccio_sd: ramp_delay not set
>> [ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 3300000 done [ 589.669705] rockchip-iodomain ff770000.syscon:io-domains:
>> Setting to 3300000 done [ 589.677593] vccio_sd: ramp_delay not set
>> [ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to
>> 1800000 done [ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully
>> tuned phase to 140 [ 590.039725] mmc0: new ultra high speed SDR50 SDHC
>> card at address 0007 [ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
>> [ 590.052163] mmcblk0: p1
>>
>> Moreover the code is intent to print the 'uV' for debug but
>> later print it using dev_info. It looks more like to me that
>> it should be the real intention of the code. Anyway, let's
>> mark this verbose log as debug message.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> reducing the amount of logs, especially for information not generally needed
> looks sane
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Rafael, feel free to apply directly as a fix for v4.9-rc, or wait for
v4.10 if you prefer.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] PM / AVS: rockchip-io: make the log more consistent
2016-10-10 20:15 ` Heiko Stuebner
2016-10-18 21:14 ` Kevin Hilman
@ 2016-11-14 0:19 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-11-14 0:19 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, October 10, 2016 10:15:50 PM Heiko Stuebner wrote:
> Am Montag, 10. Oktober 2016, 20:44:22 CEST schrieb Shawn Lin:
> > When testing SD hotplug automatically, I got bunch of
> > useless log like this:
> >
> > [ 588.357838] mmc0: card 0007 removed
> > [ 589.492664] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> > 3300000 done [ 589.500698] vccio_sd: ramp_delay not set
> > [ 589.504817] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> > 3300000 done [ 589.669705] rockchip-iodomain ff770000.syscon:io-domains:
> > Setting to 3300000 done [ 589.677593] vccio_sd: ramp_delay not set
> > [ 589.681581] rockchip-iodomain ff770000.syscon:io-domains: Setting to
> > 1800000 done [ 590.032820] dwmmc_rockchip ff0c0000.dwmmc: Successfully
> > tuned phase to 140 [ 590.039725] mmc0: new ultra high speed SDR50 SDHC
> > card at address 0007 [ 590.046641] mmcblk0: mmc0:0007 SD32G 29.3 GiB
> > [ 590.052163] mmcblk0: p1
> >
> > Moreover the code is intent to print the 'uV' for debug but
> > later print it using dev_info. It looks more like to me that
> > it should be the real intention of the code. Anyway, let's
> > mark this verbose log as debug message.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> reducing the amount of logs, especially for information not generally needed
> looks sane
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> > ---
> >
> > drivers/power/avs/rockchip-io-domain.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/avs/rockchip-io-domain.c
> > b/drivers/power/avs/rockchip-io-domain.c index 01b6d3f..56bce19 100644
> > --- a/drivers/power/avs/rockchip-io-domain.c
> > +++ b/drivers/power/avs/rockchip-io-domain.c
> > @@ -143,7 +143,7 @@ static int rockchip_iodomain_notify(struct
> > notifier_block *nb, if (ret && event == REGULATOR_EVENT_PRE_VOLTAGE_CHANGE)
> > return NOTIFY_BAD;
> >
> > - dev_info(supply->iod->dev, "Setting to %d done\n", uV);
> > + dev_dbg(supply->iod->dev, "Setting to %d done\n", uV);
> > return NOTIFY_OK;
> > }
>
Applied (for v4.10).
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-14 0:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 12:44 [PATCH] PM / AVS: rockchip-io: make the log more consistent Shawn Lin
2016-10-10 20:15 ` Heiko Stuebner
2016-10-18 21:14 ` Kevin Hilman
2016-11-14 0:19 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox