From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] ARM: at91: Add armv7m support
Date: Thu, 20 Oct 2016 15:23:19 +0200 [thread overview]
Message-ID: <19094397.gRAFyF5emk@wuerfel> (raw)
In-Reply-To: <20161020102621.od7kkgpndooy25kz@piout.net>
On Thursday, October 20, 2016 12:26:21 PM CEST Alexandre Belloni wrote:
>
> On 20/10/2016 at 11:52:20 +0200, Arnd Bergmann wrote :
> > On Thursday, October 20, 2016 11:41:32 AM CEST Alexandre Belloni wrote:
> > > +
> > > +static void __init samx7_dt_device_init(void)
> > > +{
> > > + struct soc_device *soc;
> > > + struct device *soc_dev = NULL;
> > > +
> > > + soc = at91_soc_init(samx7_socs);
> > > + if (soc)
> > > + soc_dev = soc_device_to_device(soc);
> > > +
> > > + of_platform_populate(NULL, of_default_bus_match_table, NULL, soc_dev);
> > > +}
> >
> > This was initially the idea for the soc_device, but we've stopped
> > using it as the parent for the on-chip devices a while ago.
> >
> > Just register the device for identification here, and use
> > of_platform_default_populate with a NULL parent as most others do.
> >
> > We should also investigate whether we can convert the three other
> > at91 variants to do the same without breaking expectations in user space.
> >
>
> My opinion is that we could just remove the whole at91_soc_init stuff
> but I think Nicolas still wants the two info lines to be printed for
> debugging/support purposes. I'm not sure how much this is used anyway
> and I don't find the sysfs attributes to be particularly useful.
>
> Also, removing soc.c is a 10% reduction of the code in mach-at91
>
Having the soc_device driver is very valuable in order to have
an interface to be used from user space (and soon from the kernel)
to look up the exact SoC type in a generic way, so I'd definitely
want to keep that, though we may want to move that driver to
drivers/soc/.
Arnd
next prev parent reply other threads:[~2016-10-20 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 9:41 [PATCH v2 0/6] ARM: at91: initial samx7 support Alexandre Belloni
2016-10-20 9:41 ` [PATCH v2 1/6] ARM: at91: Documentation: add samx7 families Alexandre Belloni
2016-10-20 12:01 ` Nicolas Ferre
2016-10-20 12:13 ` Alexandre Belloni
2016-10-20 9:41 ` [PATCH v2 2/6] ARM: at91: Document samx7 compatibles Alexandre Belloni
2016-10-20 9:41 ` [PATCH v2 3/6] ARM: at91: Add armv7m support Alexandre Belloni
2016-10-20 9:52 ` Arnd Bergmann
2016-10-20 10:26 ` Alexandre Belloni
2016-10-20 13:23 ` Arnd Bergmann [this message]
2016-10-20 9:41 ` [PATCH v2 4/6] ARM: at91: handle CONFIG_PM for armv7m configurations Alexandre Belloni
2016-10-20 9:41 ` [PATCH v2 5/6] ARM: dts: at91: add samx7 dtsi Alexandre Belloni
2016-10-20 9:41 ` [PATCH v2 6/6] ARM: at91: debug: add samx7 support Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19094397.gRAFyF5emk@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox