Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Add the GPU to Kobol Helios64
@ 2026-10-10 21:53 Igor Velkov via B4 Relay
  2026-10-30 19:29 ` Heiko Stuebner
  0 siblings, 1 reply; 3+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-10 21:53 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

The GPU core of Helios64 is supplied by U12, a Silergy SYR838 on i2c0
at 0x41, with its VSEL pin on GPU_SLEEP_H (GPIO1_B6). Describe it as
silergy,syr828, the way vdd_cpu_b (a SYR837) is described as
silergy,syr827, and enable the GPU.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
Schematic, sheet 7:
https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf

Tested on mainline: panfrost probes, devfreq moves vdd_gpu from 825 mV
at 200 MHz to 1100 mV at 800 MHz, glmark2-es2-wayland under headless
weston scores 548-577 in three runs. Two of them logged one panfrost
job timeout each; the Armbian DT gave none in three runs.
---
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts    | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 63ad79b4c8ac..1f50982291bf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -339,6 +339,11 @@ &gmac {
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &i2c0 {
 	clock-frequency = <400000>;
 	i2c-scl-rising-time-ns = <168>;
@@ -453,6 +458,25 @@ regulator-state-mem {
 			regulator-off-in-suspend;
 		};
 	};
+
+	vdd_gpu: regulator@41 {
+		compatible = "silergy,syr828";
+		reg = <0x41>;
+		fcs,suspend-voltage-selector = <1>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&vsel2_pin>;
+		regulator-name = "vdd_gpu";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <712500>;
+		regulator-max-microvolt = <1500000>;
+		regulator-ramp-delay = <1000>;
+		vin-supply = <&vcc5v0_sys>;
+
+		regulator-state-mem {
+			regulator-off-in-suspend;
+		};
+	};
 };
 
 &i2c2 {
@@ -538,6 +562,10 @@ pmic {
 		pmic_int_l: pmic-int-l {
 			rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
 		};
+
+		vsel2_pin: vsel2-pin {
+			rockchip,pins = <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
 	};
 
 	power {

---
base-commit: d2abcbb905b0e4b2e06b257fa1e5bcf4faa6dbda
change-id: 20261010-b4-helios64-gpu-28f4393ebe57

Best regards,
-- 
Igor Velkov <iav@iav.lv>




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Add the GPU to Kobol Helios64
  2026-10-10 21:53 [PATCH] arm64: dts: rockchip: Add the GPU to Kobol Helios64 Igor Velkov via B4 Relay
@ 2026-10-30 19:29 ` Heiko Stuebner
  2026-10-30 23:00   ` Igor Velkov
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2026-10-30 19:29 UTC (permalink / raw)
  To: iav
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, Igor Velkov

Hi,

Am Samstag, 10. Oktober 2026, 23:53:01 Mitteleuropäische Normalzeit schrieb Igor Velkov via B4 Relay:
> From: Igor Velkov <iav@iav.lv>
> 
> The GPU core of Helios64 is supplied by U12, a Silergy SYR838 on i2c0
> at 0x41, with its VSEL pin on GPU_SLEEP_H (GPIO1_B6). Describe it as
> silergy,syr828, the way vdd_cpu_b (a SYR837) is described as
> silergy,syr827, and enable the GPU.
> 
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>
> ---
> Schematic, sheet 7:
> https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf
> 
> Tested on mainline: panfrost probes, devfreq moves vdd_gpu from 825 mV
> at 200 MHz to 1100 mV at 800 MHz, glmark2-es2-wayland under headless
> weston scores 548-577 in three runs. Two of them logged one panfrost
> job timeout each; the Armbian DT gave none in three runs.
> ---
>  .../boot/dts/rockchip/rk3399-kobol-helios64.dts    | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 63ad79b4c8ac..1f50982291bf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -339,6 +339,11 @@ &gmac {
>  	status = "okay";
>  };
>  
> +&gpu {
> +	mali-supply = <&vdd_gpu>;
> +	status = "okay";
> +};
> +
>  &i2c0 {
>  	clock-frequency = <400000>;
>  	i2c-scl-rising-time-ns = <168>;
> @@ -453,6 +458,25 @@ regulator-state-mem {
>  			regulator-off-in-suspend;
>  		};
>  	};
> +
> +	vdd_gpu: regulator@41 {
> +		compatible = "silergy,syr828";
> +		reg = <0x41>;
> +		fcs,suspend-voltage-selector = <1>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vsel2_pin>;
> +		regulator-name = "vdd_gpu";
> +		regulator-always-on;
> +		regulator-boot-on;

both of these should not be needed, as the GPU should control its
regulator. (always-on and boot-on)

Heiko




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Add the GPU to Kobol Helios64
  2026-10-30 19:29 ` Heiko Stuebner
@ 2026-10-30 23:00   ` Igor Velkov
  0 siblings, 0 replies; 3+ messages in thread
From: Igor Velkov @ 2026-10-30 23:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel, Igor Velkov

On Fri, 30 Oct 2026 20:29:47 +0100, Heiko Stuebner wrote:
> > +		regulator-always-on;
> > +		regulator-boot-on;
>
> both of these should not be needed, as the GPU should control its
> regulator. (always-on and boot-on)

Without them it breaks on this board (v7.3):
- with panfrost not loaded, the regulator core turns vdd_gpu off 30 s
  after boot and the next warm reboot hangs in the DDR init (TPL, DDR
  blob v1.25, at "change freq to 856MHz"), 2 of 2; only removing power
  recovers it. All 119 boots in my console log passed there with the
  rail on.
- panfrost loaded after that: "failed to get ack on domain 'gpu'", the
  GPU stays deferred, since pd_gpu powers up before mali-supply is on.
So I would keep always-on and boot-on, as the other RK3399 boards do.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-30 22:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-10 21:53 [PATCH] arm64: dts: rockchip: Add the GPU to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-30 19:29 ` Heiko Stuebner
2026-10-30 23:00   ` Igor Velkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox