Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "J, KEERTHY" <j-keerthy@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <robh+dt@kernel.org>, <vigneshr@ti.com>, <conor+dt@kernel.org>,
	<kristo@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<u-kumar1@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 6/7] arm64: dts: ti: k3-j721s2-main: Add the main domain watchdog instances
Date: Wed, 27 Sep 2023 08:02:46 +0530	[thread overview]
Message-ID: <1a60d1a1-53ba-5dac-07fe-d32fab0fb1b5@ti.com> (raw)
In-Reply-To: <20230926171340.t227lqfjjcitx37z@clump>



On 9/26/2023 10:43 PM, Nishanth Menon wrote:
> On 18:58-20230926, Keerthy wrote:
>> There are totally 9 instances of watchdog module. One each for the
>> 2 A72 cores, one each for the 2 C7x cores, 1 for the GPU, 1 each
>> for the 4 R5F cores in the main domain. Keeping only the A72 instances
>> enabled and disabling the rest by default.
> 
> Will be good to explain why in the commit message as well.

I will add that.

> 
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 88 ++++++++++++++++++++++
>>   1 file changed, 88 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> index 8a717b592238..5e3c0ef9b10b 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> @@ -1702,4 +1702,92 @@
>>   		ti,esm-pins = <688>, <689>;
>>   		bootph-pre-ram;
>>   	};
>> +
>> +	watchdog0: watchdog@2200000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2200000 0x00 0x100>;
>> +		clocks = <&k3_clks 286 1>;
>> +		power-domains = <&k3_pds 286 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 286 1>;
>> +		assigned-clock-parents = <&k3_clks 286 5>;
>> +	};
>> +
>> +	watchdog1: watchdog@2210000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2210000 0x00 0x100>;
>> +		clocks = <&k3_clks 287 1>;
>> +		power-domains = <&k3_pds 287 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 287 1>;
>> +		assigned-clock-parents = <&k3_clks 287 5>;
>> +	};
>> +
>> +	watchdog16: watchdog@2300000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2300000 0x00 0x100>;
>> +		clocks = <&k3_clks 288 1>;
>> +		power-domains = <&k3_pds 288 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 288 1>;
>> +		assigned-clock-parents = <&k3_clks 288 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog17: watchdog@2310000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x2310000 0x00 0x100>;
>> +		clocks = <&k3_clks 289 1>;
>> +		power-domains = <&k3_pds 289 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 289 1>;
>> +		assigned-clock-parents = <&k3_clks 289 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog15: watchdog@22f0000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x22f0000 0x00 0x100>;
>> +		clocks = <&k3_clks 290 1>;
>> +		power-domains = <&k3_pds 290 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 290 1>;
>> +		assigned-clock-parents = <&k3_clks 290 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog28: watchdog@23c0000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x23c0000 0x00 0x100>;
>> +		clocks = <&k3_clks 291 1>;
>> +		power-domains = <&k3_pds 291 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 291 1>;
>> +		assigned-clock-parents = <&k3_clks 291 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog29: watchdog@23d0000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x23d0000 0x00 0x100>;
>> +		clocks = <&k3_clks 292 1>;
>> +		power-domains = <&k3_pds 292 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 292 1>;
>> +		assigned-clock-parents = <&k3_clks 292 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog30: watchdog@23e0000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x23e0000 0x00 0x100>;
>> +		clocks = <&k3_clks 293 1>;
>> +		power-domains = <&k3_pds 293 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 293 1>;
>> +		assigned-clock-parents = <&k3_clks 293 5>;
>> +		status = "disabled";
>> +	};
>> +
>> +	watchdog31: watchdog@23f0000 {
>> +		compatible = "ti,j7-rti-wdt";
>> +		reg = <0x00 0x23f0000 0x00 0x100>;
>> +		clocks = <&k3_clks 294 1>;
>> +		power-domains = <&k3_pds 294 TI_SCI_PD_EXCLUSIVE>;
>> +		assigned-clocks = <&k3_clks 294 1>;
>> +		assigned-clock-parents = <&k3_clks 294 5>;
>> +		status = "disabled";
> 
> Missing documentation here as well.

Sure. I will add that.

> 
>> +	};
>>   };
>> -- 
>> 2.17.1
>>
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-27  2:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 13:27 [PATCH v5 0/7] arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes Keerthy
2023-09-26 13:27 ` [PATCH v5 1/7] arm64: dts: ti: k3-j721s2: Add ESM instances Keerthy
2023-09-26 13:28 ` [PATCH v5 2/7] arm64: dts: ti: k3-j784s4: " Keerthy
2023-09-26 13:28 ` [PATCH v5 3/7] arm64: dts: ti: k3-j7200: Add MCU domain ESM instance Keerthy
2023-09-26 13:28 ` [PATCH v5 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Keerthy
2023-09-26 17:12   ` Nishanth Menon
2023-09-27  2:33     ` J, KEERTHY
2023-09-27  7:54   ` Krzysztof Kozlowski
2023-09-27  8:23     ` J, KEERTHY
2023-09-26 13:28 ` [PATCH v5 5/7] arm64: dts: ti: k3-j784s4-mcu: Add the mcu " Keerthy
2023-09-26 13:28 ` [PATCH v5 6/7] arm64: dts: ti: k3-j721s2-main: Add the main " Keerthy
2023-09-26 17:13   ` Nishanth Menon
2023-09-27  2:32     ` J, KEERTHY [this message]
2023-09-26 13:28 ` [PATCH v5 7/7] dts: ti: k3-j712s2-mcu: Add the mcu " Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a60d1a1-53ba-5dac-07fe-d32fab0fb1b5@ti.com \
    --to=j-keerthy@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox