Re: [PATCH 4/5] iio: adc: rockchip: Simplify with dev_err_probe

[Shawn Lin <shawn.lin@rock-chips.com>]

在 2025/12/19 星期五 22:31, Krzysztof Kozlowski 写道:
> Use dev_err_probe() to make error code handling simpler and handle
> deferred probe nicely (avoid spamming logs).
> 

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>   drivers/iio/adc/rockchip_saradc.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 6721da0ed7bb..263d80c5fc50 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -492,10 +492,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>   	 */
>   	info->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
>   								"saradc-apb");
> -	if (IS_ERR(info->reset)) {
> -		ret = PTR_ERR(info->reset);
> -		return dev_err_probe(&pdev->dev, ret, "failed to get saradc-apb\n");
> -	}
> +	if (IS_ERR(info->reset))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(info->reset),
> +				     "failed to get saradc-apb\n");
>   
>   	init_completion(&info->completion);
>   
> @@ -505,10 +504,8 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>   
>   	ret = devm_request_irq(&pdev->dev, irq, rockchip_saradc_isr,
>   			       0, dev_name(&pdev->dev), info);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "failed requesting irq %d\n", irq);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		return dev_err_probe(&pdev->dev, ret, "failed requesting irq %d\n", irq);
>   
>   	info->vref = devm_regulator_get(&pdev->dev, "vref");
>   	if (IS_ERR(info->vref))
>