Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board
Date: Fri, 28 May 2010 11:30:59 +0100	[thread overview]
Message-ID: <20100528103059.GC4720@trinity.fluff.org> (raw)
In-Reply-To: <4BFF6594.5050502@samsung.com>

On Fri, May 28, 2010 at 03:41:24PM +0900, Joonyoung Shim wrote:
> This patch is to support OneNAND device to the GONI board.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

i'd say the second signoff here is at best un-necessary as Joonyoung
is the sender of the patch and at worst incorrect.

there's acked-by or other tags for people who've reviewed or tested the
patch.

> ---
>  arch/arm/mach-s5pv210/Kconfig     |    1 +
>  arch/arm/mach-s5pv210/mach-goni.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 0761eac..d0432c6 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -58,6 +58,7 @@ config MACH_GONI
>  	bool "GONI"
>  	select CPU_S5PV210
>  	select ARCH_SPARSEMEM_ENABLE
> +	select S5PC110_DEV_ONENAND
>  	help
>  	  Machine support for Samsung GONI board
>  	  S5PC110(MCP) is one of package option of S5PV210
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
> index 4863b13..bea812f 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
>  };
>  
>  static struct platform_device *goni_devices[] __initdata = {
> +	&s5pc110_device_onenand,
>  };
>  
>  static void __init goni_map_io(void)
> -- 
> 1.7.0.4

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  reply	other threads:[~2010-05-28 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28  6:41 [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board Joonyoung Shim
2010-05-28 10:30 ` Ben Dooks [this message]
2010-05-28 10:35   ` Kyungmin Park
  -- strict thread matches above, loose matches on Subject: below --
2010-06-25  5:52 [PATCH] Add OneNAND devices to Aquila and GONI boards Marek Szyprowski
2010-06-25  5:52 ` [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100528103059.GC4720@trinity.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox