* [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board
@ 2010-05-28 6:41 Joonyoung Shim
2010-05-28 10:30 ` Ben Dooks
0 siblings, 1 reply; 4+ messages in thread
From: Joonyoung Shim @ 2010-05-28 6:41 UTC (permalink / raw)
To: linux-arm-kernel
This patch is to support OneNAND device to the GONI board.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-s5pv210/Kconfig | 1 +
arch/arm/mach-s5pv210/mach-goni.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 0761eac..d0432c6 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -58,6 +58,7 @@ config MACH_GONI
bool "GONI"
select CPU_S5PV210
select ARCH_SPARSEMEM_ENABLE
+ select S5PC110_DEV_ONENAND
help
Machine support for Samsung GONI board
S5PC110(MCP) is one of package option of S5PV210
diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
index 4863b13..bea812f 100644
--- a/arch/arm/mach-s5pv210/mach-goni.c
+++ b/arch/arm/mach-s5pv210/mach-goni.c
@@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
};
static struct platform_device *goni_devices[] __initdata = {
+ &s5pc110_device_onenand,
};
static void __init goni_map_io(void)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board
2010-05-28 6:41 [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board Joonyoung Shim
@ 2010-05-28 10:30 ` Ben Dooks
2010-05-28 10:35 ` Kyungmin Park
0 siblings, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2010-05-28 10:30 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 28, 2010 at 03:41:24PM +0900, Joonyoung Shim wrote:
> This patch is to support OneNAND device to the GONI board.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
i'd say the second signoff here is at best un-necessary as Joonyoung
is the sender of the patch and at worst incorrect.
there's acked-by or other tags for people who've reviewed or tested the
patch.
> ---
> arch/arm/mach-s5pv210/Kconfig | 1 +
> arch/arm/mach-s5pv210/mach-goni.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
> index 0761eac..d0432c6 100644
> --- a/arch/arm/mach-s5pv210/Kconfig
> +++ b/arch/arm/mach-s5pv210/Kconfig
> @@ -58,6 +58,7 @@ config MACH_GONI
> bool "GONI"
> select CPU_S5PV210
> select ARCH_SPARSEMEM_ENABLE
> + select S5PC110_DEV_ONENAND
> help
> Machine support for Samsung GONI board
> S5PC110(MCP) is one of package option of S5PV210
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
> index 4863b13..bea812f 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
> };
>
> static struct platform_device *goni_devices[] __initdata = {
> + &s5pc110_device_onenand,
> };
>
> static void __init goni_map_io(void)
> --
> 1.7.0.4
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board
2010-05-28 10:30 ` Ben Dooks
@ 2010-05-28 10:35 ` Kyungmin Park
0 siblings, 0 replies; 4+ messages in thread
From: Kyungmin Park @ 2010-05-28 10:35 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 28, 2010 at 7:30 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, May 28, 2010 at 03:41:24PM +0900, Joonyoung Shim wrote:
>> This patch is to support OneNAND device to the GONI board.
>>
>> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> i'd say the second signoff here is at best un-necessary as Joonyoung
> is the sender of the patch and at worst incorrect.
>
> there's acked-by or other tags for people who've reviewed or tested the
> patch.
it's already discussed. now we got the internal tree and go to mainline.
do you mean I send the patch instead of each developers?
Thank you,
Kyungmin Park
>
>> ---
>> ?arch/arm/mach-s5pv210/Kconfig ? ? | ? ?1 +
>> ?arch/arm/mach-s5pv210/mach-goni.c | ? ?1 +
>> ?2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
>> index 0761eac..d0432c6 100644
>> --- a/arch/arm/mach-s5pv210/Kconfig
>> +++ b/arch/arm/mach-s5pv210/Kconfig
>> @@ -58,6 +58,7 @@ config MACH_GONI
>> ? ? ? bool "GONI"
>> ? ? ? select CPU_S5PV210
>> ? ? ? select ARCH_SPARSEMEM_ENABLE
>> + ? ? select S5PC110_DEV_ONENAND
>> ? ? ? help
>> ? ? ? ? Machine support for Samsung GONI board
>> ? ? ? ? S5PC110(MCP) is one of package option of S5PV210
>> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
>> index 4863b13..bea812f 100644
>> --- a/arch/arm/mach-s5pv210/mach-goni.c
>> +++ b/arch/arm/mach-s5pv210/mach-goni.c
>> @@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
>> ?};
>>
>> ?static struct platform_device *goni_devices[] __initdata = {
>> + ? ? &s5pc110_device_onenand,
>> ?};
>>
>> ?static void __init goni_map_io(void)
>> --
>> 1.7.0.4
>
> --
> --
> Ben
>
> Q: ? ? ?What's a light-year?
> A: ? ? ?One-third less calories than a regular year.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board
2010-06-25 5:52 [PATCH] Add OneNAND devices to Aquila and GONI boards Marek Szyprowski
@ 2010-06-25 5:52 ` Marek Szyprowski
0 siblings, 0 replies; 4+ messages in thread
From: Marek Szyprowski @ 2010-06-25 5:52 UTC (permalink / raw)
To: linux-arm-kernel
From: Joonyoung Shim <jy0922.shim@samsung.com>
This patch is to support OneNAND device to the GONI board.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/mach-s5pv210/Kconfig | 1 +
arch/arm/mach-s5pv210/mach-goni.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig
index 0761eac..d0432c6 100644
--- a/arch/arm/mach-s5pv210/Kconfig
+++ b/arch/arm/mach-s5pv210/Kconfig
@@ -58,6 +58,7 @@ config MACH_GONI
bool "GONI"
select CPU_S5PV210
select ARCH_SPARSEMEM_ENABLE
+ select S5PC110_DEV_ONENAND
help
Machine support for Samsung GONI board
S5PC110(MCP) is one of package option of S5PV210
diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
index 4863b13..bea812f 100644
--- a/arch/arm/mach-s5pv210/mach-goni.c
+++ b/arch/arm/mach-s5pv210/mach-goni.c
@@ -72,6 +72,7 @@ static struct s3c2410_uartcfg goni_uartcfgs[] __initdata = {
};
static struct platform_device *goni_devices[] __initdata = {
+ &s5pc110_device_onenand,
};
static void __init goni_map_io(void)
--
1.7.1.569.g6f426
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-25 5:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 6:41 [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board Joonyoung Shim
2010-05-28 10:30 ` Ben Dooks
2010-05-28 10:35 ` Kyungmin Park
-- strict thread matches above, loose matches on Subject: below --
2010-06-25 5:52 [PATCH] Add OneNAND devices to Aquila and GONI boards Marek Szyprowski
2010-06-25 5:52 ` [PATCH 1/2] ARM: S5PV210: Add OneNAND device to the GONI board Marek Szyprowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox