* [PATCH 3/4] spi/pl022: remove dangling status check
@ 2011-02-08 12:03 Linus Walleij
2011-02-15 22:09 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2011-02-08 12:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/spi/amba-pl022.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index 8fdf530..2b591f0 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -1906,8 +1906,6 @@ static int pl022_setup(struct spi_device *spi)
&& ((pl022->master_info)->enable_dma)) {
chip->enable_dma = true;
dev_dbg(&spi->dev, "DMA mode set in controller state\n");
- if (status < 0)
- goto err_config_params;
SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
SSP_DMACR_MASK_RXDMAE, 0);
SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 3/4] spi/pl022: remove dangling status check
2011-02-08 12:03 [PATCH 3/4] spi/pl022: remove dangling status check Linus Walleij
@ 2011-02-15 22:09 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-02-15 22:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Feb 08, 2011 at 01:03:41PM +0100, Linus Walleij wrote:
> From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
> ---
> drivers/spi/amba-pl022.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index 8fdf530..2b591f0 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -1906,8 +1906,6 @@ static int pl022_setup(struct spi_device *spi)
> && ((pl022->master_info)->enable_dma)) {
> chip->enable_dma = true;
> dev_dbg(&spi->dev, "DMA mode set in controller state\n");
> - if (status < 0)
> - goto err_config_params;
> SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
> SSP_DMACR_MASK_RXDMAE, 0);
> SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
> --
> 1.7.3.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/4] spi/pl022: remove dangling status check
@ 2011-02-08 12:02 Linus Walleij
0 siblings, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2011-02-08 12:02 UTC (permalink / raw)
To: linux-arm-kernel
From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/spi/amba-pl022.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index 8fdf530..2b591f0 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -1906,8 +1906,6 @@ static int pl022_setup(struct spi_device *spi)
&& ((pl022->master_info)->enable_dma)) {
chip->enable_dma = true;
dev_dbg(&spi->dev, "DMA mode set in controller state\n");
- if (status < 0)
- goto err_config_params;
SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
SSP_DMACR_MASK_RXDMAE, 0);
SSP_WRITE_BITS(chip->dmacr, SSP_DMA_ENABLED,
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-15 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-08 12:03 [PATCH 3/4] spi/pl022: remove dangling status check Linus Walleij
2011-02-15 22:09 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2011-02-08 12:02 Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox