From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Consolidate the clkdev header files
Date: Mon, 30 May 2011 12:29:21 +0200 [thread overview]
Message-ID: <201105301229.21973.arnd@arndb.de> (raw)
In-Reply-To: <20110530010416.GA24365@july>
On Monday 30 May 2011, Kyungmin Park wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Now most of ARM machines has the alsmot same __clk_get/put() macro
>
> So place it at the arch/arm/include/asm/clkdev.h and remove the reduntant header files
>
> But some machines don't have the same form as above. It can use the machince specific clkdev file by HAVE_MACH_CLKDEV config
>
> Now there are only 3 caese.
>
> 1) define the clk structure with clkdev macro => Need to move clk structure to proper header file
>
> arch/arm/mach-versatile/include/mach/clkdev.h
> arch/arm/mach-realview/include/mach/clkdev.h
> arch/arm/mach-vexpress/include/mach/clkdev.h
> arch/arm/mach-integrator/include/mach/clkdev.h
>
> 2) export the __clk_get/put function at clock.c
>
> arch/arm/mach-shmobile/include/mach/clkdev.h
>
> 3) demuxing the clk source
> arch/arm/mach-u300/include/mach/clkdev.h
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
This looks like a very useful simplification by itself, nice work!
You definitely need to coordinate this with the struct clk consolidation
that Jeremy Kerr has just posted though. It seems that you are touching
some of the same code lines.
Arnd
next prev parent reply other threads:[~2011-05-30 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 1:04 [PATCH] Consolidate the clkdev header files Kyungmin Park
2011-05-30 8:27 ` viresh kumar
2011-05-30 10:29 ` Arnd Bergmann [this message]
2011-05-31 16:40 ` H Hartley Sweeten
2011-06-07 8:46 ` Kyungmin Park
2011-06-07 10:13 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105301229.21973.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox