From: thierry.reding@avionic-design.de (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/tegra: Add device-tree support for TrimSlice board
Date: Tue, 25 Oct 2011 07:52:39 +0200 [thread overview]
Message-ID: <20111025055238.GA30358@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173E1B4171@HQMAIL01.nvidia.com>
* Stephen Warren wrote:
> Marc Dietrich wrote at Monday, October 24, 2011 3:28 PM:
> > On Monday 24 October 2011 12:01:07 Stephen Warren wrote:
> > > * Add device-tree file for TrimSlice
> > > * Add that to the list of .dts files to build
> > > * Update board-dt.c to recognize TrimSlice board name
> > >
> > > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > > ---
> > > arch/arm/boot/dts/tegra-trimslice.dts | 38
> > > +++++++++++++++++++++++++++++++++ arch/arm/mach-tegra/Makefile.boot |
> > > 1 +
> > > arch/arm/mach-tegra/board-dt.c | 3 ++
> > > 3 files changed, 42 insertions(+), 0 deletions(-)
> > > create mode 100644 arch/arm/boot/dts/tegra-trimslice.dts
> >
> > doesn't this also require to add something like
> >
> > obj-${CONFIG_MACH_TEGRA_DT} += board-trimslice-pinmux.o
> >
> > to the Makefile?
>
> Yes, definitely. I've fixed this up locally; I hope to repost soon.
Can it please be obj-$(CONFIG_MACH_TEGRA_DT) instead? I think both Russell
and Olof agreed[0] to use parens instead of braces, even though the current
practice is to copy what previous boards did.
Thierry
[0]: http://article.gmane.org/gmane.linux.ports.tegra/1670
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111025/e6ad7097/attachment-0001.sig>
next prev parent reply other threads:[~2011-10-25 5:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 10:01 [PATCH] arm/tegra: Add device-tree support for TrimSlice board Stephen Warren
2011-10-24 21:27 ` Marc Dietrich
2011-10-25 4:10 ` Stephen Warren
2011-10-25 5:52 ` Thierry Reding [this message]
2011-10-25 7:55 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111025055238.GA30358@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox