* [PATCH 0/3] Few omap randconfig fixes for v3.5-rc1
@ 2012-06-06 8:22 Tony Lindgren
2012-06-06 8:22 ` [PATCH 1/3] ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected Tony Lindgren
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-06-06 8:22 UTC (permalink / raw)
To: linux-arm-kernel
Here are some fixes for review.
Regards,
Tony
---
Tony Lindgren (3):
ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected
ARM: OMAP3: Fix omap3_l3_block_irq warning when CONFIG_BUG is not set
ARM: OMAP2+: Fix compile for CONFIG_TIDSPBRIDGE platform init code
arch/arm/mach-omap2/dsp.c | 3 +++
arch/arm/mach-omap2/omap_l3_smx.c | 3 ++-
arch/arm/plat-omap/include/plat/mmc.h | 4 +---
3 files changed, 6 insertions(+), 4 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected
2012-06-06 8:22 [PATCH 0/3] Few omap randconfig fixes for v3.5-rc1 Tony Lindgren
@ 2012-06-06 8:22 ` Tony Lindgren
2012-06-06 8:22 ` [PATCH 2/3] ARM: OMAP3: Fix omap3_l3_block_irq warning when CONFIG_BUG is not set Tony Lindgren
2012-06-06 8:22 ` [PATCH 3/3] ARM: OMAP2+: Fix compile for CONFIG_TIDSPBRIDGE platform init code Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-06-06 8:22 UTC (permalink / raw)
To: linux-arm-kernel
If CONFIG_MMC_OMAP is not set and CONFIG_MMC_OMAP_HS is set,
we can get error: redefinition of `omap242x_init_mmc' error.
Fix it by removing MMC_OMAP_HS from MMC_OMAP ifdefs as they do
not depend on each other.
While at it, also prettify the formatting a bit.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/plat-omap/include/plat/mmc.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/mmc.h b/arch/arm/plat-omap/include/plat/mmc.h
index a7754a8..5493bd9 100644
--- a/arch/arm/plat-omap/include/plat/mmc.h
+++ b/arch/arm/plat-omap/include/plat/mmc.h
@@ -172,8 +172,7 @@ struct omap_mmc_platform_data {
extern void omap_mmc_notify_cover_event(struct device *dev, int slot,
int is_closed);
-#if defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE) || \
- defined(CONFIG_MMC_OMAP_HS) || defined(CONFIG_MMC_OMAP_HS_MODULE)
+#if defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE)
void omap1_init_mmc(struct omap_mmc_platform_data **mmc_data,
int nr_controllers);
void omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data);
@@ -185,7 +184,6 @@ static inline void omap1_init_mmc(struct omap_mmc_platform_data **mmc_data,
static inline void omap242x_init_mmc(struct omap_mmc_platform_data **mmc_data)
{
}
-
#endif
extern int omap_msdi_reset(struct omap_hwmod *oh);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] ARM: OMAP3: Fix omap3_l3_block_irq warning when CONFIG_BUG is not set
2012-06-06 8:22 [PATCH 0/3] Few omap randconfig fixes for v3.5-rc1 Tony Lindgren
2012-06-06 8:22 ` [PATCH 1/3] ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected Tony Lindgren
@ 2012-06-06 8:22 ` Tony Lindgren
2012-06-06 8:22 ` [PATCH 3/3] ARM: OMAP2+: Fix compile for CONFIG_TIDSPBRIDGE platform init code Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-06-06 8:22 UTC (permalink / raw)
To: linux-arm-kernel
Otherwise we will get:
arch/arm/mach-omap2/omap_l3_smx.c: In function ?omap3_l3_block_irq?:
arch/arm/mach-omap2/omap_l3_smx.c:156: warning: unused variable ?address?
arch/arm/mach-omap2/omap_l3_smx.c:155: warning: unused variable ?multi?
arch/arm/mach-omap2/omap_l3_smx.c:154: warning: unused variable ?initid?
arch/arm/mach-omap2/omap_l3_smx.c:153: warning: unused variable ?code?
arch/arm/mach-omap2/omap_l3_smx.c: At top level:
arch/arm/mach-omap2/omap_l3_smx.c:68: warning: ?omap3_l3_code_string? defined but not used
arch/arm/mach-omap2/omap_l3_smx.c:90: warning: ?omap3_l3_initiator_string? defined but not used
Fix it by always showing the L3 error.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/omap_l3_smx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-omap2/omap_l3_smx.c
index a05a62f..acc2164 100644
--- a/arch/arm/mach-omap2/omap_l3_smx.c
+++ b/arch/arm/mach-omap2/omap_l3_smx.c
@@ -155,10 +155,11 @@ static irqreturn_t omap3_l3_block_irq(struct omap3_l3 *l3,
u8 multi = error & L3_ERROR_LOG_MULTI;
u32 address = omap3_l3_decode_addr(error_addr);
- WARN(true, "%s seen by %s %s at address %x\n",
+ pr_err("%s seen by %s %s at address %x\n",
omap3_l3_code_string(code),
omap3_l3_initiator_string(initid),
multi ? "Multiple Errors" : "", address);
+ WARN_ON(1);
return IRQ_HANDLED;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] ARM: OMAP2+: Fix compile for CONFIG_TIDSPBRIDGE platform init code
2012-06-06 8:22 [PATCH 0/3] Few omap randconfig fixes for v3.5-rc1 Tony Lindgren
2012-06-06 8:22 ` [PATCH 1/3] ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected Tony Lindgren
2012-06-06 8:22 ` [PATCH 2/3] ARM: OMAP3: Fix omap3_l3_block_irq warning when CONFIG_BUG is not set Tony Lindgren
@ 2012-06-06 8:22 ` Tony Lindgren
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-06-06 8:22 UTC (permalink / raw)
To: linux-arm-kernel
Commit 7f28427b (ARM: OMAP2+: Move omap_dsp_reserve_sdram_memblock() to mach-omap2)
moved DSP platform init code, but failed to include memblock.h causing:
arch/arm/mach-omap2/dsp.c: In function 'omap_dsp_reserve_sdram_memblock':
arch/arm/mach-omap2/dsp.c:58: error: implicit declaration of function 'arm_memblock_steal'
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/dsp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-omap2/dsp.c b/arch/arm/mach-omap2/dsp.c
index 845309f..88ffa1e 100644
--- a/arch/arm/mach-omap2/dsp.c
+++ b/arch/arm/mach-omap2/dsp.c
@@ -20,6 +20,9 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+
+#include <asm/memblock.h>
+
#include "cm2xxx_3xxx.h"
#include "prm2xxx_3xxx.h"
#ifdef CONFIG_BRIDGE_DVFS
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-06 8:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-06 8:22 [PATCH 0/3] Few omap randconfig fixes for v3.5-rc1 Tony Lindgren
2012-06-06 8:22 ` [PATCH 1/3] ARM: OMAP: Fix MMC_OMAP build when only MMC_OMAP_HS is selected Tony Lindgren
2012-06-06 8:22 ` [PATCH 2/3] ARM: OMAP3: Fix omap3_l3_block_irq warning when CONFIG_BUG is not set Tony Lindgren
2012-06-06 8:22 ` [PATCH 3/3] ARM: OMAP2+: Fix compile for CONFIG_TIDSPBRIDGE platform init code Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox