From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: dma: Remove unnecessary code
Date: Mon, 4 Feb 2013 17:43:54 +0000 [thread overview]
Message-ID: <201302041743.55029.arnd@arndb.de> (raw)
In-Reply-To: <1359967675-624-1-git-send-email-padma.v@samsung.com>
On Monday 04 February 2013, Padmavathi Venna wrote:
> diff --git a/arch/arm/plat-samsung/dma-ops.c b/arch/arm/plat-samsung/dma-ops.c
> index 71d58dd..ec0d731 100644
> --- a/arch/arm/plat-samsung/dma-ops.c
> +++ b/arch/arm/plat-samsung/dma-ops.c
> @@ -23,23 +23,15 @@ static unsigned samsung_dmadev_request(enum dma_ch dma_ch,
> struct device *dev, char *ch_name)
> {
> dma_cap_mask_t mask;
> - void *filter_param;
>
> dma_cap_zero(mask);
> dma_cap_set(param->cap, mask);
>
> - /*
> - * If a dma channel property of a device node from device tree is
> - * specified, use that as the fliter parameter.
> - */
> - filter_param = (dma_ch == DMACH_DT_PROP) ?
> - (void *)param->dt_dmach_prop : (void *)dma_ch;
> -
> if (dev->of_node)
> return (unsigned)dma_request_slave_channel(dev, ch_name);
> else
> return (unsigned)dma_request_channel(mask, pl330_filter,
> - filter_param);
> + (void *)dma_ch);
> }
This still looks wrong to me, because the pl330_filter function now tkes
a struct dma_pl330_filter_args pointer argument, not dma_ch name.
Arnd
next prev parent reply other threads:[~2013-02-04 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 8:47 [PATCH] ARM: SAMSUNG: dma: Remove unnecessary code Padmavathi Venna
2013-02-04 17:43 ` Arnd Bergmann [this message]
2013-02-05 8:04 ` Padma Venkat
2013-02-05 11:13 ` Arnd Bergmann
2013-02-05 15:54 ` Padma Venkat
2013-02-05 23:51 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2013-02-14 3:47 Padmavathi Venna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302041743.55029.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox