* [PATCH] ARM: dts: mxs: add auart2 pinmux to imx28.dtsi
@ 2013-10-16 16:04 Aida Mynzhasova
2013-10-17 7:52 ` Lothar Waßmann
0 siblings, 1 reply; 3+ messages in thread
From: Aida Mynzhasova @ 2013-10-16 16:04 UTC (permalink / raw)
To: linux-arm-kernel
Add auart2 pins configuration on its main pads
Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
---
arch/arm/boot/dts/imx28.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 7363fde..81102b2 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -320,6 +320,19 @@
fsl,pull-up = <0>;
};
+ auart2_pins_a: auart2 at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ 0x3080 /* MX28_PAD_AUART2_RX__AUART2_RX */
+ 0x3090 /* MX28_PAD_AUART2_TX__AUART2_TX */
+ 0x30a0 /* MX28_PAD_AUART2_CTS__AUART2_CTS */
+ 0x30b0 /* MX28_PAD_AUART2_RTS__AUART2_RTS */
+ >;
+ fsl,drive-strength = <0>;
+ fsl,voltage = <1>;
+ fsl,pull-up = <0>;
+ };
+
auart2_2pins_a: auart2-2pins at 0 {
reg = <0>;
fsl,pinmux-ids = <
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: mxs: add auart2 pinmux to imx28.dtsi
2013-10-16 16:04 [PATCH] ARM: dts: mxs: add auart2 pinmux to imx28.dtsi Aida Mynzhasova
@ 2013-10-17 7:52 ` Lothar Waßmann
0 siblings, 0 replies; 3+ messages in thread
From: Lothar Waßmann @ 2013-10-17 7:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Aida Mynzhasova <aida.mynzhasova@skitlab.ru> wrote:
> Add auart2 pins configuration on its main pads
>
> Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
> ---
> arch/arm/boot/dts/imx28.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 7363fde..81102b2 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -320,6 +320,19 @@
> fsl,pull-up = <0>;
> };
>
> + auart2_pins_a: auart2 at 0 {
> + reg = <0>;
> + fsl,pinmux-ids = <
> + 0x3080 /* MX28_PAD_AUART2_RX__AUART2_RX */
> + 0x3090 /* MX28_PAD_AUART2_TX__AUART2_TX */
> + 0x30a0 /* MX28_PAD_AUART2_CTS__AUART2_CTS */
> + 0x30b0 /* MX28_PAD_AUART2_RTS__AUART2_RTS */
>
Since commit 27572a2f ARM: dts: mxs: add pinctrl header files
it is no longer necessary to specify the padconfig values as numbers.
You should use the symbolic names instead.
> + >;
> + fsl,drive-strength = <0>;
> + fsl,voltage = <1>;
> + fsl,pull-up = <0>;
Also these should be:
fsl,drive-strength = <MXS_DRIVE_4mA>;
fsl,voltage = <MXS_VOLTAGE_HIGH>;
fsl,pull-up = <MXS_PULL_DISABLE>;
You probably should rebase your patch to a more recent version of
linux-next.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: mxs: add auart2 pinmux to imx28.dtsi
@ 2013-10-22 8:34 Aida Mynzhasova
0 siblings, 0 replies; 3+ messages in thread
From: Aida Mynzhasova @ 2013-10-22 8:34 UTC (permalink / raw)
To: linux-arm-kernel
Add auart2 pins configuration on its main pads
Signed-off-by: Aida Mynzhasova <aida.mynzhasova@skitlab.ru>
---
arch/arm/boot/dts/imx28.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 918d419..cab4c22 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -343,6 +343,19 @@
fsl,pull-up = <MXS_PULL_DISABLE>;
};
+ auart2_pins_a: auart2-pins at 0 {
+ reg = <0>;
+ fsl,pinmux-ids = <
+ MX28_PAD_AUART2_RX__AUART2_RX
+ MX28_PAD_AUART2_TX__AUART2_TX
+ MX28_PAD_AUART2_CTS__AUART2_CTS
+ MX28_PAD_AUART2_RTS__AUART2_RTS
+ >;
+ fsl,drive-strength = <MXS_DRIVE_4mA>;
+ fsl,voltage = <MXS_VOLTAGE_HIGH>;
+ fsl,pull-up = <MXS_PULL_DISABLE>;
+ };
+
auart3_pins_a: auart3 at 0 {
reg = <0>;
fsl,pinmux-ids = <
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-22 8:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-16 16:04 [PATCH] ARM: dts: mxs: add auart2 pinmux to imx28.dtsi Aida Mynzhasova
2013-10-17 7:52 ` Lothar Waßmann
-- strict thread matches above, loose matches on Subject: below --
2013-10-22 8:34 Aida Mynzhasova
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox