* [patch] pinctrl: rockchip: testing the wrong variable
@ 2013-11-08 10:01 Dan Carpenter
2013-11-08 11:44 ` Heiko Stübner
2013-11-19 7:56 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-11-08 10:01 UTC (permalink / raw)
To: linux-arm-kernel
There is a copy and paste bug so we test "info->reg_base" instead of
"info->reg_pull".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I can't compile this.
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index e939c28..fe2ec1b 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1453,8 +1453,8 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
if (ctrl->type == RK3188) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
info->reg_pull = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(info->reg_base))
- return PTR_ERR(info->reg_base);
+ if (IS_ERR(info->reg_pull))
+ return PTR_ERR(info->reg_pull);
}
ret = rockchip_gpiolib_register(pdev, info);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] pinctrl: rockchip: testing the wrong variable
2013-11-08 10:01 [patch] pinctrl: rockchip: testing the wrong variable Dan Carpenter
@ 2013-11-08 11:44 ` Heiko Stübner
2013-11-19 7:56 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2013-11-08 11:44 UTC (permalink / raw)
To: linux-arm-kernel
Am Freitag, 8. November 2013, 11:01:38 schrieb Dan Carpenter:
> There is a copy and paste bug so we test "info->reg_base" instead of
> "info->reg_pull".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the catch
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> I can't compile this.
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..fe2ec1b 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1453,8 +1453,8 @@ static int rockchip_pinctrl_probe(struct
> platform_device *pdev) if (ctrl->type == RK3188) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> info->reg_pull = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(info->reg_base))
> - return PTR_ERR(info->reg_base);
> + if (IS_ERR(info->reg_pull))
> + return PTR_ERR(info->reg_pull);
> }
>
> ret = rockchip_gpiolib_register(pdev, info);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] pinctrl: rockchip: testing the wrong variable
2013-11-08 10:01 [patch] pinctrl: rockchip: testing the wrong variable Dan Carpenter
2013-11-08 11:44 ` Heiko Stübner
@ 2013-11-19 7:56 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-11-19 7:56 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 8, 2013 at 11:01 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There is a copy and paste bug so we test "info->reg_base" instead of
> "info->reg_pull".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied for fixes with Heiko's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-19 7:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 10:01 [patch] pinctrl: rockchip: testing the wrong variable Dan Carpenter
2013-11-08 11:44 ` Heiko Stübner
2013-11-19 7:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox