Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sre@ring0.de (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree
Date: Thu, 14 Nov 2013 00:29:24 +0100	[thread overview]
Message-ID: <20131113232923.GB13669@earth.universe> (raw)
In-Reply-To: <20131113142406.GH21713@e106331-lin.cambridge.arm.com>

Hi,

On Wed, Nov 13, 2013 at 02:24:06PM +0000, Mark Rutland wrote:
> > Current suggestions (taken from kernel) are:
> > 
> > * <<vendor>>,no-autorepeat
> > * keypad,autorepeat
> > * linux,keypad-no-autorepeat
> > * linux,input-no-autorepeat
> > * linux,no-autorepeat
> > * autorepeat
> > 
> > I do not really care, which one is chosen, except for two things:
> > 
> > * <<vendor>> seems wrong. This is not vendor specific.
> > * I would prefer "input-" over "keypad-", since then the same name
> >   can be used for single keys, buttons, etc.
> 
> Both of those sound valid to me, but I think it may make sense to keep
> the "linux," prefix. As I understand it this is really telling the Linux
> input subsystem to react to a device acting in a certain way, rather
> than describing or configuring the device in a certain way.

That leaves the following two options:

* linux,input-no-autorepeat
* linux,no-autorepeat

Any suggestions for those?

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131114/bb218d1c/attachment.sig>

  reply	other threads:[~2013-11-13 23:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 14:13 [PATCH 4/5 v2] input: tc3589x-keypad: support probing from device tree Linus Walleij
2013-11-12 15:30 ` Sebastian Reichel
2013-11-12 17:06   ` Linus Walleij
2013-11-12 20:05     ` Sebastian Reichel
2013-11-12 20:11       ` Linus Walleij
2013-11-12 20:40         ` Sebastian Reichel
2013-11-13 14:24           ` Mark Rutland
2013-11-13 23:29             ` Sebastian Reichel [this message]
2013-11-14 11:12               ` Mark Rutland
2013-11-17 18:28             ` Pavel Machek
2013-12-02 11:37               ` Mark Rutland
2013-12-02 11:54                 ` Pavel Machek
2013-12-02 12:08                   ` Mark Rutland
2013-12-02 13:03                     ` Pavel Machek
2013-11-17 18:28           ` Pavel Machek
2013-11-17 19:03             ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113232923.GB13669@earth.universe \
    --to=sre@ring0.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox