* [PATCH] audit: Modify a set of system calls in audit class definitions
@ 2014-01-17 8:05 AKASHI Takahiro
2014-01-17 12:28 ` Will Deacon
2014-01-17 19:42 ` Richard Guy Briggs
0 siblings, 2 replies; 3+ messages in thread
From: AKASHI Takahiro @ 2014-01-17 8:05 UTC (permalink / raw)
To: linux-arm-kernel
Each asm-generic/audit_xx.h defines a set of system calls for respective
audit permssion class (read, write, change attribute or exec).
This patch changes two entries:
1) fchown in audit_change_attr.h
Make fchown included by its own because in asm-generic/unistd.h, for example,
fchown always exists while chown is optional. This change is necessary at
least for arm64.
2) truncate64 in audit_write.h
Add missing truncate64/ftruncate64 as well as truncate/ftruncate
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
include/asm-generic/audit_change_attr.h | 4 +++-
include/asm-generic/audit_write.h | 6 ++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/asm-generic/audit_change_attr.h b/include/asm-generic/audit_change_attr.h
index 89b73e5..a186553 100644
--- a/include/asm-generic/audit_change_attr.h
+++ b/include/asm-generic/audit_change_attr.h
@@ -4,9 +4,11 @@ __NR_chmod,
__NR_fchmod,
#ifdef __NR_chown
__NR_chown,
-__NR_fchown,
__NR_lchown,
#endif
+#ifdef __NR_fchown
+__NR_fchown,
+#endif
__NR_setxattr,
__NR_lsetxattr,
__NR_fsetxattr,
diff --git a/include/asm-generic/audit_write.h b/include/asm-generic/audit_write.h
index e7020c5..274575d 100644
--- a/include/asm-generic/audit_write.h
+++ b/include/asm-generic/audit_write.h
@@ -10,6 +10,12 @@ __NR_truncate,
#ifdef __NR_truncate64
__NR_truncate64,
#endif
+#ifdef __NR_ftruncate
+__NR_ftruncate,
+#endif
+#ifdef __NR_ftruncate64
+__NR_ftruncate64,
+#endif
#ifdef __NR_bind
__NR_bind, /* bind can affect fs object only in one way... */
#endif
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] audit: Modify a set of system calls in audit class definitions
2014-01-17 8:05 [PATCH] audit: Modify a set of system calls in audit class definitions AKASHI Takahiro
@ 2014-01-17 12:28 ` Will Deacon
2014-01-17 19:42 ` Richard Guy Briggs
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2014-01-17 12:28 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 17, 2014 at 08:05:03AM +0000, AKASHI Takahiro wrote:
> Each asm-generic/audit_xx.h defines a set of system calls for respective
> audit permssion class (read, write, change attribute or exec).
permission
> This patch changes two entries:
>
> 1) fchown in audit_change_attr.h
> Make fchown included by its own because in asm-generic/unistd.h, for example,
> fchown always exists while chown is optional. This change is necessary at
> least for arm64.
>
> 2) truncate64 in audit_write.h
> Add missing truncate64/ftruncate64 as well as truncate/ftruncate
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] audit: Modify a set of system calls in audit class definitions
2014-01-17 8:05 [PATCH] audit: Modify a set of system calls in audit class definitions AKASHI Takahiro
2014-01-17 12:28 ` Will Deacon
@ 2014-01-17 19:42 ` Richard Guy Briggs
1 sibling, 0 replies; 3+ messages in thread
From: Richard Guy Briggs @ 2014-01-17 19:42 UTC (permalink / raw)
To: linux-arm-kernel
On 14/01/17, AKASHI Takahiro wrote:
> Each asm-generic/audit_xx.h defines a set of system calls for respective
> audit permssion class (read, write, change attribute or exec).
> This patch changes two entries:
>
> 1) fchown in audit_change_attr.h
> Make fchown included by its own because in asm-generic/unistd.h, for example,
> fchown always exists while chown is optional. This change is necessary at
> least for arm64.
>
> 2) truncate64 in audit_write.h
> Add missing truncate64/ftruncate64 as well as truncate/ftruncate
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> include/asm-generic/audit_change_attr.h | 4 +++-
> include/asm-generic/audit_write.h | 6 ++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/audit_change_attr.h b/include/asm-generic/audit_change_attr.h
> index 89b73e5..a186553 100644
> --- a/include/asm-generic/audit_change_attr.h
> +++ b/include/asm-generic/audit_change_attr.h
> @@ -4,9 +4,11 @@ __NR_chmod,
> __NR_fchmod,
> #ifdef __NR_chown
> __NR_chown,
> -__NR_fchown,
> __NR_lchown,
> #endif
> +#ifdef __NR_fchown
> +__NR_fchown,
> +#endif
> __NR_setxattr,
> __NR_lsetxattr,
> __NR_fsetxattr,
> diff --git a/include/asm-generic/audit_write.h b/include/asm-generic/audit_write.h
> index e7020c5..274575d 100644
> --- a/include/asm-generic/audit_write.h
> +++ b/include/asm-generic/audit_write.h
> @@ -10,6 +10,12 @@ __NR_truncate,
> #ifdef __NR_truncate64
> __NR_truncate64,
> #endif
> +#ifdef __NR_ftruncate
> +__NR_ftruncate,
> +#endif
> +#ifdef __NR_ftruncate64
> +__NR_ftruncate64,
> +#endif
> #ifdef __NR_bind
> __NR_bind, /* bind can affect fs object only in one way... */
> #endif
> --
> 1.7.9.5
>
- RGB
--
Richard Guy Briggs <rbriggs@redhat.com>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-17 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-17 8:05 [PATCH] audit: Modify a set of system calls in audit class definitions AKASHI Takahiro
2014-01-17 12:28 ` Will Deacon
2014-01-17 19:42 ` Richard Guy Briggs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox