* [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10
@ 2014-02-13 15:53 Fabio Estevam
2014-02-13 15:53 ` [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator Fabio Estevam
2014-02-17 2:05 ` [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2014-02-13 15:53 UTC (permalink / raw)
To: linux-arm-kernel
GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec.
Add a hog entry for it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 0d816d3..a802265 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -303,6 +303,7 @@
MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x80000000
MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
+ MX6QDL_PAD_KEY_COL2__GPIO4_IO10 0x80000000
>;
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator
2014-02-13 15:53 [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Fabio Estevam
@ 2014-02-13 15:53 ` Fabio Estevam
2014-02-17 2:13 ` Shawn Guo
2014-02-17 2:05 ` [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-02-13 15:53 UTC (permalink / raw)
To: linux-arm-kernel
Currently the following message is observed during boot:
wm8962-supply: no parameters
Provide min/max properties for the codec regulator.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index a802265..086f770 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -47,6 +47,8 @@
compatible = "regulator-fixed";
reg = <2>;
regulator-name = "wm8962-supply";
+ regulator-min-microvolt = <4200000>;
+ regulator-max-microvolt = <4200000>;
gpio = <&gpio4 10 0>;
enable-active-high;
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator
2014-02-13 15:53 ` [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator Fabio Estevam
@ 2014-02-17 2:13 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2014-02-17 2:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 13, 2014 at 01:53:59PM -0200, Fabio Estevam wrote:
> Currently the following message is observed during boot:
>
> wm8962-supply: no parameters
>
> Provide min/max properties for the codec regulator.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index a802265..086f770 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -47,6 +47,8 @@
> compatible = "regulator-fixed";
> reg = <2>;
> regulator-name = "wm8962-supply";
> + regulator-min-microvolt = <4200000>;
> + regulator-max-microvolt = <4200000>;
I guess they were omitted on purpose, because it's a backed up by a
number of supplies at different voltages.
Shawn
[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/244470/focus=244475
> gpio = <&gpio4 10 0>;
> enable-active-high;
> };
> --
> 1.8.1.2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10
2014-02-13 15:53 [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Fabio Estevam
2014-02-13 15:53 ` [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator Fabio Estevam
@ 2014-02-17 2:05 ` Shawn Guo
2014-02-17 2:11 ` Fabio Estevam
1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2014-02-17 2:05 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote:
> GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec.
>
> Add a hog entry for it.
I'm going to be strict on hog pin use. It does not sound like a true
hog pin. Is it possible to have a pinctrl state for that regulator
setting this pin up?
Shawn
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 0d816d3..a802265 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -303,6 +303,7 @@
> MX6QDL_PAD_ENET_TXD1__GPIO1_IO29 0x80000000
> MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x80000000
> MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> + MX6QDL_PAD_KEY_COL2__GPIO4_IO10 0x80000000
> >;
> };
>
> --
> 1.8.1.2
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10
2014-02-17 2:05 ` [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Shawn Guo
@ 2014-02-17 2:11 ` Fabio Estevam
2014-02-17 2:19 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2014-02-17 2:11 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Feb 16, 2014 at 11:05 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote:
>> GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec.
>>
>> Add a hog entry for it.
>
> I'm going to be strict on hog pin use. It does not sound like a true
> hog pin. Is it possible to have a pinctrl state for that regulator
> setting this pin up?
Could you please explain when a pin should or should not be placed
into the hog group?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10
2014-02-17 2:11 ` Fabio Estevam
@ 2014-02-17 2:19 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2014-02-17 2:19 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Feb 16, 2014 at 11:11:40PM -0300, Fabio Estevam wrote:
> On Sun, Feb 16, 2014 at 11:05 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> > On Thu, Feb 13, 2014 at 01:53:58PM -0200, Fabio Estevam wrote:
> >> GPIO4_10 is the GPIO used to turn on the regulator that powers up the codec.
> >>
> >> Add a hog entry for it.
> >
> > I'm going to be strict on hog pin use. It does not sound like a true
> > hog pin. Is it possible to have a pinctrl state for that regulator
> > setting this pin up?
>
> Could you please explain when a pin should or should not be placed
> into the hog group?
The hog group is for those pins that do not belong to any particular
client device. IOW, we should only put a pin into hog group when it
can not be put into any client device's pinctrl state.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-17 2:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-13 15:53 [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Fabio Estevam
2014-02-13 15:53 ` [PATCH 2/2] ARM: dts: imx6qdl-sabresd: Provide min/max voltages for codec regulator Fabio Estevam
2014-02-17 2:13 ` Shawn Guo
2014-02-17 2:05 ` [PATCH 1/2] ARM: dts: imx6qdl-sabresd: Add hog entry for GPIO4_10 Shawn Guo
2014-02-17 2:11 ` Fabio Estevam
2014-02-17 2:19 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox