public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 0/2] DT updates for Cubox-i
@ 2014-06-17 13:40 Russell King - ARM Linux
  2014-06-17 13:40 ` [PATCH 1/2] ARM: dts: cubox-i: add support for PWM-driven front panel LED Russell King
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2014-06-17 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

Shawn,

These are two updates to the Cubox-i which I'd prefer to get into -rc.
They were omitted from the merge window because their dependent changes
were not merged, but have now been merged.

The only real functional change for the Cubox-i in this set is that it
is now possible to control the front panel LED.  The other patch is
solely about moving some DT configuration to where it belongs.

Can we please get these in?

Thanks.

 arch/arm/boot/dts/imx6dl-hummingboard.dts | 10 ++++++++++
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi    | 27 +++++++++++++++++++++++++++
 arch/arm/boot/dts/imx6qdl-microsom.dtsi   | 13 -------------
 3 files changed, 37 insertions(+), 13 deletions(-)

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: dts: cubox-i: add support for PWM-driven front panel LED
  2014-06-17 13:40 [PATCH 0/2] DT updates for Cubox-i Russell King - ARM Linux
@ 2014-06-17 13:40 ` Russell King
  2014-06-17 13:41 ` [PATCH 2/2] ARM: dts: hummingboard/cubox-i: move usb otg configuration to platform level Russell King
  2014-06-17 13:59 ` [PATCH 0/2] DT updates for Cubox-i Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Russell King @ 2014-06-17 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

The front panel LED on the Cubox-i is driven by one of the iMX6 PWM
channels, and is wired between the PWM output and supply.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 25da82a03110..9202c8d18a30 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -12,6 +12,19 @@
 		pinctrl-0 = <&pinctrl_cubox_i_ir>;
 	};
 
+	pwmleds {
+		compatible = "pwm-leds";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_cubox_i_pwm1>;
+
+		front {
+			active-low;
+			label = "imx6:red:front";
+			max-brightness = <248>;
+			pwms = <&pwm1 0 50000>;
+		};
+	};
+
 	regulators {
 		compatible = "simple-bus";
 
@@ -109,6 +122,10 @@
 			>;
 		};
 
+		pinctrl_cubox_i_pwm1: cubox-i-pwm1-front-led {
+			fsl,pins = <MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b0>;
+		};
+
 		pinctrl_cubox_i_spdif: cubox-i-spdif {
 			fsl,pins = <MX6QDL_PAD_GPIO_17__SPDIF_OUT 0x13091>;
 		};
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: hummingboard/cubox-i: move usb otg configuration to platform level
  2014-06-17 13:40 [PATCH 0/2] DT updates for Cubox-i Russell King - ARM Linux
  2014-06-17 13:40 ` [PATCH 1/2] ARM: dts: cubox-i: add support for PWM-driven front panel LED Russell King
@ 2014-06-17 13:41 ` Russell King
  2014-06-17 13:59 ` [PATCH 0/2] DT updates for Cubox-i Shawn Guo
  2 siblings, 0 replies; 5+ messages in thread
From: Russell King @ 2014-06-17 13:41 UTC (permalink / raw)
  To: linux-arm-kernel

The configuration of the USB OTG is a platform configuration decision,
not a microsom decision.  Move this configuration out to the platform
level files.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/boot/dts/imx6dl-hummingboard.dts | 10 ++++++++++
 arch/arm/boot/dts/imx6qdl-cubox-i.dtsi    | 10 ++++++++++
 arch/arm/boot/dts/imx6qdl-microsom.dtsi   | 13 -------------
 3 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-hummingboard.dts b/arch/arm/boot/dts/imx6dl-hummingboard.dts
index 5373a5f2782b..c8e51dd41b8f 100644
--- a/arch/arm/boot/dts/imx6dl-hummingboard.dts
+++ b/arch/arm/boot/dts/imx6dl-hummingboard.dts
@@ -143,6 +143,14 @@
 			fsl,pins = <MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0>;
 		};
 
+		pinctrl_hummingboard_usbotg_id: hummingboard-usbotg-id {
+			/*
+			 * Similar to pinctrl_usbotg_2, but we want it
+			 * pulled down for a fixed host connection.
+			 */
+			fsl,pins = <MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x13059>;
+		};
+
 		pinctrl_hummingboard_usbotg_vbus: hummingboard-usbotg-vbus {
 			fsl,pins = <MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x1b0b0>;
 		};
@@ -178,6 +186,8 @@
 };
 
 &usbotg {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hummingboard_usbotg_id>;
 	vbus-supply = <&reg_usbotg_vbus>;
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
index 9202c8d18a30..e8e781656b3f 100644
--- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
@@ -134,6 +134,14 @@
 			fsl,pins = <MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x4001b0b0>;
 		};
 
+		pinctrl_cubox_i_usbotg_id: cubox-i-usbotg-id {
+			/*
+			 * The Cubox-i pulls this low, but as it's pointless
+			 * leaving it as a pull-up, even if it is just 10uA.
+			 */
+			fsl,pins = <MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x13059>;
+		};
+
 		pinctrl_cubox_i_usbotg_vbus: cubox-i-usbotg-vbus {
 			fsl,pins = <MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x4001b0b0>;
 		};
@@ -170,6 +178,8 @@
 };
 
 &usbotg {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_cubox_i_usbotg_id>;
 	vbus-supply = <&reg_usbotg_vbus>;
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/imx6qdl-microsom.dtsi b/arch/arm/boot/dts/imx6qdl-microsom.dtsi
index d729d0b15f25..79eac6849d4c 100644
--- a/arch/arm/boot/dts/imx6qdl-microsom.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-microsom.dtsi
@@ -10,14 +10,6 @@
 				MX6QDL_PAD_CSI0_DAT11__UART1_RX_DATA	0x1b0b1
 			>;
 		};
-
-		pinctrl_microsom_usbotg: microsom-usbotg {
-			/*
-			 * Similar to pinctrl_usbotg_2, but we want it
-			 * pulled down for a fixed host connection.
-			 */
-			fsl,pins = <MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x13059>;
-		};
 	};
 };
 
@@ -26,8 +18,3 @@
 	pinctrl-0 = <&pinctrl_microsom_uart1>;
 	status = "okay";
 };
-
-&usbotg {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_microsom_usbotg>;
-};
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 0/2] DT updates for Cubox-i
  2014-06-17 13:40 [PATCH 0/2] DT updates for Cubox-i Russell King - ARM Linux
  2014-06-17 13:40 ` [PATCH 1/2] ARM: dts: cubox-i: add support for PWM-driven front panel LED Russell King
  2014-06-17 13:41 ` [PATCH 2/2] ARM: dts: hummingboard/cubox-i: move usb otg configuration to platform level Russell King
@ 2014-06-17 13:59 ` Shawn Guo
  2014-06-17 15:15   ` Russell King - ARM Linux
  2 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2014-06-17 13:59 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jun 17, 2014 at 02:40:16PM +0100, Russell King - ARM Linux wrote:
> Shawn,
> 
> These are two updates to the Cubox-i which I'd prefer to get into -rc.
> They were omitted from the merge window because their dependent changes
> were not merged, but have now been merged.
> 
> The only real functional change for the Cubox-i in this set is that it
> is now possible to control the front panel LED.  The other patch is
> solely about moving some DT configuration to where it belongs.
> 
> Can we please get these in?

Okay, I will send them together with the fixes I queued for -rc.

Shawn

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 0/2] DT updates for Cubox-i
  2014-06-17 13:59 ` [PATCH 0/2] DT updates for Cubox-i Shawn Guo
@ 2014-06-17 15:15   ` Russell King - ARM Linux
  0 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2014-06-17 15:15 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jun 17, 2014 at 09:59:20PM +0800, Shawn Guo wrote:
> On Tue, Jun 17, 2014 at 02:40:16PM +0100, Russell King - ARM Linux wrote:
> > Shawn,
> > 
> > These are two updates to the Cubox-i which I'd prefer to get into -rc.
> > They were omitted from the merge window because their dependent changes
> > were not merged, but have now been merged.
> > 
> > The only real functional change for the Cubox-i in this set is that it
> > is now possible to control the front panel LED.  The other patch is
> > solely about moving some DT configuration to where it belongs.
> > 
> > Can we please get these in?
> 
> Okay, I will send them together with the fixes I queued for -rc.

Thanks.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-06-17 15:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 13:40 [PATCH 0/2] DT updates for Cubox-i Russell King - ARM Linux
2014-06-17 13:40 ` [PATCH 1/2] ARM: dts: cubox-i: add support for PWM-driven front panel LED Russell King
2014-06-17 13:41 ` [PATCH 2/2] ARM: dts: hummingboard/cubox-i: move usb otg configuration to platform level Russell King
2014-06-17 13:59 ` [PATCH 0/2] DT updates for Cubox-i Shawn Guo
2014-06-17 15:15   ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox