From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support
Date: Thu, 18 Sep 2014 22:17:06 +0800 [thread overview]
Message-ID: <20140918141705.GM4796@dragon> (raw)
In-Reply-To: <cea494421deefe0b862e31b08685074715acf8d6.1410930820.git.bhuvanchandra.dv@toradex.com>
On Wed, Sep 17, 2014 at 01:46:30PM +0530, Bhuvanchandra DV wrote:
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 6 ++++++
> arch/arm/boot/dts/vf610-colibri.dtsi | 7 +++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> index ba98039..f1988a0 100644
> --- a/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/vf610-colibri-eval-v3.dts
> @@ -52,3 +52,9 @@
> &pwm1 {
> status = "okay";
> };
> +
> +&backlight {
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness-level = <6>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/vf610-colibri.dtsi b/arch/arm/boot/dts/vf610-colibri.dtsi
> index 9bd1415..e725306 100644
> --- a/arch/arm/boot/dts/vf610-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf610-colibri.dtsi
> @@ -25,6 +25,13 @@
> };
> };
>
> + backlight: bl {
I would suggest we name the node following the example in
Documentation/devicetree/bindings/pwm/pwm.txt, i.e. bl: backlight.
> + compitable = "pwm-backlight";
> + pwms = <&pwm0 0 5000000 0>;
> + pwm-names = " backlight";
Drop the leading space in the string.
Shawn
> + status = "disabled";
> + };
> +
> };
>
> &esdhc1 {
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2014-09-18 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 8:16 [PATCH 0/3] Add PWM and backlight support for Colibri VF61 modules Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 1/3] ARM: dts: vf610: Add PWM second instance Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 2/3] ARM: dts: vf610-colibri: Add PWM support Bhuvanchandra DV
2014-09-18 14:12 ` Shawn Guo
2014-09-19 10:19 ` Bhuvanchandra DV
2014-09-17 8:16 ` [PATCH 3/3] ARM: dts: vf610-colibri: Add backlight support Bhuvanchandra DV
2014-09-18 14:17 ` Shawn Guo [this message]
2014-09-19 10:27 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918141705.GM4796@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox