* [PATCH] arm64: KVM: Fix TLB invalidation by IPA/VMID
@ 2014-12-19 17:18 Marc Zyngier
2014-12-28 18:20 ` Christoffer Dall
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2014-12-19 17:18 UTC (permalink / raw)
To: linux-arm-kernel
It took about two years for someone to notice that the IPA passed
to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
is not as good as it should be...
Paper bag time for me.
Reported-by: Mario Smarduch <m.smarduch@samsung.com>
Tested-by: Mario Smarduch <m.smarduch@samsung.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm64/kvm/hyp.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S
index b72aa9f..a767f6a 100644
--- a/arch/arm64/kvm/hyp.S
+++ b/arch/arm64/kvm/hyp.S
@@ -1014,6 +1014,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa)
* Instead, we invalidate Stage-2 for this IPA, and the
* whole of Stage-1. Weep...
*/
+ lsr x1, x1, #12
tlbi ipas2e1is, x1
/*
* We have to ensure completion of the invalidation at Stage-2,
--
2.1.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm64: KVM: Fix TLB invalidation by IPA/VMID
2014-12-19 17:18 [PATCH] arm64: KVM: Fix TLB invalidation by IPA/VMID Marc Zyngier
@ 2014-12-28 18:20 ` Christoffer Dall
2014-12-29 6:04 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Christoffer Dall @ 2014-12-28 18:20 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 19, 2014 at 05:18:47PM +0000, Marc Zyngier wrote:
> It took about two years for someone to notice that the IPA passed
> to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
> is not as good as it should be...
>
> Paper bag time for me.
>
> Reported-by: Mario Smarduch <m.smarduch@samsung.com>
> Tested-by: Mario Smarduch <m.smarduch@samsung.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks, applied to queue.
-Christoffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: KVM: Fix TLB invalidation by IPA/VMID
2014-12-28 18:20 ` Christoffer Dall
@ 2014-12-29 6:04 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2014-12-29 6:04 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Dec 28 2014 at 06:20:47 PM, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> On Fri, Dec 19, 2014 at 05:18:47PM +0000, Marc Zyngier wrote:
>> It took about two years for someone to notice that the IPA passed
>> to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing
>> is not as good as it should be...
>>
>> Paper bag time for me.
>>
>> Reported-by: Mario Smarduch <m.smarduch@samsung.com>
>> Tested-by: Mario Smarduch <m.smarduch@samsung.com>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>
> Thanks, applied to queue.
Thanks for picking this up. This should also be CC-ed to -stable, as all
versions of the kernel since 3.11 are affected.
M.
--
Jazz is not dead. It just smells funny.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-29 6:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 17:18 [PATCH] arm64: KVM: Fix TLB invalidation by IPA/VMID Marc Zyngier
2014-12-28 18:20 ` Christoffer Dall
2014-12-29 6:04 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox