* [PATCH] serial: pl010 is no longer broken
@ 2015-02-25 15:06 Arnd Bergmann
2015-02-25 16:02 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2015-02-25 15:06 UTC (permalink / raw)
To: linux-arm-kernel
As more ARM platforms are moving into ARCH_MULTIPLATFORM, we can now
have integrator and versatile in the same kernel, and first one selects
this driver, causing a Kconfig warning:
warning: (ARCH_INTEGRATOR_AP) selects SERIAL_AMBA_PL010 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA && (BROKEN || !ARCH_VERSATILE))
It turns out that it has not been broken on versatile for a long time,
so we can remove the statement here.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index d2501f01cd03..bbb12794cc8c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -20,7 +20,7 @@ comment "Non-8250 serial port support"
config SERIAL_AMBA_PL010
tristate "ARM AMBA PL010 serial port support"
- depends on ARM_AMBA && (BROKEN || !ARCH_VERSATILE)
+ depends on ARM_AMBA
select SERIAL_CORE
help
This selects the ARM(R) AMBA(R) PrimeCell PL010 UART. If you have
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] serial: pl010 is no longer broken
2015-02-25 15:06 [PATCH] serial: pl010 is no longer broken Arnd Bergmann
@ 2015-02-25 16:02 ` Greg Kroah-Hartman
2015-02-25 16:04 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2015-02-25 16:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 25, 2015 at 04:06:09PM +0100, Arnd Bergmann wrote:
> As more ARM platforms are moving into ARCH_MULTIPLATFORM, we can now
> have integrator and versatile in the same kernel, and first one selects
> this driver, causing a Kconfig warning:
>
> warning: (ARCH_INTEGRATOR_AP) selects SERIAL_AMBA_PL010 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA && (BROKEN || !ARCH_VERSATILE))
>
> It turns out that it has not been broken on versatile for a long time,
> so we can remove the statement here.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index d2501f01cd03..bbb12794cc8c 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -20,7 +20,7 @@ comment "Non-8250 serial port support"
>
> config SERIAL_AMBA_PL010
> tristate "ARM AMBA PL010 serial port support"
> - depends on ARM_AMBA && (BROKEN || !ARCH_VERSATILE)
> + depends on ARM_AMBA
> select SERIAL_CORE
> help
> This selects the ARM(R) AMBA(R) PrimeCell PL010 UART. If you have
>
Is it ok if we wait for 4.1-rc1 for this, or do you think it's really ok
for 4.0-final?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] serial: pl010 is no longer broken
2015-02-25 16:02 ` Greg Kroah-Hartman
@ 2015-02-25 16:04 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-02-25 16:04 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 25 February 2015 08:02:16 Greg Kroah-Hartman wrote:
> On Wed, Feb 25, 2015 at 04:06:09PM +0100, Arnd Bergmann wrote:
> > As more ARM platforms are moving into ARCH_MULTIPLATFORM, we can now
> > have integrator and versatile in the same kernel, and first one selects
> > this driver, causing a Kconfig warning:
> >
> > warning: (ARCH_INTEGRATOR_AP) selects SERIAL_AMBA_PL010 which has unmet direct dependencies (TTY && HAS_IOMEM && ARM_AMBA && (BROKEN || !ARCH_VERSATILE))
> >
> > It turns out that it has not been broken on versatile for a long time,
> > so we can remove the statement here.
> Is it ok if we wait for 4.1-rc1 for this, or do you think it's really ok
> for 4.0-final?
It's not urgent and should just go into 4.1.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-25 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 15:06 [PATCH] serial: pl010 is no longer broken Arnd Bergmann
2015-02-25 16:02 ` Greg Kroah-Hartman
2015-02-25 16:04 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox