[PATCH 1/5] ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

[PATCH 1/5] ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

[Gwenhael Goavec-Merou]

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
index 1f38a05..86e8d81 100644
--- a/arch/arm/boot/dts/imx28-apf28dev.dts
+++ b/arch/arm/boot/dts/imx28-apf28dev.dts
@@ -143,7 +143,8 @@
 	ahb at 80080000 {
 		usb0: usb at 80080000 {
 			pinctrl-names = "default";
-			pinctrl-0 = <&usb0_otg_apf28dev>;
+			pinctrl-0 = <&usb0_otg_apf28dev
+					&usb0_id_pins_b>;
 			vbus-supply = <&reg_usb0_vbus>;
 			status = "okay";
 		};
-- 
2.0.5

[PATCH 2/5] ARM: dts: imx28-apf28: fix mac0 gpio polarity

[Gwenhael Goavec-Merou]

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28-apf28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-apf28.dts b/arch/arm/boot/dts/imx28-apf28.dts
index 7198fe3..070e59c 100644
--- a/arch/arm/boot/dts/imx28-apf28.dts
+++ b/arch/arm/boot/dts/imx28-apf28.dts
@@ -78,7 +78,7 @@
 			phy-mode = "rmii";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mac0_pins_a>;
-			phy-reset-gpios = <&gpio4 13 0>;
+			phy-reset-gpios = <&gpio4 13 GPIO_ACTIVE_LOW>;
 			status = "okay";
 		};
 	};
-- 
2.0.5

[PATCH 3/5] ARM: dts: imx28-apf28dev: fix mac1 gpio location and polarity

[Gwenhael Goavec-Merou]

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
index 86e8d81..68405c3 100644
--- a/arch/arm/boot/dts/imx28-apf28dev.dts
+++ b/arch/arm/boot/dts/imx28-apf28dev.dts
@@ -157,7 +157,7 @@
 			phy-mode = "rmii";
 			pinctrl-names = "default";
 			pinctrl-0 = <&mac1_pins_a>;
-			phy-reset-gpios = <&gpio0 23 0>;
+			phy-reset-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>;
 			status = "okay";
 		};
 	};
-- 
2.0.5

[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[Gwenhael Goavec-Merou]

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
index 68405c3..a052d3e 100644
--- a/arch/arm/boot/dts/imx28-apf28dev.dts
+++ b/arch/arm/boot/dts/imx28-apf28dev.dts
@@ -110,6 +110,13 @@
 					};
 				};
 			};
+
+			can0: can at 80032000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&can0_pins_a>;
+				xceiver-supply = <&reg_can0_vcc>;
+				status = "okay";
+			};
 		};
 
 		apbx at 80040000 {
@@ -176,6 +183,14 @@
 			gpio = <&gpio1 23 1>;
 			enable-active-high;
 		};
+
+		reg_can0_vcc: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;
+			regulator-name = "can0_vcc";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+		};
 	};
 
 	leds {
-- 
2.0.5

[PATCH 5/5] ARM: dts: imx28-apf28dev: add support for auart0

[Gwenhael Goavec-Merou]

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28-apf28dev.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
index a052d3e..81e5f75 100644
--- a/arch/arm/boot/dts/imx28-apf28dev.dts
+++ b/arch/arm/boot/dts/imx28-apf28dev.dts
@@ -137,6 +137,13 @@
 				status = "okay";
 			};
 
+			auart0: serial at 8006a000 {
+				pinctrl-names = "default";
+				pinctrl-0 = <&auart0_pins_a>;
+				fsl,uart-has-rtscts;
+				status = "okay";
+			};
+
 			usbphy0: usbphy at 8007c000 {
 				status = "okay";
 			};
-- 
2.0.5

[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[Lothar Waßmann]

Hi,

Gwenhael Goavec-Merou wrote:
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> index 68405c3..a052d3e 100644
> --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> @@ -110,6 +110,13 @@
>  					};
>  				};
>  			};
> +
> +			can0: can at 80032000 {
>
Did you compile-test this? It should produce a build error, since
the label can0 already exists in imx28.dtsi.
You should use:
|&can0 {
|				pinctrl-names = "default";
|				pinctrl-0 = <&can0_pins_a>;
|				xceiver-supply = <&reg_can0_vcc>;
|				status = "okay";
|};

> @@ -176,6 +183,14 @@
>  			gpio = <&gpio1 23 1>;
s/ 1/ GPIO_ACTIVE_LOW/ ?


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[gwenhael.goavec]

Hi,

On Fri, 13 Feb 2015 15:53:58 +0100
Lothar Wa?mann <LW@KARO-electronics.de> wrote:

> Hi,
> 
> Gwenhael Goavec-Merou wrote:
> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> > Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
> > ---
> >  arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> > index 68405c3..a052d3e 100644
> > --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> > +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> > @@ -110,6 +110,13 @@
> >  					};
> >  				};
> >  			};
> > +
> > +			can0: can at 80032000 {
> >
> Did you compile-test this? It should produce a build error, since
> the label can0 already exists in imx28.dtsi.
Compile fine and without error. It's the same thing for all labels in 
this dts file.
> You should use:
> |&can0 {
> |				pinctrl-names = "default";
> |				pinctrl-0 = <&can0_pins_a>;
> |				xceiver-supply = <&reg_can0_vcc>;
> |				status = "okay";
> |};
> 
> > @@ -176,6 +183,14 @@
> >  			gpio = <&gpio1 23 1>;
> s/ 1/ GPIO_ACTIVE_LOW/ ?
> 
This change is out of the context to this patch. This change will be done in
other patch.
> 
> Lothar Wa?mann
> -- 
Gwenhael Goavec-Merou

[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[Lothar Waßmann]

Hi,

gwenhael.goavec wrote:
> Hi,
> 
> On Fri, 13 Feb 2015 15:53:58 +0100
> Lothar Wa?mann <LW@KARO-electronics.de> wrote:
> 
> > Hi,
> > 
> > Gwenhael Goavec-Merou wrote:
> > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> > > Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
> > > ---
> > >  arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
> > >  1 file changed, 15 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> > > index 68405c3..a052d3e 100644
> > > --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> > > +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> > > @@ -110,6 +110,13 @@
> > >  					};
> > >  				};
> > >  			};
> > > +
> > > +			can0: can at 80032000 {
> > >
> > Did you compile-test this? It should produce a build error, since
> > the label can0 already exists in imx28.dtsi.
> Compile fine and without error. It's the same thing for all labels in 
> this dts file.
> > You should use:
> > |&can0 {
> > |				pinctrl-names = "default";
> > |				pinctrl-0 = <&can0_pins_a>;
> > |				xceiver-supply = <&reg_can0_vcc>;
> > |				status = "okay";
> > |};
>
I also noticed now, that defining a label for the same node twice is OK
with the dtc-compiler.
But you could simplify your dts files and make them more readable by
referencing the existing labels (like all the other platforms do)
rather than reproducing the whole tree structrure in your files.

Thus instead of:
|	apb at 80000000 {
|		apbh at 80000000 {
|			gpmi-nand at 8000c000 {
[...]
|		};
|
|		apbx at 80040000 {
|			duart: serial at 80074000 {
[...]

you would only have:
|&duart {
	[...]
|};
|
|&gpmi {
|	[...]
|};
in your dts files.
Sorting the labels alphabetically additionally helps readability.


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

[PATCH 4/5] ARM: dts: imx28-apf28dev: add support for can0

[gwenhael.goavec]

Hi,

On Fri, 13 Feb 2015 17:59:36 +0100
Lothar Wa?mann <LW@KARO-electronics.de> wrote:

> Hi,
> 
> gwenhael.goavec wrote:
> > Hi,
> > 
> > On Fri, 13 Feb 2015 15:53:58 +0100
> > Lothar Wa?mann <LW@KARO-electronics.de> wrote:
> > 
> > > Hi,
> > > 
> > > Gwenhael Goavec-Merou wrote:
> > > > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> > > > Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
> > > > ---
> > > >  arch/arm/boot/dts/imx28-apf28dev.dts | 15 +++++++++++++++
> > > >  1 file changed, 15 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> > > > index 68405c3..a052d3e 100644
> > > > --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> > > > +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> > > > @@ -110,6 +110,13 @@
> > > >  					};
> > > >  				};
> > > >  			};
> > > > +
> > > > +			can0: can at 80032000 {
> > > >
> > > Did you compile-test this? It should produce a build error, since
> > > the label can0 already exists in imx28.dtsi.
> > Compile fine and without error. It's the same thing for all labels in 
> > this dts file.
> > > You should use:
> > > |&can0 {
> > > |				pinctrl-names = "default";
> > > |				pinctrl-0 = <&can0_pins_a>;
> > > |				xceiver-supply = <&reg_can0_vcc>;
> > > |				status = "okay";
> > > |};
> >
> I also noticed now, that defining a label for the same node twice is OK
> with the dtc-compiler.
> But you could simplify your dts files and make them more readable by
> referencing the existing labels (like all the other platforms do)
> rather than reproducing the whole tree structrure in your files.
> 
> Thus instead of:
> |	apb at 80000000 {
> |		apbh at 80000000 {
> |			gpmi-nand at 8000c000 {
> [...]
> |		};
> |
> |		apbx at 80040000 {
> |			duart: serial at 80074000 {
> [...]
> 
> you would only have:
> |&duart {
> 	[...]
> |};
> |
> |&gpmi {
> |	[...]
> |};
> in your dts files.
> Sorting the labels alphabetically additionally helps readability.
> 
Yes it's possible but, according to [1], this change does not seem desirable.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/255375.html

Gwenhael Goavec-Merou

[PATCH 1/5] ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

[gwenhael.goavec]

Ping?

Gwen

On Fri, 13 Feb 2015 15:12:01 +0100
Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com> wrote:

> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> index 1f38a05..86e8d81 100644
> --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> @@ -143,7 +143,8 @@
>  	ahb at 80080000 {
>  		usb0: usb at 80080000 {
>  			pinctrl-names = "default";
> -			pinctrl-0 = <&usb0_otg_apf28dev>;
> +			pinctrl-0 = <&usb0_otg_apf28dev
> +					&usb0_id_pins_b>;
>  			vbus-supply = <&reg_usb0_vbus>;
>  			status = "okay";
>  		};
> -- 
> 2.0.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

[PATCH 1/5] ARM: dts: imx28-apf28dev: Add pinctrl for USB OTG ID pin

[Shawn Guo]

On Fri, Feb 13, 2015 at 03:12:01PM +0100, Gwenhael Goavec-Merou wrote:
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus.com>
> Signed-off-by: Sebastien Szymanski <sebastien.szymanski@armadeus.com>

Applied all 5, thanks.

> ---
>  arch/arm/boot/dts/imx28-apf28dev.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> index 1f38a05..86e8d81 100644
> --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> @@ -143,7 +143,8 @@
>  	ahb at 80080000 {
>  		usb0: usb at 80080000 {
>  			pinctrl-names = "default";
> -			pinctrl-0 = <&usb0_otg_apf28dev>;
> +			pinctrl-0 = <&usb0_otg_apf28dev
> +					&usb0_id_pins_b>;
>  			vbus-supply = <&reg_usb0_vbus>;
>  			status = "okay";
>  		};
> -- 
> 2.0.5
>