Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v3] mtd: hisilicon: add device tree node for NAND controller
Date: Fri, 27 Mar 2015 10:35:04 -0700	[thread overview]
Message-ID: <20150327173504.GY32500@ld-irv-0074> (raw)
In-Reply-To: <1427267091-227474-1-git-send-email-wangzhou1@hisilicon.com>

This would go through your arm-soc submaintainer; i.e., Wei Xu

But FWIW...

On Wed, Mar 25, 2015 at 03:04:51PM +0800, Zhou Wang wrote:
> This patch adds dts support for NAND flash controller of Hisilicon Soc Hip04.
> Now it is based on v4.0-rc5
> 
> Changes in v3:
> - Change E-mail address in signed-off-by to "wangzhou1 at hisilicon.com"
> Changes in v2:
> - Base on v3.19-rc1
> - Use nand-ecc-strength, nand-ecc-step-size to replace hisi,nand-ecc-bits
> Changes in v1:
> - Move partition and other board related information into board dts file:
>   hip04-d01.dts
> 
> Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
> ---
>  arch/arm/boot/dts/hip04-d01.dts | 27 +++++++++++++++++++++++++++
>  arch/arm/boot/dts/hip04.dtsi    |  7 +++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hip04-d01.dts b/arch/arm/boot/dts/hip04-d01.dts
> index 40a9e33..ba04dd5 100644
> --- a/arch/arm/boot/dts/hip04-d01.dts
> +++ b/arch/arm/boot/dts/hip04-d01.dts
> @@ -28,5 +28,32 @@
>  		uart0: uart at 4007000 {
>  			status = "ok";
>  		};
> +
> +		nand: nand at 4020000 {
> +			nand-bus-width = <8>;
> +			nand-ecc-mode = "hw";
> +			nand-ecc-strength = <16>;
> +			nand-ecc-step-size = <1024>;
> +
> +			partition at 0 {
> +				label = "nand_text";
> +				reg = <0x00000000 0x00400000>;
> +			};
> +
> +			partition at 00400000 {
> +				label = "nand_monitor";
> +				reg = <0x00400000 0x00400000>;
> +			};
> +
> +			partition at 00800000 {
> +				label = "nand_kernel";
> +				reg = <0x00800000 0x00800000>;
> +			};
> +
> +			partition at 01000000 {
> +				label = "nand_fs";
> +				reg = <0x01000000 0x1f000000>;
> +			};
> +		};
>  	};
>  };
> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
> index 2388145..ac32fce 100644
> --- a/arch/arm/boot/dts/hip04.dtsi
> +++ b/arch/arm/boot/dts/hip04.dtsi
> @@ -269,6 +269,13 @@
>  			interrupts = <0 372 4>;
>  		};
>  
> +		nand: nand at 4020000 {
> +			compatible = "hisilicon,504-nfc";
> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
> +			interrupts = <0 379 4>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +		};

Seems reasonable and matches the binding we already accepted, so:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

>  	};
>  
>  	etb at 0,e3c42000 {
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2015-03-27 17:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25  7:04 [RESEND PATCH v3] mtd: hisilicon: add device tree node for NAND controller Zhou Wang
2015-03-26  2:13 ` Haojian Zhuang
2015-03-26  4:53   ` Zhou Wang
2015-03-27 17:35 ` Brian Norris [this message]
2015-03-28  7:00   ` Zhou Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327173504.GY32500@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox