From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] arm64/ftrace: Define a new arm64 trace clock source based on cntpct_el0 register.
Date: Wed, 21 Oct 2015 11:52:43 -0400 [thread overview]
Message-ID: <20151021115243.0d6d603f@gandalf.local.home> (raw)
In-Reply-To: <CABHD4K_DmujOCEF=2R4ecJ7uH4yZ6QZAqBFFXpbGTh6i_xFqvA@mail.gmail.com>
On Wed, 21 Oct 2015 21:07:04 +0530
Amit Tomer <amittomer25@gmail.com> wrote:
> Thank you for looking into it and providing your comments.
>
>
> >> + [local] global counter x86-tsc arm64-pct
> >
> > You don't need to update this line. You can't have both x86-tsc and
> > arm64-pct at the same time.
>
> Ok, I understand. But is there a nice way to put it, something like
> x86-tsc/arm64-pct/... ?
No, it's just an example. No need to update it.
>
> > Why is this a define and not a static inline?
>
> There is no specific reason to it . I would change it to static inline.
Please do. static inline is preferred over defines. We only use defines
when a static inline wont work for the needed operation.
-- Steve
next prev parent reply other threads:[~2015-10-21 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 12:17 [PATCH RFC] arm64/ftrace: Define a new arm64 trace clock source based on cntpct_el0 register Amit
2015-10-21 13:44 ` Steven Rostedt
2015-10-21 15:37 ` Amit Tomer
2015-10-21 15:52 ` Steven Rostedt [this message]
2015-10-22 15:03 ` Amit Tomer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021115243.0d6d603f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox