public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx25.dtsi: change the clock information for usb
@ 2016-02-19  9:35 Peter Chen
  2016-02-19  9:35 ` [PATCH 2/2] ARM: dts: imx35.dtsi: " Peter Chen
  2016-02-28  7:57 ` [PATCH 1/2] ARM: dts: imx25.dtsi: " Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Chen @ 2016-02-19  9:35 UTC (permalink / raw)
  To: linux-arm-kernel

From: Peter Chen <peter.chen@freescale.com>

For imx25, it needs three clocks to let the controller work,
the old code is wrong, and usbmisc has not included clock
handling code any more.

Acked-by: Shawn Guo <shawnguo@kernel.org>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
Shawn, the related changes for i.mx27 has already been in mainline.
Unlike the changes for i.mx27, it is not a bug fix for i.mx25 and i.mx35.

 arch/arm/boot/dts/imx25.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index cde329e..d82e8d8 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -497,7 +497,8 @@
 				compatible = "fsl,imx25-usb", "fsl,imx27-usb";
 				reg = <0x53ff4000 0x0200>;
 				interrupts = <37>;
-				clocks = <&clks 70>;
+				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 0>;
 				fsl,usbphy = <&usbphy0>;
 				status = "disabled";
@@ -507,7 +508,8 @@
 				compatible = "fsl,imx25-usb", "fsl,imx27-usb";
 				reg = <0x53ff4400 0x0200>;
 				interrupts = <35>;
-				clocks = <&clks 70>;
+				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 1>;
 				fsl,usbphy = <&usbphy1>;
 				status = "disabled";
@@ -516,8 +518,6 @@
 			usbmisc: usbmisc at 53ff4600 {
 				#index-cells = <1>;
 				compatible = "fsl,imx25-usbmisc";
-				clocks = <&clks 9>, <&clks 70>, <&clks 8>;
-				clock-names = "ipg", "ahb", "per";
 				reg = <0x53ff4600 0x00f>;
 			};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: imx35.dtsi: change the clock information for usb
  2016-02-19  9:35 [PATCH 1/2] ARM: dts: imx25.dtsi: change the clock information for usb Peter Chen
@ 2016-02-19  9:35 ` Peter Chen
  2016-02-28  7:57 ` [PATCH 1/2] ARM: dts: imx25.dtsi: " Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Chen @ 2016-02-19  9:35 UTC (permalink / raw)
  To: linux-arm-kernel

From: Peter Chen <peter.chen@freescale.com>

For imx35, it needs three clocks to let the controller work,
the old code is wrong, and the usbmisc does not include
clock handling code any more.

Signed-off-by: Peter Chen <peter.chen@freescale.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
---
 arch/arm/boot/dts/imx35.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
index ed3dc33..14e1320 100644
--- a/arch/arm/boot/dts/imx35.dtsi
+++ b/arch/arm/boot/dts/imx35.dtsi
@@ -305,7 +305,8 @@
 				compatible = "fsl,imx35-usb", "fsl,imx27-usb";
 				reg = <0x53ff4000 0x0200>;
 				interrupts = <37>;
-				clocks = <&clks 73>;
+				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 0>;
 				fsl,usbphy = <&usbphy0>;
 				status = "disabled";
@@ -315,7 +316,8 @@
 				compatible = "fsl,imx35-usb", "fsl,imx27-usb";
 				reg = <0x53ff4400 0x0200>;
 				interrupts = <35>;
-				clocks = <&clks 73>;
+				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
+				clock-names = "ipg", "ahb", "per";
 				fsl,usbmisc = <&usbmisc 1>;
 				fsl,usbphy = <&usbphy1>;
 				dr_mode = "host";
@@ -325,8 +327,6 @@
 			usbmisc: usbmisc at 53ff4600 {
 				#index-cells = <1>;
 				compatible = "fsl,imx35-usbmisc";
-				clocks = <&clks 9>, <&clks 73>, <&clks 28>;
-				clock-names = "ipg", "ahb", "per";
 				reg = <0x53ff4600 0x00f>;
 			};
 		};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: dts: imx25.dtsi: change the clock information for usb
  2016-02-19  9:35 [PATCH 1/2] ARM: dts: imx25.dtsi: change the clock information for usb Peter Chen
  2016-02-19  9:35 ` [PATCH 2/2] ARM: dts: imx35.dtsi: " Peter Chen
@ 2016-02-28  7:57 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2016-02-28  7:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Feb 19, 2016 at 05:35:03PM +0800, Peter Chen wrote:
> From: Peter Chen <peter.chen@freescale.com>
> 
> For imx25, it needs three clocks to let the controller work,
> the old code is wrong, and usbmisc has not included clock
> handling code any more.
> 
> Acked-by: Shawn Guo <shawnguo@kernel.org>
> Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>

Applied both, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-28  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19  9:35 [PATCH 1/2] ARM: dts: imx25.dtsi: change the clock information for usb Peter Chen
2016-02-19  9:35 ` [PATCH 2/2] ARM: dts: imx35.dtsi: " Peter Chen
2016-02-28  7:57 ` [PATCH 1/2] ARM: dts: imx25.dtsi: " Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox