From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Enable interrupts before calling schedule()
Date: Mon, 23 May 2016 14:44:02 +0200 [thread overview]
Message-ID: <20160523124402.GJ15728@worktop.ger.corp.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1605201740320.3639@nanos>
On Fri, May 20, 2016 at 05:42:17PM +0200, Thomas Gleixner wrote:
> do_work_pending() calls schedule() with interrupts disabled, which is just
> wrong. Fix it.
Thomas; lockdep cannot currently catch this. It doesn't do IRQ state
validation other than ensuring the state matches with the hardware.
So things like:
local_irq_disable();
local_irq_disable();
local_irq_save();
local_irq_enable();
(and 'obviously' suspect sequence of IRQ events)
Are _fine_ by it. The only time it will yell is if flipping IRQ state
ends up marking an actual held lock with ENABLED_HARDIRQ while it
already had USED_IN_HARDIRQ.
prev parent reply other threads:[~2016-05-23 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 15:42 [PATCH] arm: Enable interrupts before calling schedule() Thomas Gleixner
2016-05-23 10:54 ` Catalin Marinas
2016-05-23 11:09 ` Russell King - ARM Linux
2016-05-23 12:44 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523124402.GJ15728@worktop.ger.corp.intel.com \
--to=peterz@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox