* [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
@ 2016-07-13 16:39 Chris Wilson
2016-07-13 17:56 ` Sean Paul
2016-07-13 18:23 ` Sean Paul
0 siblings, 2 replies; 5+ messages in thread
From: Chris Wilson @ 2016-07-13 16:39 UTC (permalink / raw)
To: linux-arm-kernel
drm_connector_unregister_all() is automatically called by
drm_dev_unregister() and so the manual call can be dropped.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: dri-devel at lists.freedesktop.org
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 4dc543e1db10..7092daaf6c43 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -185,7 +185,6 @@ static void sun4i_drv_unbind(struct device *dev)
{
struct drm_device *drm = dev_get_drvdata(dev);
- drm_connector_unregister_all(drm);
drm_dev_unregister(drm);
drm_kms_helper_poll_fini(drm);
sun4i_framebuffer_free(drm);
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
2016-07-13 16:39 [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all() Chris Wilson
@ 2016-07-13 17:56 ` Sean Paul
2016-07-13 18:05 ` Chris Wilson
2016-07-13 18:23 ` Sean Paul
1 sibling, 1 reply; 5+ messages in thread
From: Sean Paul @ 2016-07-13 17:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 13, 2016 at 9:39 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> drm_connector_unregister_all() is automatically called by
> drm_dev_unregister() and so the manual call can be dropped.
>
The documentation for drm_connector_unregister_all says "Drivers
should call this [...] right before calling drm_dev_unregister()". If
this is no longer true, could you update that comment as part of this
series?
Sean
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/gpu/drm/sun4i/sun4i_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> index 4dc543e1db10..7092daaf6c43 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> @@ -185,7 +185,6 @@ static void sun4i_drv_unbind(struct device *dev)
> {
> struct drm_device *drm = dev_get_drvdata(dev);
>
> - drm_connector_unregister_all(drm);
> drm_dev_unregister(drm);
> drm_kms_helper_poll_fini(drm);
> sun4i_framebuffer_free(drm);
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
2016-07-13 17:56 ` Sean Paul
@ 2016-07-13 18:05 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-07-13 18:05 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 13, 2016 at 10:56:58AM -0700, Sean Paul wrote:
> On Wed, Jul 13, 2016 at 9:39 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > drm_connector_unregister_all() is automatically called by
> > drm_dev_unregister() and so the manual call can be dropped.
> >
>
> The documentation for drm_connector_unregister_all says "Drivers
> should call this [...] right before calling drm_dev_unregister()". If
> this is no longer true, could you update that comment as part of this
> series?
That is done. (The comment block is entirely removed so that we don't
distract authors with superfluous functions that they cannot call
themselves, i.e. Daniel wanted only the DRM interfaces documented.)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
2016-07-13 16:39 [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all() Chris Wilson
2016-07-13 17:56 ` Sean Paul
@ 2016-07-13 18:23 ` Sean Paul
2016-07-19 8:05 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Sean Paul @ 2016-07-13 18:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 13, 2016 at 9:39 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> drm_connector_unregister_all() is automatically called by
> drm_dev_unregister() and so the manual call can be dropped.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: dri-devel at lists.freedesktop.org
> Cc: linux-arm-kernel at lists.infradead.org
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> ---
> drivers/gpu/drm/sun4i/sun4i_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> index 4dc543e1db10..7092daaf6c43 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> @@ -185,7 +185,6 @@ static void sun4i_drv_unbind(struct device *dev)
> {
> struct drm_device *drm = dev_get_drvdata(dev);
>
> - drm_connector_unregister_all(drm);
> drm_dev_unregister(drm);
> drm_kms_helper_poll_fini(drm);
> sun4i_framebuffer_free(drm);
> --
> 2.8.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all()
2016-07-13 18:23 ` Sean Paul
@ 2016-07-19 8:05 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2016-07-19 8:05 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 13, 2016 at 11:23:29AM -0700, Sean Paul wrote:
> On Wed, Jul 13, 2016 at 9:39 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > drm_connector_unregister_all() is automatically called by
> > drm_dev_unregister() and so the manual call can be dropped.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Chen-Yu Tsai <wens@csie.org>
> > Cc: dri-devel at lists.freedesktop.org
> > Cc: linux-arm-kernel at lists.infradead.org
>
>
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>
Done a backmerge and applied these two, thanks.
-Daniel
>
> > ---
> > drivers/gpu/drm/sun4i/sun4i_drv.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > index 4dc543e1db10..7092daaf6c43 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_drv.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
> > @@ -185,7 +185,6 @@ static void sun4i_drv_unbind(struct device *dev)
> > {
> > struct drm_device *drm = dev_get_drvdata(dev);
> >
> > - drm_connector_unregister_all(drm);
> > drm_dev_unregister(drm);
> > drm_kms_helper_poll_fini(drm);
> > sun4i_framebuffer_free(drm);
> > --
> > 2.8.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-19 8:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13 16:39 [PATCH 1/2] drm/sun4i: Remove redundant call to drm_connector_unregister_all() Chris Wilson
2016-07-13 17:56 ` Sean Paul
2016-07-13 18:05 ` Chris Wilson
2016-07-13 18:23 ` Sean Paul
2016-07-19 8:05 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox