* [PATCH 0/3] iMX7 PWM polarity control
@ 2016-09-19 14:23 Bhuvanchandra DV
2016-09-19 14:23 ` [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for " Bhuvanchandra DV
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bhuvanchandra DV @ 2016-09-19 14:23 UTC (permalink / raw)
To: linux-arm-kernel
This patchset depends on this patchset[1] and this patch[2] which adds support
for polarity control in imx-pwm driver.
- Use pwm polarity control on iMX7 based modules.
- Enable polarity control on Toradex Colibri iMX7D/S module.
- Add BL_ON GPIO control for Toradex Colibri iMX7D/S module.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/294027.html
[2] https://www.spinics.net/lists/arm-kernel/msg530818.html
Bhuvanchandra DV (3):
arm: dts: imx7: Update #pwm-cells for PWM polarity control
arm: dts: imx7-colibri: Use pwm polarity control
arm: dts: imx7-colibri: Use enable-gpios for BL_ON
Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +++---
arch/arm/boot/dts/imx7-colibri.dtsi | 12 ++++++++++--
arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
3 files changed, 17 insertions(+), 9 deletions(-)
--
2.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for PWM polarity control 2016-09-19 14:23 [PATCH 0/3] iMX7 PWM polarity control Bhuvanchandra DV @ 2016-09-19 14:23 ` Bhuvanchandra DV 2016-09-23 17:52 ` Rob Herring 2016-09-19 14:23 ` [PATCH 2/3] arm: dts: imx7-colibri: Use pwm " Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 3/3] arm: dts: imx7-colibri: Use enable-gpios for BL_ON Bhuvanchandra DV 2 siblings, 1 reply; 6+ messages in thread From: Bhuvanchandra DV @ 2016-09-19 14:23 UTC (permalink / raw) To: linux-arm-kernel Update #pwm-cells to 3 in order to support PWM signal polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +++--- arch/arm/boot/dts/imx7s.dtsi | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-pwm.txt index e00c2e9..c61bdf8 100644 --- a/Documentation/devicetree/bindings/pwm/imx-pwm.txt +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.txt @@ -6,8 +6,8 @@ Required properties: - "fsl,imx1-pwm" for PWM compatible with the one integrated on i.MX1 - "fsl,imx27-pwm" for PWM compatible with the one integrated on i.MX27 - reg: physical base address and length of the controller's registers -- #pwm-cells: should be 2. See pwm.txt in this directory for a description of - the cells format. +- #pwm-cells: 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.txt + in this directory for a description of the cells format. - clocks : Clock specifiers for both ipg and per clocks. - clock-names : Clock names should include both "ipg" and "per" See the clock consumer binding, @@ -17,7 +17,7 @@ See the clock consumer binding, Example: pwm1: pwm at 53fb4000 { - #pwm-cells = <2>; + #pwm-cells = <3>; compatible = "fsl,imx53-pwm", "fsl,imx27-pwm"; reg = <0x53fb4000 0x4000>; clocks = <&clks IMX5_CLK_PWM1_IPG_GATE>, diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 0d7d5ac..8d1d471 100644 --- a/arch/arm/boot/dts/imx7s.dtsi +++ b/arch/arm/boot/dts/imx7s.dtsi @@ -601,7 +601,7 @@ clocks = <&clks IMX7D_PWM1_ROOT_CLK>, <&clks IMX7D_PWM1_ROOT_CLK>; clock-names = "ipg", "per"; - #pwm-cells = <2>; + #pwm-cells = <3>; status = "disabled"; }; @@ -612,7 +612,7 @@ clocks = <&clks IMX7D_PWM2_ROOT_CLK>, <&clks IMX7D_PWM2_ROOT_CLK>; clock-names = "ipg", "per"; - #pwm-cells = <2>; + #pwm-cells = <3>; status = "disabled"; }; @@ -623,7 +623,7 @@ clocks = <&clks IMX7D_PWM3_ROOT_CLK>, <&clks IMX7D_PWM3_ROOT_CLK>; clock-names = "ipg", "per"; - #pwm-cells = <2>; + #pwm-cells = <3>; status = "disabled"; }; @@ -634,7 +634,7 @@ clocks = <&clks IMX7D_PWM4_ROOT_CLK>, <&clks IMX7D_PWM4_ROOT_CLK>; clock-names = "ipg", "per"; - #pwm-cells = <2>; + #pwm-cells = <3>; status = "disabled"; }; -- 2.9.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for PWM polarity control 2016-09-19 14:23 ` [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for " Bhuvanchandra DV @ 2016-09-23 17:52 ` Rob Herring 2016-09-27 14:24 ` Bhuvanchandra DV 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2016-09-23 17:52 UTC (permalink / raw) To: linux-arm-kernel On Mon, Sep 19, 2016 at 07:53:45PM +0530, Bhuvanchandra DV wrote: > Update #pwm-cells to 3 in order to support PWM signal polarity control. > > Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > --- > Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +++--- > arch/arm/boot/dts/imx7s.dtsi | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) The driver will still work with old DTs, right? If so, Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for PWM polarity control 2016-09-23 17:52 ` Rob Herring @ 2016-09-27 14:24 ` Bhuvanchandra DV 0 siblings, 0 replies; 6+ messages in thread From: Bhuvanchandra DV @ 2016-09-27 14:24 UTC (permalink / raw) To: linux-arm-kernel On 09/23/16 23:22, Rob Herring wrote: > On Mon, Sep 19, 2016 at 07:53:45PM +0530, Bhuvanchandra DV wrote: >> Update #pwm-cells to 3 in order to support PWM signal polarity control. >> >> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> --- >> Documentation/devicetree/bindings/pwm/imx-pwm.txt | 6 +++--- >> arch/arm/boot/dts/imx7s.dtsi | 8 ++++---- >> 2 files changed, 7 insertions(+), 7 deletions(-) > The driver will still work with old DTs, right? If so, This patchset actually depends on the v6 patchset[1] from Lothar. Some how that patchset got stalled in ML. I will re-spin the v6 patchset with the suggestions/changes from Lukasz in this patch[2] after testing. [1]http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/294027.html [2]https://www.spinics.net/lists/arm-kernel/msg530818.html > > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] arm: dts: imx7-colibri: Use pwm polarity control 2016-09-19 14:23 [PATCH 0/3] iMX7 PWM polarity control Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for " Bhuvanchandra DV @ 2016-09-19 14:23 ` Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 3/3] arm: dts: imx7-colibri: Use enable-gpios for BL_ON Bhuvanchandra DV 2 siblings, 0 replies; 6+ messages in thread From: Bhuvanchandra DV @ 2016-09-19 14:23 UTC (permalink / raw) To: linux-arm-kernel Configure PWM polarity control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index a9cc657..2af5e3e 100644 --- a/arch/arm/boot/dts/imx7-colibri.dtsi +++ b/arch/arm/boot/dts/imx7-colibri.dtsi @@ -43,7 +43,7 @@ / { bl: backlight { compatible = "pwm-backlight"; - pwms = <&pwm1 0 5000000>; + pwms = <&pwm1 0 5000000 0>; }; reg_module_3v3: regulator-module-3v3 { -- 2.9.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] arm: dts: imx7-colibri: Use enable-gpios for BL_ON 2016-09-19 14:23 [PATCH 0/3] iMX7 PWM polarity control Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for " Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 2/3] arm: dts: imx7-colibri: Use pwm " Bhuvanchandra DV @ 2016-09-19 14:23 ` Bhuvanchandra DV 2 siblings, 0 replies; 6+ messages in thread From: Bhuvanchandra DV @ 2016-09-19 14:23 UTC (permalink / raw) To: linux-arm-kernel Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> --- arch/arm/boot/dts/imx7-colibri.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi index 2af5e3e..ce5edb5 100644 --- a/arch/arm/boot/dts/imx7-colibri.dtsi +++ b/arch/arm/boot/dts/imx7-colibri.dtsi @@ -43,7 +43,10 @@ / { bl: backlight { compatible = "pwm-backlight"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_gpio_bl_on>; pwms = <&pwm1 0 5000000 0>; + enable-gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; }; reg_module_3v3: regulator-module-3v3 { @@ -356,7 +359,6 @@ fsl,pins = < MX7D_PAD_ECSPI2_SS0__GPIO4_IO23 0x14 /* SODIMM 65 */ MX7D_PAD_SD1_CD_B__GPIO5_IO0 0x14 /* SODIMM 69 */ - MX7D_PAD_SD1_WP__GPIO5_IO1 0x14 /* SODIMM 71 */ MX7D_PAD_I2C4_SDA__GPIO4_IO15 0x14 /* SODIMM 75 */ MX7D_PAD_ECSPI1_MISO__GPIO4_IO18 0x14 /* SODIMM 79 */ MX7D_PAD_I2C3_SCL__GPIO4_IO12 0x14 /* SODIMM 81 */ @@ -388,6 +390,12 @@ >; }; + pinctrl_gpio_bl_on: gpio-bl-on { + fsl,pins = < + MX7D_PAD_SD1_WP__GPIO5_IO1 0x14 + >; + }; + pinctrl_i2c1_int: i2c1-int-grp { /* PMIC / TOUCH */ fsl,pins = < MX7D_PAD_GPIO1_IO13__GPIO1_IO13 0x79 -- 2.9.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-27 14:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-19 14:23 [PATCH 0/3] iMX7 PWM polarity control Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 1/3] arm: dts: imx7: Update #pwm-cells for " Bhuvanchandra DV 2016-09-23 17:52 ` Rob Herring 2016-09-27 14:24 ` Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 2/3] arm: dts: imx7-colibri: Use pwm " Bhuvanchandra DV 2016-09-19 14:23 ` [PATCH 3/3] arm: dts: imx7-colibri: Use enable-gpios for BL_ON Bhuvanchandra DV
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox