* [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards
@ 2016-10-27 17:47 Javier Martinez Canillas
2016-10-27 17:47 ` [PATCH 2/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos5 boards Javier Martinez Canillas
2016-10-28 13:41 ` [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-27 17:47 UTC (permalink / raw)
To: linux-arm-kernel
Using the PWM_POLARITY_INVERTED macro instead of the hardcoded number
0 makes the DTS easier to read.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 ++-
arch/arm/boot/dts/exynos4412-trats2.dts | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index 99634c54dca9..480a80624b77 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -12,6 +12,7 @@
*/
/dts-v1/;
+#include <dt-bindings/pwm/pwm.h>
#include "exynos4412-odroid-common.dtsi"
/ {
@@ -35,7 +36,7 @@
fan0: pwm-fan {
compatible = "pwm-fan";
- pwms = <&pwm 0 10000 0>;
+ pwms = <&pwm 0 10000 PWM_POLARITY_INVERTED>;
cooling-min-state = <0>;
cooling-max-state = <3>;
#cooling-cells = <2>;
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 41ecd6d465a7..63ad30507d4f 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -18,6 +18,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/clock/maxim,max77686.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
model = "Samsung Trats 2 based on Exynos4412";
@@ -164,7 +165,7 @@
max77693_haptic {
compatible = "maxim,max77693-haptic";
haptic-supply = <&ldo26_reg>;
- pwms = <&pwm 0 38022 0>;
+ pwms = <&pwm 0 38022 PWM_POLARITY_INVERTED>;
};
charger {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos5 boards
2016-10-27 17:47 [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Javier Martinez Canillas
@ 2016-10-27 17:47 ` Javier Martinez Canillas
2016-10-28 13:41 ` [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-27 17:47 UTC (permalink / raw)
To: linux-arm-kernel
Using the PWM_POLARITY_INVERTED macro instead of the hardcoded number
0 makes the DTS easier to read.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5410-odroidxu.dts | 2 +-
arch/arm/boot/dts/exynos5420-peach-pit.dts | 3 ++-
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 3 ++-
arch/arm/boot/dts/exynos5422-odroidxu4.dts | 2 +-
arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 5 +++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 ++-
7 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
index 8f3a80430748..4df36f7263fd 100644
--- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
@@ -12,6 +12,7 @@
#include <dt-bindings/clock/maxim,max77686.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/pwm/pwm.h>
#include "exynos5250.dtsi"
/ {
@@ -198,7 +199,7 @@
backlight: backlight {
compatible = "pwm-backlight";
- pwms = <&pwm 0 1000000 0>;
+ pwms = <&pwm 0 1000000 PWM_POLARITY_INVERTED>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
enable-gpios = <&gpx3 0 GPIO_ACTIVE_HIGH>;
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index c4de1353e5df..56adaac1f4ec 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -40,7 +40,7 @@
fan0: pwm-fan {
compatible = "pwm-fan";
- pwms = <&pwm 0 20972 0>;
+ pwms = <&pwm 0 20972 PWM_POLARITY_INVERTED>;
cooling-min-state = <0>;
cooling-max-state = <3>;
#cooling-cells = <2>;
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 1f964ec35c5e..d83a12bb7112 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -13,6 +13,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/clock/maxim,max77802.h>
+#include <dt-bindings/pwm/pwm.h>
#include <dt-bindings/regulator/maxim,max77802.h>
#include "exynos5420.dtsi"
#include "exynos5420-cpus.dtsi"
@@ -37,7 +38,7 @@
backlight: backlight {
compatible = "pwm-backlight";
- pwms = <&pwm 0 1000000 0>;
+ pwms = <&pwm 0 1000000 PWM_POLARITY_INVERTED>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
power-supply = <&tps65090_fet1>;
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 246d298557f5..791af504a79f 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -15,6 +15,7 @@
#include <dt-bindings/clock/samsung,s2mps11.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>
#include <dt-bindings/sound/samsung-i2s.h>
#include "exynos5800.dtsi"
#include "exynos5422-cpus.dtsi"
@@ -51,7 +52,7 @@
fan0: pwm-fan {
compatible = "pwm-fan";
- pwms = <&pwm 0 20972 0>;
+ pwms = <&pwm 0 20972 PWM_POLARITY_INVERTED>;
cooling-min-state = <0>;
cooling-max-state = <3>;
#cooling-cells = <2>;
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
index 2faf88627a48..93ac1d201f16 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts
@@ -24,7 +24,7 @@
blueled {
label = "blue:heartbeat";
- pwms = <&pwm 2 2000000 0>;
+ pwms = <&pwm 2 2000000 PWM_POLARITY_INVERTED>;
pwm-names = "pwm2";
max_brightness = <255>;
linux,default-trigger = "heartbeat";
diff --git a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
index 0ed30206625c..1e3d65d34167 100644
--- a/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
+++ b/arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi
@@ -12,6 +12,7 @@
*/
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
pwmleds {
@@ -19,7 +20,7 @@
greenled {
label = "green:mmc0";
- pwms = <&pwm 1 2000000 0>;
+ pwms = <&pwm 1 2000000 PWM_POLARITY_INVERTED>;
pwm-names = "pwm1";
/*
* Green LED is much brighter than the others
@@ -31,7 +32,7 @@
blueled {
label = "blue:heartbeat";
- pwms = <&pwm 2 2000000 0>;
+ pwms = <&pwm 2 2000000 PWM_POLARITY_INVERTED>;
pwm-names = "pwm2";
max_brightness = <255>;
linux,default-trigger = "heartbeat";
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f9ff7f07ae0c..b1bf73f51e9c 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -13,6 +13,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/clock/maxim,max77802.h>
+#include <dt-bindings/pwm/pwm.h>
#include <dt-bindings/regulator/maxim,max77802.h>
#include "exynos5800.dtsi"
#include "exynos5420-cpus.dtsi"
@@ -35,7 +36,7 @@
backlight: backlight {
compatible = "pwm-backlight";
- pwms = <&pwm 0 1000000 0>;
+ pwms = <&pwm 0 1000000 PWM_POLARITY_INVERTED>;
brightness-levels = <0 100 500 1000 1500 2000 2500 2800>;
default-brightness-level = <7>;
enable-gpios = <&gpx2 2 GPIO_ACTIVE_HIGH>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards
2016-10-27 17:47 [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Javier Martinez Canillas
2016-10-27 17:47 ` [PATCH 2/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos5 boards Javier Martinez Canillas
@ 2016-10-28 13:41 ` Krzysztof Kozlowski
2016-10-28 13:49 ` Javier Martinez Canillas
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-10-28 13:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 27, 2016 at 02:47:17PM -0300, Javier Martinez Canillas wrote:
> Using the PWM_POLARITY_INVERTED macro instead of the hardcoded number
> 0 makes the DTS easier to read.
Eeee.... PWM_POLARITY_INVERTED = 1 << 0 = 1.
And you are replacing 0 with 1. Hm? This is not described@all in
commit message...
Best regards,
Krzysztof
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 ++-
> arch/arm/boot/dts/exynos4412-trats2.dts | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> index 99634c54dca9..480a80624b77 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> @@ -12,6 +12,7 @@
> */
>
> /dts-v1/;
> +#include <dt-bindings/pwm/pwm.h>
> #include "exynos4412-odroid-common.dtsi"
>
> / {
> @@ -35,7 +36,7 @@
>
> fan0: pwm-fan {
> compatible = "pwm-fan";
> - pwms = <&pwm 0 10000 0>;
> + pwms = <&pwm 0 10000 PWM_POLARITY_INVERTED>;
> cooling-min-state = <0>;
> cooling-max-state = <3>;
> #cooling-cells = <2>;
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 41ecd6d465a7..63ad30507d4f 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -18,6 +18,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/maxim,max77686.h>
> +#include <dt-bindings/pwm/pwm.h>
>
> / {
> model = "Samsung Trats 2 based on Exynos4412";
> @@ -164,7 +165,7 @@
> max77693_haptic {
> compatible = "maxim,max77693-haptic";
> haptic-supply = <&ldo26_reg>;
> - pwms = <&pwm 0 38022 0>;
> + pwms = <&pwm 0 38022 PWM_POLARITY_INVERTED>;
> };
>
> charger {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards
2016-10-28 13:41 ` [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Krzysztof Kozlowski
@ 2016-10-28 13:49 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-28 13:49 UTC (permalink / raw)
To: linux-arm-kernel
Hello Krzysztof,
On 10/28/2016 10:41 AM, Krzysztof Kozlowski wrote:
> On Thu, Oct 27, 2016 at 02:47:17PM -0300, Javier Martinez Canillas wrote:
>> Using the PWM_POLARITY_INVERTED macro instead of the hardcoded number
>> 0 makes the DTS easier to read.
>
>
> Eeee.... PWM_POLARITY_INVERTED = 1 << 0 = 1.
>
> And you are replacing 0 with 1. Hm? This is not described at all in
> commit message...
>
> Best regards,
> Krzysztof
>
Damn! I don't know how I misread the DTS macro as 0, and didn't find issues
when testing the patches on an Exynos5800 Peach Pi.
I should had run scripts/dtc/dtx_diff to notice that the DTB changed, I'm
so sorry about that...
Please discard the patches.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-28 13:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-27 17:47 [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Javier Martinez Canillas
2016-10-27 17:47 ` [PATCH 2/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos5 boards Javier Martinez Canillas
2016-10-28 13:41 ` [PATCH 1/2] ARM: dts: exynos: Use macro for PWM signal polarity in Exynos4 boards Krzysztof Kozlowski
2016-10-28 13:49 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox