[PATCH 2/2] arm: dts: sun8i: reuse the uart1 node of iNet D978 rev2 board

[PATCH 2/2] arm: dts: sun8i: reuse the uart1 node of iNet D978 rev2 board

[Maxime Ripard]

On Mon, Dec 05, 2016 at 05:03:35PM +0800, Icenowy Zheng wrote:
> 
> 2016?12?5? 16:50? Maxime Ripard <maxime.ripard@free-electrons.com>???
> >
> > On Fri, Dec 02, 2016 at 11:19:13PM +0800, Icenowy Zheng wrote: 
> > > As a uart1 node is added into sun8i-reference-design-tablet.dtsi, simply 
> > > use it in iNet D978 rev2 device tree. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> 
> >
> > I'd like to see more consolidation before that change is needed. If we 
> > find more boards using that, it will make sense, but for a single 
> > board it's not worth it. 
> 
> At least 2~3 Q8 A33 tablets in #linux-sunxi are found to have
> rtl8703as, which contains UART bluetooth. (including mine)

Still, I'm not fond of creating a default on such a low count sample
of (out-of-tree) DTs. Support and enable the bluetooth on more boards,
and then consolidate.

> In fact, what I want to do is to get the node ready-to-be-okay in Q8
> dts, so it can be enabled by either u-boot command or (theortically)
> Hans de Goede's q8-hardwaremgr, just like what is done at
> touchscreen node.

If your plan is to enable all the combinations possible accross the Q8
tablets and let the bootloader/user figure it all out, then it's not
going to happen, sorry.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161209/1271c094/attachment.sig>

[PATCH 1/2] arm: dts: sun8i: add uart1 node to reference design tablet

[Icenowy Zheng]

In the A23/A33 tablet reference design, the UART1 at PG is used to
connect to the UART-connected bluetooth.

Add a disabled uart1 node for it in the reference design tablet dtsi,
contains the pinctrl info.

If a tablet uses the UART bluetooth, simply set the status of this node
to "okay".

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi b/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
index 08cd001..2d9cf0d 100644
--- a/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
+++ b/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
@@ -46,6 +46,7 @@
 / {
 	aliases {
 		serial0 = &r_uart;
+		serial1 = &uart1;
 	};
 
 	backlight: backlight {
@@ -223,6 +224,13 @@
 	vcc-lcd-supply = <&reg_dc1sw>;
 };
 
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins_a>,
+		    <&uart1_pins_cts_rts_a>;
+	status = "disabled";
+};
+
 &usb_otg {
 	dr_mode = "otg";
 	status = "okay";
-- 
2.10.2

[PATCH 2/2] arm: dts: sun8i: reuse the uart1 node of iNet D978 rev2 board

[Icenowy Zheng]

As a uart1 node is added into sun8i-reference-design-tablet.dtsi, simply
use it in iNet D978 rev2 device tree.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
index fb46655..7335461 100644
--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
@@ -49,15 +49,6 @@
 	model = "INet-D978 Rev 02";
 	compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
 
-	aliases {
-		serial0 = &uart1;
-	};
-
-	chosen {
-		/* Delete debug UART as serial0 is the UART for bluetooth */
-		/delete-property/stdout-path;
-	};
-
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
@@ -96,13 +87,6 @@
 	};
 };
 
-&r_uart {
-	status = "disabled";
-};
-
 &uart1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&uart1_pins_a>,
-		    <&uart1_pins_cts_rts_a>;
 	status = "okay";
 };
-- 
2.10.2

[PATCH 2/2] arm: dts: sun8i: reuse the uart1 node of iNet D978 rev2 board

[Maxime Ripard]

On Fri, Dec 02, 2016 at 11:19:13PM +0800, Icenowy Zheng wrote:
> As a uart1 node is added into sun8i-reference-design-tablet.dtsi, simply
> use it in iNet D978 rev2 device tree.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

I'd like to see more consolidation before that change is needed. If we
find more boards using that, it will make sense, but for a single
board it's not worth it.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161205/4aa6d997/attachment.sig>