* [PATCH 0/2] Cosmetic changes for the SPI driver of ARMADA 3700 @ 2016-12-21 10:10 Romain Perier 2016-12-21 10:10 ` [PATCH 1/2] spi: armada-3700: Coding style fixes Romain Perier 2016-12-21 10:10 ` [PATCH 2/2] spi: armada-3700: Replaced raw values for nbits by the SPI macros Romain Perier 0 siblings, 2 replies; 5+ messages in thread From: Romain Perier @ 2016-12-21 10:10 UTC (permalink / raw) To: linux-arm-kernel This set of patches fixes coding style issues reported by checkpatch.pl, then it includes a second patch that replaces raw values by standardized macro constants. Romain Perier (2): spi: armada-3700: Coding style fixes spi: armada-3700: Replaced raw values for nbits by the SPI macros drivers/spi/spi-armada-3700.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] spi: armada-3700: Coding style fixes 2016-12-21 10:10 [PATCH 0/2] Cosmetic changes for the SPI driver of ARMADA 3700 Romain Perier @ 2016-12-21 10:10 ` Romain Perier 2017-01-04 18:37 ` Applied "spi: armada-3700: Coding style fixes" to the spi tree Mark Brown 2016-12-21 10:10 ` [PATCH 2/2] spi: armada-3700: Replaced raw values for nbits by the SPI macros Romain Perier 1 sibling, 1 reply; 5+ messages in thread From: Romain Perier @ 2016-12-21 10:10 UTC (permalink / raw) To: linux-arm-kernel The following warning are reported by checkpatch.pl: CHECK: Alignment should match open parenthesis +static void a3700_spi_transfer_setup(struct spi_device *spi, + struct spi_transfer *xfer) WARNING: Missing a blank line after declarations + u32 data = le32_to_cpu(val); + memcpy(a3700_spi->rx_buf, &data, 4); total: 0 errors, 1 warnings, 1 checks, 923 lines checked Signed-off-by: Romain Perier <romain.perier@free-electrons.com> --- drivers/spi/spi-armada-3700.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index ec5fb01..0bfe5ff 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -420,7 +420,7 @@ static void a3700_spi_fifo_thres_set(struct a3700_spi *a3700_spi, } static void a3700_spi_transfer_setup(struct spi_device *spi, - struct spi_transfer *xfer) + struct spi_transfer *xfer) { struct a3700_spi *a3700_spi; unsigned int byte_len; @@ -561,6 +561,7 @@ static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi) val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG); if (a3700_spi->buf_len >= 4) { u32 data = le32_to_cpu(val); + memcpy(a3700_spi->rx_buf, &data, 4); a3700_spi->buf_len -= 4; -- 2.9.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "spi: armada-3700: Coding style fixes" to the spi tree 2016-12-21 10:10 ` [PATCH 1/2] spi: armada-3700: Coding style fixes Romain Perier @ 2017-01-04 18:37 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2017-01-04 18:37 UTC (permalink / raw) To: linux-arm-kernel The patch spi: armada-3700: Coding style fixes has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 85798e153e6c3834ab2d69ee9d4db7d85f13809d Mon Sep 17 00:00:00 2001 From: Romain Perier <romain.perier@free-electrons.com> Date: Wed, 21 Dec 2016 11:10:29 +0100 Subject: [PATCH] spi: armada-3700: Coding style fixes The following warning are reported by checkpatch.pl: CHECK: Alignment should match open parenthesis +static void a3700_spi_transfer_setup(struct spi_device *spi, + struct spi_transfer *xfer) WARNING: Missing a blank line after declarations + u32 data = le32_to_cpu(val); + memcpy(a3700_spi->rx_buf, &data, 4); total: 0 errors, 1 warnings, 1 checks, 923 lines checked Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/spi-armada-3700.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 9bee56ddff39..0baa69325e78 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -420,7 +420,7 @@ static void a3700_spi_fifo_thres_set(struct a3700_spi *a3700_spi, } static void a3700_spi_transfer_setup(struct spi_device *spi, - struct spi_transfer *xfer) + struct spi_transfer *xfer) { struct a3700_spi *a3700_spi; unsigned int byte_len; @@ -561,6 +561,7 @@ static int a3700_spi_fifo_read(struct a3700_spi *a3700_spi) val = spireg_read(a3700_spi, A3700_SPI_DATA_IN_REG); if (a3700_spi->buf_len >= 4) { u32 data = le32_to_cpu(val); + memcpy(a3700_spi->rx_buf, &data, 4); a3700_spi->buf_len -= 4; -- 2.11.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] spi: armada-3700: Replaced raw values for nbits by the SPI macros 2016-12-21 10:10 [PATCH 0/2] Cosmetic changes for the SPI driver of ARMADA 3700 Romain Perier 2016-12-21 10:10 ` [PATCH 1/2] spi: armada-3700: Coding style fixes Romain Perier @ 2016-12-21 10:10 ` Romain Perier 2017-01-04 18:37 ` Applied "spi: armada-3700: Replaced raw values for nbits by the SPI macros" to the spi tree Mark Brown 1 sibling, 1 reply; 5+ messages in thread From: Romain Perier @ 2016-12-21 10:10 UTC (permalink / raw) To: linux-arm-kernel Currently, function a3700_spi_pin_mode_set() configures the SPI transfer mode according to the value passed as second argument. This value is detected using the raw values from a switch case. This commit replaces these raw values by the corresponding macro constants in linux/spi/spi.h Signed-off-by: Romain Perier <romain.perier@free-electrons.com> --- drivers/spi/spi-armada-3700.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 0bfe5ff..e598421 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -170,12 +170,12 @@ static int a3700_spi_pin_mode_set(struct a3700_spi *a3700_spi, val &= ~(A3700_SPI_DATA_PIN0 | A3700_SPI_DATA_PIN1); switch (pin_mode) { - case 1: + case SPI_NBITS_SINGLE: break; - case 2: + case SPI_NBITS_DUAL: val |= A3700_SPI_DATA_PIN0; break; - case 4: + case SPI_NBITS_QUAD: val |= A3700_SPI_DATA_PIN1; break; default: -- 2.9.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "spi: armada-3700: Replaced raw values for nbits by the SPI macros" to the spi tree 2016-12-21 10:10 ` [PATCH 2/2] spi: armada-3700: Replaced raw values for nbits by the SPI macros Romain Perier @ 2017-01-04 18:37 ` Mark Brown 0 siblings, 0 replies; 5+ messages in thread From: Mark Brown @ 2017-01-04 18:37 UTC (permalink / raw) To: linux-arm-kernel The patch spi: armada-3700: Replaced raw values for nbits by the SPI macros has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From cfd6693c06324174ceeac7aed570a0df67db7c4f Mon Sep 17 00:00:00 2001 From: Romain Perier <romain.perier@free-electrons.com> Date: Wed, 21 Dec 2016 11:10:30 +0100 Subject: [PATCH] spi: armada-3700: Replaced raw values for nbits by the SPI macros Currently, function a3700_spi_pin_mode_set() configures the SPI transfer mode according to the value passed as second argument. This value is detected using the raw values from a switch case. This commit replaces these raw values by the corresponding macro constants in linux/spi/spi.h Signed-off-by: Romain Perier <romain.perier@free-electrons.com> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/spi-armada-3700.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 4e68f34957cc..9bee56ddff39 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -170,12 +170,12 @@ static int a3700_spi_pin_mode_set(struct a3700_spi *a3700_spi, val &= ~(A3700_SPI_DATA_PIN0 | A3700_SPI_DATA_PIN1); switch (pin_mode) { - case 1: + case SPI_NBITS_SINGLE: break; - case 2: + case SPI_NBITS_DUAL: val |= A3700_SPI_DATA_PIN0; break; - case 4: + case SPI_NBITS_QUAD: val |= A3700_SPI_DATA_PIN1; break; default: -- 2.11.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-04 18:37 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-21 10:10 [PATCH 0/2] Cosmetic changes for the SPI driver of ARMADA 3700 Romain Perier 2016-12-21 10:10 ` [PATCH 1/2] spi: armada-3700: Coding style fixes Romain Perier 2017-01-04 18:37 ` Applied "spi: armada-3700: Coding style fixes" to the spi tree Mark Brown 2016-12-21 10:10 ` [PATCH 2/2] spi: armada-3700: Replaced raw values for nbits by the SPI macros Romain Perier 2017-01-04 18:37 ` Applied "spi: armada-3700: Replaced raw values for nbits by the SPI macros" to the spi tree Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox