* [PATCH] ARM: sun8i: a23/a33: drop bl_en_pin GPIO pinmux in reference design DTSI
@ 2017-03-17 21:23 Icenowy Zheng
2017-03-20 8:31 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Icenowy Zheng @ 2017-03-17 21:23 UTC (permalink / raw)
To: linux-arm-kernel
The bl_en_pin GPIO pinmux is configured as "gpio_in", which makes it
conflicts with the real GPIO usage (out), and makes the backlight not
usable.
Drop the GPIO pinmux for it, thus this GPIO can be correctly used.
Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
Please patch latest git tree master too, as this issue affects 4.11-rc.
arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi b/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
index 9f097a3d723d..4ae638901159 100644
--- a/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
+++ b/arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi
@@ -50,8 +50,6 @@
backlight: backlight {
compatible = "pwm-backlight";
- pinctrl-names = "default";
- pinctrl-0 = <&bl_en_pin>;
pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>;
brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
default-brightness-level = <8>;
@@ -83,11 +81,6 @@
};
&pio {
- bl_en_pin: bl_en_pin at 0 {
- pins = "PH6";
- function = "gpio_in";
- };
-
mmc0_cd_pin: mmc0_cd_pin at 0 {
pins = "PB4";
function = "gpio_in";
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: sun8i: a23/a33: drop bl_en_pin GPIO pinmux in reference design DTSI
2017-03-17 21:23 [PATCH] ARM: sun8i: a23/a33: drop bl_en_pin GPIO pinmux in reference design DTSI Icenowy Zheng
@ 2017-03-20 8:31 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-03-20 8:31 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 18, 2017 at 05:23:15AM +0800, Icenowy Zheng wrote:
> The bl_en_pin GPIO pinmux is configured as "gpio_in", which makes it
> conflicts with the real GPIO usage (out), and makes the backlight not
> usable.
>
> Drop the GPIO pinmux for it, thus this GPIO can be correctly used.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170320/668912a0/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-20 8:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-17 21:23 [PATCH] ARM: sun8i: a23/a33: drop bl_en_pin GPIO pinmux in reference design DTSI Icenowy Zheng
2017-03-20 8:31 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox