Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes
@ 2017-03-20 11:25 Quentin Schulz
  2017-03-21 15:56 ` Maxime Ripard
  0 siblings, 1 reply; 2+ messages in thread
From: Quentin Schulz @ 2017-03-20 11:25 UTC (permalink / raw)
  To: linux-arm-kernel

The highest supported frequency (1.2GHz) requires to "overvolt" the CPU.
However, some boards still do not have the cpu-supply DT property in the
cpu DT node which means that the CPU will always run with the same input
voltage but try to run at 1.2GHz frequency. This is the source of
(experienced) CPU crashes.

Remove the OPP which requires overvolting the CPU until all boards have
a cpu-supply property.

Fixes: 03749eb88e635ad67818827adde8e5eea7b64571 ("ARM: dts: sun8i: add
opp-v2 table for A33")

Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
 arch/arm/boot/dts/sun8i-a33.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-a33.dtsi b/arch/arm/boot/dts/sun8i-a33.dtsi
index 9d82414..463b2b3 100644
--- a/arch/arm/boot/dts/sun8i-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a33.dtsi
@@ -121,12 +121,6 @@
 			opp-microvolt = <1200000>;
 			clock-latency-ns = <244144>; /* 8 32k periods */
 		};
-
-		opp at 1200000000 {
-			opp-hz = /bits/ 64 <1200000000>;
-			opp-microvolt = <1320000>;
-			clock-latency-ns = <244144>; /* 8 32k periods */
-		};
 	};
 
 	cpus {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes
  2017-03-20 11:25 [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes Quentin Schulz
@ 2017-03-21 15:56 ` Maxime Ripard
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-03-21 15:56 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 20, 2017 at 12:25:51PM +0100, Quentin Schulz wrote:
> The highest supported frequency (1.2GHz) requires to "overvolt" the CPU.
> However, some boards still do not have the cpu-supply DT property in the
> cpu DT node which means that the CPU will always run with the same input
> voltage but try to run at 1.2GHz frequency. This is the source of
> (experienced) CPU crashes.
> 
> Remove the OPP which requires overvolting the CPU until all boards have
> a cpu-supply property.
> 
> Fixes: 03749eb88e635ad67818827adde8e5eea7b64571 ("ARM: dts: sun8i: add
> opp-v2 table for A33")

The commit ID must be 12 chars, as documented in
Documentation/process/submitting-patches.rst.

You can also use the pretty format given there to be sure to have it
right.

> 
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170321/7ac25a32/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-21 15:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 11:25 [PATCH] ARM: sun8i: a33: remove highest OPP to fix CPU crashes Quentin Schulz
2017-03-21 15:56 ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox