From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs
Date: Tue, 11 Apr 2017 13:28:22 +0530 [thread overview]
Message-ID: <20170411075822.GA13627@vireshk-i7> (raw)
In-Reply-To: <20170411071911.1A8EF203634@relay.mailchannels.net>
On 11-04-17, 15:18, Icenowy Zheng wrote:
>
> 2017?4?11? 15:03? Viresh Kumar <viresh.kumar@linaro.org>???
> >
> > On Sun, Apr 9, 2017 at 12:20 AM, Icenowy Zheng <icenowy@aosc.io> wrote:
> > > Some new Allwinner SoCs get supported in the kernel after the
> > > compatibles are added to cpufreq-dt-platdev driver.
> > >
> > > Add their compatible strings in the cpufreq-dt-platdev driver.
> > >
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > ---
> > >? drivers/cpufreq/cpufreq-dt-platdev.c | 5 +++++
> > >? 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 921b4a6c3d16..2180e509e383 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -24,7 +24,12 @@ static const struct of_device_id machines[] __initconst = {
> > >???????? { .compatible = "allwinner,sun8i-a23", },
> > >???????? { .compatible = "allwinner,sun8i-a33", },
> > >???????? { .compatible = "allwinner,sun8i-a83t", },
> > > +?????? { .compatible = "allwinner,sun8i-h2-plus", },
> > >???????? { .compatible = "allwinner,sun8i-h3", },
> > > +?????? { .compatible = "allwinner,sun8i-v3s", },
> > > +?????? { .compatible = "allwinner,sun50i-a64", },
> > > +?????? { .compatible = "allwinner,sun50i-h5", },
> > > +?????? { .compatible = "nextthing,gr8", },
> >
> >
> > This needs to be in alphabetical order and please cc cpufreq
>
> However I prefer these sequence -- sun50i is later than sun8i.
>
> Place sun50i between sun4i and sun5i is meaningless, as sun50i in fact have a deep relationship with sun8i, but not sun4/5i.
We aren't really worried about relationship here. The order is important to find
missing entries as soon as possible and that's why I have been forcing people to
add entries in alphabetical order.
--
viresh
next parent reply other threads:[~2017-04-11 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170411071911.1A8EF203634@relay.mailchannels.net>
2017-04-11 7:58 ` Viresh Kumar [this message]
2017-04-08 18:50 [PATCH 0/5] Some Allwinner CCU tweaks and basical DVFS support for H3/H2+ Icenowy Zheng
2017-04-08 18:50 ` [PATCH 3/5] cpufreq: dt: Add support for some new Allwinner SoCs Icenowy Zheng
2017-04-11 7:03 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411075822.GA13627@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox